Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] glmark2: depend on host-python
Date: Mon, 28 Sep 2015 22:52:14 +0200	[thread overview]
Message-ID: <20150928225214.33f8785d@free-electrons.com> (raw)
In-Reply-To: <5608FB43.9060408@imgtec.com>

Vicente,

On Mon, 28 Sep 2015 09:33:07 +0100, Vicente Olivert Riera wrote:

> > From a quick look, I don't see anything in the glmark2 source code that
> > would need Python. It's really only waf itself that uses Python. So I
> > don't quite see where PYTHON_CONFIG can actually be useful...
> 
> Exactly. In fact, I managed to build the package when the value was
> $(STAGING_DIR)/usr/bin/python-config which didn't exist.
> 
> Should we remove it?

I don't know. It is there since when the package was originally
introduced by Spenser, so I have no idea why those three PYTHON_*
variables were added.

If the build works for you without those variables, then I would
suggest to remove them, and see what the autobuilders say.

What do you think?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-09-28 20:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 15:25 [Buildroot] [PATCH] glmark2: depend on host-python Vicente Olivert Riera
2015-09-25 15:27 ` Vicente Olivert Riera
2015-09-27 11:21 ` Bernd Kuhls
2015-09-27 19:21 ` Thomas Petazzoni
2015-09-28  8:33   ` Vicente Olivert Riera
2015-09-28 20:52     ` Thomas Petazzoni [this message]
2015-09-29 18:13       ` Vicente Olivert Riera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150928225214.33f8785d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox