From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] glmark2: depend on host-python
Date: Fri, 25 Sep 2015 16:27:44 +0100 [thread overview]
Message-ID: <560567F0.9060206@imgtec.com> (raw)
In-Reply-To: <1443194731-52284-1-git-send-email-Vincent.Riera@imgtec.com>
Maintainer please,
On 09/25/2015 04:25 PM, Vicente Olivert Riera wrote:
> The waf build system of glmark2 needs Python 2 as stated on its README
> file:
>
> python 2.x (>= 2.4) for the build system (waf)
>
> Building it with a system with Python 3 as the default Python version
> will result on a failure like this one:
>
> File "waflib/Utils.py", line 199
> except OSError ,e:
> ^
> SyntaxError: invalid syntax
>
> So, in order to fix this, make this package depending on host-python and
> also run the waf script using $(HOST_DIR)/usr/bin/python2.
>
> At the same time fix a typo in the .mk file. The python-config script is
> localed at $(HOST_DIR)/usr/bin/ instead of $(STAGING_DIR)/usr/bin/.
s/localed/located/
Sorry,
Vincent.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/fc6/fc6cd2a90bbb0e6f80f6c4afaae1430f82e54046/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/glmark2/glmark2.mk | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/package/glmark2/glmark2.mk b/package/glmark2/glmark2.mk
> index ffaea73..32112b4 100644
> --- a/package/glmark2/glmark2.mk
> +++ b/package/glmark2/glmark2.mk
> @@ -8,7 +8,7 @@ GLMARK2_VERSION = 499aa81a68fb4c8aac1c80f0d6a4cce05941c4cc
> GLMARK2_SITE = $(call github,glmark2,glmark2,$(GLMARK2_VERSION))
> GLMARK2_LICENSE = GPLv3+ SGIv1
> GLMARK2_LICENSE_FILES = COPYING COPYING.SGI
> -GLMARK2_DEPENDENCIES = host-pkgconf jpeg libpng \
> +GLMARK2_DEPENDENCIES = host-pkgconf host-python jpeg libpng \
> $(if $(BR2_PACKAGE_HAS_LIBEGL),libegl) \
> $(if $(BR2_PACKAGE_HAS_LIBGLES),libgles) \
> $(if $(BR2_PACKAGE_HAS_LIBGL),libgl)
> @@ -47,21 +47,21 @@ GLMARK2_CONF_OPTS += \
>
> define GLMARK2_CONFIGURE_CMDS
> (cd $(@D); \
> - PYTHON_CONFIG="$(STAGING_DIR)/usr/bin/python-config" \
> + PYTHON_CONFIG="$(HOST_DIR)/usr/bin/python-config" \
> python_LDFLAGS="" \
> python_LIBDIR="" \
> $(TARGET_CONFIGURE_OPTS) \
> $(GLMARK2_CONF_ENV) \
> - ./waf configure $(GLMARK2_CONF_OPTS) \
> + $(HOST_DIR)/usr/bin/python2 ./waf configure $(GLMARK2_CONF_OPTS) \
> )
> endef
>
> define GLMARK2_BUILD_CMDS
> - cd $(@D) && $(TARGET_MAKE_ENV) ./waf
> + cd $(@D) && $(TARGET_MAKE_ENV) $(HOST_DIR)/usr/bin/python2 ./waf
> endef
>
> define GLMARK2_INSTALL_TARGET_CMDS
> - cd $(@D) && $(TARGET_MAKE_ENV) ./waf install --destdir=$(TARGET_DIR)
> + cd $(@D) && $(TARGET_MAKE_ENV) $(HOST_DIR)/usr/bin/python2 ./waf install --destdir=$(TARGET_DIR)
> endef
>
> $(eval $(generic-package))
>
next prev parent reply other threads:[~2015-09-25 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 15:25 [Buildroot] [PATCH] glmark2: depend on host-python Vicente Olivert Riera
2015-09-25 15:27 ` Vicente Olivert Riera [this message]
2015-09-27 11:21 ` Bernd Kuhls
2015-09-27 19:21 ` Thomas Petazzoni
2015-09-28 8:33 ` Vicente Olivert Riera
2015-09-28 20:52 ` Thomas Petazzoni
2015-09-29 18:13 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560567F0.9060206@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox