[Buildroot] [PATCH] glmark2: depend on host-python

[Vicente Olivert Riera <Vincent.Riera@imgtec.com>]

Hi Thomas,

On 09/27/2015 08:21 PM, Thomas Petazzoni wrote:
> Vicente,
> 
> On Fri, 25 Sep 2015 16:25:31 +0100, Vicente Olivert Riera wrote:
>> The waf build system of glmark2 needs Python 2 as stated on its README
>> file:
>>
>> python 2.x (>= 2.4) for the build system (waf)
>>
>> Building it with a system with Python 3 as the default Python version
>> will result on a failure like this one:
>>
>> File "waflib/Utils.py", line 199
>>     except OSError ,e:
>>                    ^
>> SyntaxError: invalid syntax
>>
>> So, in order to fix this, make this package depending on host-python and
>> also run the waf script using $(HOST_DIR)/usr/bin/python2.
> 
> This part is fine.
> 
>> At the same time fix a typo in the .mk file. The python-config script is
>> localed at $(HOST_DIR)/usr/bin/ instead of $(STAGING_DIR)/usr/bin/.
> 
> But I'm not sure at all about this part.
> $(HOST_DIR)/usr/bin/python-config will give results that are valid to
> build things against the *host* Python, while
> $(STAGING_DIR)/usr/bin/python-config will give results that are valid
> to build things against the *target* Python.
> 
> Therefore, it is necessary to look into the Waf logic to understand how
> PYTHON_CONFIG is used. Is it used to build just things that used
> during the build process and therefore probably built against the host
> Python, or is it about building things against the target Python?
> 
> From a quick look, I don't see anything in the glmark2 source code that
> would need Python. It's really only waf itself that uses Python. So I
> don't quite see where PYTHON_CONFIG can actually be useful...

Exactly. In fact, I managed to build the package when the value was
$(STAGING_DIR)/usr/bin/python-config which didn't exist.

Should we remove it?

Regards,

Vincent.


> 
> Thomas
>