[Buildroot] [PATCH 1/2] libbluray: add optional fontconfig dependency

[Buildroot] [PATCH 1/2] libbluray: add optional fontconfig dependency

[Baruch Siach]

Fixes:
http://autobuild.buildroot.net/results/dbf/dbfbf09f48e7ec09be34a3a40d3c859b74379eaf/
http://autobuild.buildroot.net/results/3fb/3fb9c077d4fe772774f53c7611b4dcbaad361312/
http://autobuild.buildroot.net/results/f9c/f9c1f3cf8bfa9eeacb7719459c22bdf7dea26ddb/

and more.

Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/libbluray/libbluray.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/libbluray/libbluray.mk b/package/libbluray/libbluray.mk
index e10f7dbc8c73..f6a501a1083f 100644
--- a/package/libbluray/libbluray.mk
+++ b/package/libbluray/libbluray.mk
@@ -24,6 +24,12 @@ else
 LIBBLURAY_CONF_OPTS += --without-freetype
 endif
 
+ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
+LIBBLURAY_DEPENDENCIES += fontconfig
+else
+LIBBLURAY_CONF_OPTS += --without-fontconfig
+endif
+
 ifeq ($(BR2_PACKAGE_LIBXML2),y)
 LIBBLURAY_DEPENDENCIES += libxml2
 else
-- 
2.5.3

[Buildroot] [PATCH 2/2] libbluray: disable BD-Java

[Baruch Siach]

BD-Java requires host-ant which is not currently available in Buildroot.

Fixes:
http://autobuild.buildroot.net/results/e87/e8790359cc12d73a22a168a61f59215e50a58f0f/
http://autobuild.buildroot.net/results/bb3/bb33effb844fd6c06efa033cc3e3cb4b4495d1d5/
http://autobuild.buildroot.net/results/623/623de2013eba2bff2d0863968e76f299488f9f35/

and more.

Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/libbluray/libbluray.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libbluray/libbluray.mk b/package/libbluray/libbluray.mk
index f6a501a1083f..2e9268ef29ac 100644
--- a/package/libbluray/libbluray.mk
+++ b/package/libbluray/libbluray.mk
@@ -12,7 +12,7 @@ LIBBLURAY_LICENSE = LGPLv2.1+
 LIBBLURAY_LICENSE_FILES = COPYING
 LIBBLURAY_DEPENDENCIES = host-pkgconf
 
-LIBBLURAY_CONF_OPTS = --enable-udf
+LIBBLURAY_CONF_OPTS = --enable-udf --disable-bdjava
 
 ifeq ($(BR2_PACKAGE_LIBICONV),y)
 LIBBLURAY_DEPENDENCIES += libiconv
-- 
2.5.3

[Buildroot] [PATCH 2/2] libbluray: disable BD-Java

[Thomas Petazzoni]

Dear Baruch Siach,

On Tue, 29 Sep 2015 15:58:23 +0300, Baruch Siach wrote:
> BD-Java requires host-ant which is not currently available in Buildroot.
> 
> Fixes:
> http://autobuild.buildroot.net/results/e87/e8790359cc12d73a22a168a61f59215e50a58f0f/
> http://autobuild.buildroot.net/results/bb3/bb33effb844fd6c06efa033cc3e3cb4b4495d1d5/
> http://autobuild.buildroot.net/results/623/623de2013eba2bff2d0863968e76f299488f9f35/
> 
> and more.
> 
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/libbluray/libbluray.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] libbluray: add optional fontconfig dependency

[Thomas Petazzoni]

Baruch,

On Tue, 29 Sep 2015 15:58:22 +0300, Baruch Siach wrote:

> diff --git a/package/libbluray/libbluray.mk b/package/libbluray/libbluray.mk
> index e10f7dbc8c73..f6a501a1083f 100644
> --- a/package/libbluray/libbluray.mk
> +++ b/package/libbluray/libbluray.mk
> @@ -24,6 +24,12 @@ else
>  LIBBLURAY_CONF_OPTS += --without-freetype
>  endif
>  
> +ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
> +LIBBLURAY_DEPENDENCIES += fontconfig
> +else
> +LIBBLURAY_CONF_OPTS += --without-fontconfig
> +endif

I would prefer to have an explicit --with-fontconfig when
BR2_PACKAGE_FONTCONFIG=y. I know it's not the case for the other
dependencies already handled by libbluray.mk, so I've applied your
patch as is, and my comment can be fixed for all optional dependencies
of libbluray in a separate patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] libbluray: add optional fontconfig dependency

[Baruch Siach]

Hi Thomas,

On Tue, Sep 29, 2015 at 07:41:54PM +0200, Thomas Petazzoni wrote:
> On Tue, 29 Sep 2015 15:58:22 +0300, Baruch Siach wrote:
> 
> > diff --git a/package/libbluray/libbluray.mk b/package/libbluray/libbluray.mk
> > index e10f7dbc8c73..f6a501a1083f 100644
> > --- a/package/libbluray/libbluray.mk
> > +++ b/package/libbluray/libbluray.mk
> > @@ -24,6 +24,12 @@ else
> >  LIBBLURAY_CONF_OPTS += --without-freetype
> >  endif
> >  
> > +ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
> > +LIBBLURAY_DEPENDENCIES += fontconfig
> > +else
> > +LIBBLURAY_CONF_OPTS += --without-fontconfig
> > +endif
> 
> I would prefer to have an explicit --with-fontconfig when
> BR2_PACKAGE_FONTCONFIG=y. I know it's not the case for the other
> dependencies already handled by libbluray.mk, so I've applied your
> patch as is, and my comment can be fixed for all optional dependencies
> of libbluray in a separate patch.

Just posted a patch for that.

Thanks,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -