From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2 v2] package/nodejs: fix architectural dependencies on ARM
Date: Mon, 19 Oct 2015 22:27:10 +0200 [thread overview]
Message-ID: <20151019222710.74159e82@free-electrons.com> (raw)
In-Reply-To: <03bfe81f7d32e7eb9b032d41d8c720d7ab95cb69.1445277033.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Mon, 19 Oct 2015 19:51:00 +0200, Yann E. MORIN wrote:
> +# Starting with 0.12.x, on ARM, V8 (the JS engine)
> +# requires an armv6+ and a VFPv2+.
> +config BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
> + bool
> + default y
> + depends on !BR2_arm || !BR2_ARM_CPU_ARMV5 && BR2_ARM_CPU_HAS_VFPV2
I would find the following to be a bit easier to understand:
# On supported architectures other than ARM, no special requirement
default y if !BR2_arm
# On ARM, at least ARMv6+ with VFPv2+ is needed
default y if !BR2_ARM_CPU_ARMV5 && BR2_ARM_CPU_HAS_VFPV2
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-19 20:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 17:50 [Buildroot] [PATCH 0/2 v2] package/nodejs: bump version (branch yem/node) Yann E. MORIN
2015-10-19 17:51 ` [Buildroot] [PATCH 1/2 v2] package/nodejs: fix architectural dependencies on ARM Yann E. MORIN
2015-10-19 20:27 ` Thomas Petazzoni [this message]
2015-10-19 20:30 ` Yann E. MORIN
2015-10-19 20:58 ` Jörg Krause
2015-10-19 21:10 ` Yann E. MORIN
2015-10-19 17:51 ` [Buildroot] [PATCH 2/2 v2] package/nodejs: add version 4.1.2 Yann E. MORIN
2015-10-19 20:30 ` Thomas Petazzoni
2015-10-19 20:35 ` Yann E. MORIN
2015-10-19 20:37 ` Thomas Petazzoni
2015-10-19 20:44 ` Yann E. MORIN
2015-10-19 21:31 ` Jörg Krause
2015-10-19 21:35 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151019222710.74159e82@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox