Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2 v2] package/nodejs: add version 4.1.2
Date: Mon, 19 Oct 2015 22:37:59 +0200	[thread overview]
Message-ID: <20151019223759.104d9e82@free-electrons.com> (raw)
In-Reply-To: <20151019203543.GD3651@free.fr>

Dear Yann E. MORIN,

On Mon, 19 Oct 2015 22:35:43 +0200, Yann E. MORIN wrote:

> > ... and compare it to the patch. You're no longer importing bz2
> > anywhere. Look at the same patch for 0.10 and 0.12, it is importing the
> > bz2 module, just conditionally.
> 
> ACK, I'll fix that commit log.

So the bz2 import is no longer needed at all?

> > We should maybe also upstream our nodejs patches... But that's a
> > separate work.
> 
> I can take a shot at that...

Would be good, but it is definitely not mandatory to get your patch
accepted, of course.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-10-19 20:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 17:50 [Buildroot] [PATCH 0/2 v2] package/nodejs: bump version (branch yem/node) Yann E. MORIN
2015-10-19 17:51 ` [Buildroot] [PATCH 1/2 v2] package/nodejs: fix architectural dependencies on ARM Yann E. MORIN
2015-10-19 20:27   ` Thomas Petazzoni
2015-10-19 20:30     ` Yann E. MORIN
2015-10-19 20:58   ` Jörg Krause
2015-10-19 21:10     ` Yann E. MORIN
2015-10-19 17:51 ` [Buildroot] [PATCH 2/2 v2] package/nodejs: add version 4.1.2 Yann E. MORIN
2015-10-19 20:30   ` Thomas Petazzoni
2015-10-19 20:35     ` Yann E. MORIN
2015-10-19 20:37       ` Thomas Petazzoni [this message]
2015-10-19 20:44         ` Yann E. MORIN
2015-10-19 21:31   ` Jörg Krause
2015-10-19 21:35     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151019223759.104d9e82@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox