Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2 v2] package/nodejs: fix architectural dependencies on ARM
Date: Mon, 19 Oct 2015 22:30:09 +0200	[thread overview]
Message-ID: <20151019203009.GC3651@free.fr> (raw)
In-Reply-To: <20151019222710.74159e82@free-electrons.com>

Thomas, All,

On 2015-10-19 22:27 +0200, Thomas Petazzoni spake thusly:
> On Mon, 19 Oct 2015 19:51:00 +0200, Yann E. MORIN wrote:
> > +# Starting with 0.12.x, on ARM, V8 (the JS engine)
> > +# requires an armv6+ and a VFPv2+.
> > +config BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
> > +	bool
> > +	default y
> > +	depends on !BR2_arm || !BR2_ARM_CPU_ARMV5 && BR2_ARM_CPU_HAS_VFPV2
> 
> I would find the following to be a bit easier to understand:
> 
> 	# On supported architectures other than ARM, no special requirement
> 	default y if !BR2_arm
> 	# On ARM, at least ARMv6+ with VFPv2+ is needed
> 	default y if !BR2_ARM_CPU_ARMV5 && BR2_ARM_CPU_HAS_VFPV2

Yes, tht's a bit better, indeed.

Will fix and resend. Thanks! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-10-19 20:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 17:50 [Buildroot] [PATCH 0/2 v2] package/nodejs: bump version (branch yem/node) Yann E. MORIN
2015-10-19 17:51 ` [Buildroot] [PATCH 1/2 v2] package/nodejs: fix architectural dependencies on ARM Yann E. MORIN
2015-10-19 20:27   ` Thomas Petazzoni
2015-10-19 20:30     ` Yann E. MORIN [this message]
2015-10-19 20:58   ` Jörg Krause
2015-10-19 21:10     ` Yann E. MORIN
2015-10-19 17:51 ` [Buildroot] [PATCH 2/2 v2] package/nodejs: add version 4.1.2 Yann E. MORIN
2015-10-19 20:30   ` Thomas Petazzoni
2015-10-19 20:35     ` Yann E. MORIN
2015-10-19 20:37       ` Thomas Petazzoni
2015-10-19 20:44         ` Yann E. MORIN
2015-10-19 21:31   ` Jörg Krause
2015-10-19 21:35     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151019203009.GC3651@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox