[Buildroot] [PATCH 12/51] core/apply-patches: store full path of applied patches

[Yann E. MORIN <yann.morin.1998@free.fr>]

Luca, All,

On 2015-12-03 18:18 +0100, Luca Ceresoli spake thusly:
> Yann E. MORIN wrote:
> >Currently, we only store the filename of the applied patches.
> >
> >However, we are soon to want to install those patches in the legal-info
> >directory, so we'll have to know where those patches come from.
> >
> >Instead of duplicating the logic to find the patches, just store the
> >full path to each of those patches so we can retrieve them more easily
> >later on.
> 
> Mmh, storing absolute pathnames always look a bit ugly... Any simple
> way to store the relative path ("package/busybox/0002-unzip.patch")?

What about GLOBAL_PATCH_DIR or downloaded patches, or patches from
BR2_EXTERNAL?

As I said in the commit log, it's better not to replicate the logic
to find the patches. We already have a non-trivial heuristic in
pkg-generic, so better make use of it.

> Also, there's a double slash in the output:
> $ cat ./output/build/busybox-1.24.1/.applied_patches_list
> /home/murray/devel/buildroot/package/busybox//0001-networking-libiproute-use-linux-if_packet.h-instead-.patch

Yeah, is that a problem?

If that bothers you, I can try to fix that. But the directory component
is passed straight from the pkg-generic infra (the $(@D) as set by make).

> BTW, in order to evaluate the risk that your change breaks something,
> I found myself wondering what .applied_patches_list is used for. And it
> seems unused... am I missing something?

Not at all. Nothing uses it so far. Hence we're free to change its
content.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'