From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 09/51] core/pkg-virtual: ignore from legal-info output
Date: Thu, 3 Dec 2015 18:13:07 +0100 [thread overview]
Message-ID: <56607823.40409@lucaceresoli.net> (raw)
In-Reply-To: <2788d5c56e3bbcb579972f9e81003d0625dfefa3.1448289515.git.yann.morin.1998@free.fr>
Dear Yann,
Yann E. MORIN wrote:
> Virtual packages really have nothing to save for legal-info, so we just
> ignore them.
>
> Currently, packages are only extracted if they define _LICENSE_FILES.
> Follow-up patches will always extract and patch non-ignored packages, so
> we would potentially see spurious "extracting" and "patching" messages
> for virtual packages on the console, which would be a bit strange.
> Ignoring virtual packages will get us a cleaner log.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> docs/manual/adding-packages-virtual.txt | 3 +++
> package/pkg-virtual.mk | 2 ++
> 2 files changed, 5 insertions(+)
>
> diff --git a/docs/manual/adding-packages-virtual.txt b/docs/manual/adding-packages-virtual.txt
> index a5f17a2..11a497d 100644
> --- a/docs/manual/adding-packages-virtual.txt
> +++ b/docs/manual/adding-packages-virtual.txt
> @@ -56,6 +56,9 @@ The +.mk+ for the virtual package should just evaluate the +virtual-package+ mac
> The ability to have target and host packages is also available, with the
> +host-virtual-package+ macro.
>
> +.Note:
> +Virtual packages are automatically ignored when generating the +legal-info+ output.
> +
> ==== Provider's +Config.in+ file
>
> When adding a package as a provider, only the +Config.in+ file requires some
> diff --git a/package/pkg-virtual.mk b/package/pkg-virtual.mk
> index 9c68b51..1471b95 100644
> --- a/package/pkg-virtual.mk
> +++ b/package/pkg-virtual.mk
> @@ -57,6 +57,8 @@ endif
> # Add dependency against the provider
> $(2)_DEPENDENCIES += $$(call qstrip,$$(BR2_PACKAGE_PROVIDES_$(2)))
>
> +$(2)_REDISTRIBUTE = IGNORE
> +
Ack on the idea, but of course the patch shall be re-written to use the
boolean variables instead.
--
Luca
next prev parent reply other threads:[~2015-12-03 17:13 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 14:48 [Buildroot] [PATCH 0/51] legal-info: unassorted improvements and fixes (branch yem/legal) Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 01/51] core/pkg-autotools: align host configure commands to target one Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 02/51] package/gcc: comment on why we override the generic configure commands Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 03/51] package/gcc: align gcc-final configure-cmds to the generic ones Yann E. MORIN
2015-12-03 17:10 ` Luca Ceresoli
2015-11-23 14:47 ` [Buildroot] [PATCH 04/51] core/pkg-generic: add macro to hardlink-or-copy Yann E. MORIN
2015-11-23 17:15 ` Luca Ceresoli
2015-11-23 14:47 ` [Buildroot] [PATCH 05/51] core/legal-info: use the macro to install source archives Yann E. MORIN
2015-11-23 17:18 ` Luca Ceresoli
2015-11-23 17:21 ` Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 06/51] package/perl: include perl-cross in the legal-info output Yann E. MORIN
2015-11-23 17:25 ` Luca Ceresoli
2015-11-23 17:58 ` Yann E. MORIN
2015-11-23 20:24 ` Thomas Petazzoni
2015-11-23 21:23 ` Yann E. MORIN
2015-12-03 17:11 ` Luca Ceresoli
2015-12-03 18:37 ` Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 07/51] core: add a global variable with already-unquoted global patch dir Yann E. MORIN
2015-11-23 16:18 ` Thomas Petazzoni
2015-11-23 16:30 ` Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 08/51] core/legal-info: allow ignoring packages from the legal-info Yann E. MORIN
2015-11-23 20:26 ` Thomas Petazzoni
2015-11-24 22:05 ` Peter Korsgaard
2015-12-03 17:12 ` Luca Ceresoli
2015-12-03 18:36 ` Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 09/51] core/pkg-virtual: ignore from legal-info output Yann E. MORIN
2015-12-03 17:13 ` Luca Ceresoli [this message]
2015-11-23 14:47 ` [Buildroot] [PATCH 10/51] core/legal-info: install source archives in their own sub-dir Yann E. MORIN
2015-12-03 17:16 ` Luca Ceresoli
2015-12-03 17:25 ` Luca Ceresoli
2015-11-23 14:47 ` [Buildroot] [PATCH 11/51] core/legal-info: add package version to license directory Yann E. MORIN
2015-12-03 17:17 ` Luca Ceresoli
2015-12-03 18:41 ` Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 12/51] core/apply-patches: store full path of applied patches Yann E. MORIN
2015-12-03 17:18 ` Luca Ceresoli
2015-12-03 18:52 ` Yann E. MORIN
2015-12-04 12:02 ` Luca Ceresoli
2015-11-23 14:47 ` [Buildroot] [PATCH 13/51] core/legal-info: also save patches Yann E. MORIN
2015-12-03 17:19 ` Luca Ceresoli
2015-11-23 14:47 ` [Buildroot] [PATCH 14/51] core/legal-info: update the legal-info report header Yann E. MORIN
2015-12-03 17:21 ` Luca Ceresoli
2015-12-03 18:53 ` Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 15/51] core/legal-info: ensure legal-info works in off-line mode Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 16/51] toolchain/external: add hash for Arago actual sources Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 17/51] core/legal-info: generate a hash of all saved files Yann E. MORIN
2015-12-03 17:24 ` Luca Ceresoli
2015-12-03 19:11 ` Yann E. MORIN
2015-12-04 11:40 ` Luca Ceresoli
2015-11-23 14:47 ` [Buildroot] [PATCH 18/51] package/gcc: add a patch for arc rather than using sed Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 19/51] package/gcc: simplify setting GCC_SOURCE Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 20/51] pacakge/gcc: rename all variables as it is a host-only package Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 21/51] package/gcc: prefix all common variables with HOST_GCC_COMMON_ Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 22/51] package/gcc: rename the common files Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 23/51] package/gcc: rename gcc-final into plain gcc Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 24/51] package/gcc-initial: ignore from legal-info output Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 25/51] package/gcc: add licensing info for host variant Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 26/51] package/gcc: create the ./configure symlink as a post-patch hook Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 27/51] pacakge/gcc: drop custom patch command Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 28/51] core: include arch-specific definitions Yann E. MORIN
2015-11-23 14:47 ` [Buildroot] [PATCH 29/51] arch/xtensa: add definitions for the Xtensa overlay Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 30/51] package/binutils: use the Xtensa variables Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 31/51] package/gdb: " Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 32/51] package/gcc: " Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 33/51] arch/xtensa: add macro to extract the overlay Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 34/51] package/binutils: use macro to extract Xtensa overlay Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 35/51] package/gdb: " Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 36/51] package/gcc: " Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 37/51] arch/xtensa: add macro to install legal-info Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 38/51] pacage/gcc: use macro to install Xtensa overlay legal-info Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 39/51] package/binutils: " Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 40/51] package/gdb: " Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 41/51] package/binutils: extract Xtensa overlay as post-extract hook Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 42/51] package/gdb: " Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 43/51] arch/xtensa: add macros to generate hooks Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 44/51] package/binutils: use the Xtensa macro generators Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 45/51] package/gdb: " Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 46/51] package/gcc: " Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 47/51] arc/xtensa: get rid of an intermediate blind kconfig option Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 48/51] arch/xtensa: allow specifying path to tarball file Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 49/51] arch/xtensa: accept the overlay to be compressed Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 50/51] arch/xtensa: accept the overlay to be an URL Yann E. MORIN
2015-11-23 20:35 ` Thomas Petazzoni
2015-11-23 21:28 ` Yann E. MORIN
2015-11-23 14:48 ` [Buildroot] [PATCH 51/51] configs/qemu-xtensa: use overlay from the github repository Yann E. MORIN
2015-11-23 20:22 ` [Buildroot] [PATCH 0/51] legal-info: unassorted improvements and fixes (branch yem/legal) Thomas Petazzoni
2015-11-23 21:09 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56607823.40409@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox