[Buildroot] [PATCH 13/51] core/legal-info: also save patches

[Luca Ceresoli <luca@lucaceresoli.net>]

Dear Yann,

Yann E. MORIN wrote:
> Currently, the legal-info infra only saves the source archive of a
> package. However, that's not enough as we may apply some patches on
> packages sources.
>
> We do suggest users to also redistribute the Buildroot sources as part
> of their compliance distribution, so the patches bundled in Buildroot
> would indeed be included in the compliance distribution.
>
> However, that's still not enough, since we may download some patches, or
> the user may use a global patch directory. Patches in there might not
> end up in the compliance distribution, and there are risks of
> non-conformity.
>
> So, always include patches alongside the source archive.
>
> To ensure reproducibility, we also generate a series file, so patches
> can be re-applied in the correct order.
>
> We get the list of patches to include from the list of patches that were
> applied by the package infrastructure (via the apply-patches support
> script). So, we need to get packages properly extracted and patched
> before we can save their legal-info, not just in the case they define
> _LICENSE_FILES (however, we need not extract and patch a package if it
> is set to be ignored for redistribution).
>
> Update the legal-info header accordingly.
>
> Note: this means that, when a (non-ignored) package is not patched and
> defines no LICENSE_FILES, we will extract and patch it for nothing.
> There is no easy way to know whether we have to patch a package or not.
> We can only either duplicate the logic to detect patches (bad) or rely
> on the infra actually patching the package.  Also, a vast majority of
> packages are either patched, or define _LICENSE_FILES, so it is best and
> easiest to always extract and patch them prior to legal-info.

Anything else would be more complex and give little advantage. Ideally
we should have _LICENSE_FILES defined for nearly all packages, after
all.

So:

Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Acked-by: Luca Ceresoli <luca@lucaceresoli.net>

-- 
Luca