* [Buildroot] [PATCH] libsemanage: fix build error when linking with ustr
@ 2015-12-03 20:25 Sergio Prado
2015-12-03 21:07 ` Thomas Petazzoni
2015-12-08 20:59 ` Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Sergio Prado @ 2015-12-03 20:25 UTC (permalink / raw)
To: buildroot
Disable ustr inline functions to avoid multiple definition of symbols error
when linking with ustr.
Fixes:
http://autobuild.buildroot.net/results/e7012c7a734dbdd1c697cf63b6df6e834e8eafc7
http://autobuild.buildroot.net/results/0783a63e4694ffa8463ef5533b635c7e7c43dd42
http://autobuild.buildroot.net/results/40726abf3419a727c5762ef2791dbf53fa1736c0
http://autobuild.buildroot.net/results/a6a0c827c393a5fb41653d71d1ee50df283a32fb
...
Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
---
package/libsemanage/libsemanage.mk | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/package/libsemanage/libsemanage.mk b/package/libsemanage/libsemanage.mk
index 197c14e4229a..ea9f4c9f67de 100644
--- a/package/libsemanage/libsemanage.mk
+++ b/package/libsemanage/libsemanage.mk
@@ -13,10 +13,15 @@ LIBSEMANAGE_INSTALL_STAGING = YES
LIBSEMANAGE_MAKE_OPTS = $(TARGET_CONFIGURE_OPTS)
+# disable ustr inline functions to avoid multiple definition of symbols
+# error when linking
+LIBSEMANAGE_CFLAGS = $(TARGET_CFLAGS) -DUSTR_CONF_COMPILE_USE_INLINE=0
+
define LIBSEMANAGE_BUILD_CMDS
# DESTDIR is needed during the compile to compute library and
# header paths.
- $(MAKE) -C $(@D) $(LIBSEMANAGE_MAKE_OPTS) DESTDIR=$(STAGING_DIR) all
+ $(MAKE) -C $(@D) $(LIBSEMANAGE_MAKE_OPTS) CFLAGS="$(LIBSEMANAGE_CFLAGS)" \
+ DESTDIR=$(STAGING_DIR) all
endef
define LIBSEMANAGE_INSTALL_STAGING_CMDS
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] libsemanage: fix build error when linking with ustr
2015-12-03 20:25 [Buildroot] [PATCH] libsemanage: fix build error when linking with ustr Sergio Prado
@ 2015-12-03 21:07 ` Thomas Petazzoni
2015-12-08 20:59 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2015-12-03 21:07 UTC (permalink / raw)
To: buildroot
Sergio,
On Thu, 3 Dec 2015 18:25:28 -0200, Sergio Prado wrote:
> Disable ustr inline functions to avoid multiple definition of symbols error
> when linking with ustr.
>
> Fixes:
> http://autobuild.buildroot.net/results/e7012c7a734dbdd1c697cf63b6df6e834e8eafc7
> http://autobuild.buildroot.net/results/0783a63e4694ffa8463ef5533b635c7e7c43dd42
> http://autobuild.buildroot.net/results/40726abf3419a727c5762ef2791dbf53fa1736c0
> http://autobuild.buildroot.net/results/a6a0c827c393a5fb41653d71d1ee50df283a32fb
> ...
>
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
There is another fix pending for this problem, which consists in
bumping the ustr version. See http://patchwork.ozlabs.org/patch/547117/
and http://patchwork.ozlabs.org/patch/547118/.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] libsemanage: fix build error when linking with ustr
2015-12-03 20:25 [Buildroot] [PATCH] libsemanage: fix build error when linking with ustr Sergio Prado
2015-12-03 21:07 ` Thomas Petazzoni
@ 2015-12-08 20:59 ` Yann E. MORIN
2015-12-09 0:59 ` Sergio Prado
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2015-12-08 20:59 UTC (permalink / raw)
To: buildroot
Sergio, All,
Thanks for your patch! :-)
On 2015-12-03 18:25 -0200, Sergio Prado spake thusly:
> Disable ustr inline functions to avoid multiple definition of symbols error
> when linking with ustr.
>
> Fixes:
> http://autobuild.buildroot.net/results/e7012c7a734dbdd1c697cf63b6df6e834e8eafc7
> http://autobuild.buildroot.net/results/0783a63e4694ffa8463ef5533b635c7e7c43dd42
> http://autobuild.buildroot.net/results/40726abf3419a727c5762ef2791dbf53fa1736c0
> http://autobuild.buildroot.net/results/a6a0c827c393a5fb41653d71d1ee50df283a32fb
> ...
>
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
As Thomas already pointed to, there is already a two-patch series to fix
the issue by bumping and fixing ustr itself.
So I've marked your patch as rejected in our patchwork:
https://patchwork.ozlabs.org/patch/552445/
Thanks! :-)
Regards,
Yann E. MORIN.
> ---
> package/libsemanage/libsemanage.mk | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/package/libsemanage/libsemanage.mk b/package/libsemanage/libsemanage.mk
> index 197c14e4229a..ea9f4c9f67de 100644
> --- a/package/libsemanage/libsemanage.mk
> +++ b/package/libsemanage/libsemanage.mk
> @@ -13,10 +13,15 @@ LIBSEMANAGE_INSTALL_STAGING = YES
>
> LIBSEMANAGE_MAKE_OPTS = $(TARGET_CONFIGURE_OPTS)
>
> +# disable ustr inline functions to avoid multiple definition of symbols
> +# error when linking
> +LIBSEMANAGE_CFLAGS = $(TARGET_CFLAGS) -DUSTR_CONF_COMPILE_USE_INLINE=0
> +
> define LIBSEMANAGE_BUILD_CMDS
> # DESTDIR is needed during the compile to compute library and
> # header paths.
> - $(MAKE) -C $(@D) $(LIBSEMANAGE_MAKE_OPTS) DESTDIR=$(STAGING_DIR) all
> + $(MAKE) -C $(@D) $(LIBSEMANAGE_MAKE_OPTS) CFLAGS="$(LIBSEMANAGE_CFLAGS)" \
> + DESTDIR=$(STAGING_DIR) all
> endef
>
> define LIBSEMANAGE_INSTALL_STAGING_CMDS
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] libsemanage: fix build error when linking with ustr
2015-12-08 20:59 ` Yann E. MORIN
@ 2015-12-09 0:59 ` Sergio Prado
0 siblings, 0 replies; 4+ messages in thread
From: Sergio Prado @ 2015-12-09 0:59 UTC (permalink / raw)
To: buildroot
2015-12-08 18:59 GMT-02:00 Yann E. MORIN <yann.morin.1998@free.fr>:
> Sergio, All,
>
> Thanks for your patch! :-)
>
> On 2015-12-03 18:25 -0200, Sergio Prado spake thusly:
> > Disable ustr inline functions to avoid multiple definition of symbols
> error
> > when linking with ustr.
> >
> > Fixes:
> >
> http://autobuild.buildroot.net/results/e7012c7a734dbdd1c697cf63b6df6e834e8eafc7
> >
> http://autobuild.buildroot.net/results/0783a63e4694ffa8463ef5533b635c7e7c43dd42
> >
> http://autobuild.buildroot.net/results/40726abf3419a727c5762ef2791dbf53fa1736c0
> >
> http://autobuild.buildroot.net/results/a6a0c827c393a5fb41653d71d1ee50df283a32fb
> > ...
> >
> > Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
>
> As Thomas already pointed to, there is already a two-patch series to fix
> the issue by bumping and fixing ustr itself.
> So I've marked your patch as rejected in our patchwork:
> https://patchwork.ozlabs.org/patch/552445/
OK.
>
>
> Thanks! :-)
>
Thanks,
>
> Regards,
> Yann E. MORIN.
>
> > ---
> > package/libsemanage/libsemanage.mk | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/libsemanage/libsemanage.mk b/package/libsemanage/
> libsemanage.mk
> > index 197c14e4229a..ea9f4c9f67de 100644
> > --- a/package/libsemanage/libsemanage.mk
> > +++ b/package/libsemanage/libsemanage.mk
> > @@ -13,10 +13,15 @@ LIBSEMANAGE_INSTALL_STAGING = YES
> >
> > LIBSEMANAGE_MAKE_OPTS = $(TARGET_CONFIGURE_OPTS)
> >
> > +# disable ustr inline functions to avoid multiple definition of symbols
> > +# error when linking
> > +LIBSEMANAGE_CFLAGS = $(TARGET_CFLAGS) -DUSTR_CONF_COMPILE_USE_INLINE=0
> > +
> > define LIBSEMANAGE_BUILD_CMDS
> > # DESTDIR is needed during the compile to compute library and
> > # header paths.
> > - $(MAKE) -C $(@D) $(LIBSEMANAGE_MAKE_OPTS) DESTDIR=$(STAGING_DIR)
> all
> > + $(MAKE) -C $(@D) $(LIBSEMANAGE_MAKE_OPTS)
> CFLAGS="$(LIBSEMANAGE_CFLAGS)" \
> > + DESTDIR=$(STAGING_DIR) all
> > endef
> >
> > define LIBSEMANAGE_INSTALL_STAGING_CMDS
> > --
> > 1.9.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___
> |
> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There
> is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v
> conspiracy. |
>
> '------------------------------^-------^------------------^--------------------'
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151208/fccc12fd/attachment.html>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-09 0:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-03 20:25 [Buildroot] [PATCH] libsemanage: fix build error when linking with ustr Sergio Prado
2015-12-03 21:07 ` Thomas Petazzoni
2015-12-08 20:59 ` Yann E. MORIN
2015-12-09 0:59 ` Sergio Prado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox