* [Buildroot] [PATCH 1/1] Add ARM11 MPCore CPU target support
@ 2015-11-28 9:59 Sergi Granell
2015-11-28 14:30 ` Yann E. MORIN
0 siblings, 1 reply; 8+ messages in thread
From: Sergi Granell @ 2015-11-28 9:59 UTC (permalink / raw)
To: buildroot
Signed-off-by: Sergi Granell <xerpi.g.12@gmail.com>
---
arch/Config.in.arm | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/Config.in.arm b/arch/Config.in.arm
index 67ff384..f9cfc22 100644
--- a/arch/Config.in.arm
+++ b/arch/Config.in.arm
@@ -104,6 +104,13 @@ config BR2_arm1176jzf_s
select BR2_ARM_CPU_HAS_THUMB
select BR2_ARM_CPU_ARMV6
select BR2_ARCH_HAS_MMU_OPTIONAL
+config BR2_arm11mpcore
+ bool "arm11mpcore"
+ select BR2_ARM_CPU_HAS_ARM
+ select BR2_ARM_CPU_HAS_VFPV2
+ select BR2_ARM_CPU_HAS_THUMB
+ select BR2_ARM_CPU_ARMV6
+ select BR2_ARCH_HAS_MMU_OPTIONAL
config BR2_cortex_a5
bool "cortex-A5"
select BR2_ARM_CPU_HAS_ARM
@@ -419,6 +426,7 @@ config BR2_GCC_TARGET_CPU
default "arm1136jf-s" if BR2_arm1136jf_s
default "arm1176jz-s" if BR2_arm1176jz_s
default "arm1176jzf-s" if BR2_arm1176jzf_s
+ default "mpcore" if BR2_arm11mpcore
default "cortex-a5" if BR2_cortex_a5
default "cortex-a7" if BR2_cortex_a7
default "cortex-a8" if BR2_cortex_a8
--
2.6.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] Add ARM11 MPCore CPU target support
2015-11-28 9:59 [Buildroot] [PATCH 1/1] Add ARM11 MPCore CPU target support Sergi Granell
@ 2015-11-28 14:30 ` Yann E. MORIN
2015-12-23 22:10 ` Thomas Petazzoni
0 siblings, 1 reply; 8+ messages in thread
From: Yann E. MORIN @ 2015-11-28 14:30 UTC (permalink / raw)
To: buildroot
Sergi, All,
On 2015-11-28 10:59 +0100, Sergi Granell spake thusly:
> Signed-off-by: Sergi Granell <xerpi.g.12@gmail.com>
> ---
> arch/Config.in.arm | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/Config.in.arm b/arch/Config.in.arm
> index 67ff384..f9cfc22 100644
> --- a/arch/Config.in.arm
> +++ b/arch/Config.in.arm
> @@ -104,6 +104,13 @@ config BR2_arm1176jzf_s
> select BR2_ARM_CPU_HAS_THUMB
> select BR2_ARM_CPU_ARMV6
> select BR2_ARCH_HAS_MMU_OPTIONAL
> +config BR2_arm11mpcore
> + bool "arm11mpcore"
> + select BR2_ARM_CPU_HAS_ARM
> + select BR2_ARM_CPU_HAS_VFPV2
I wonder if we should not make VFP optional, and change the CPU nme on
whether the user has enabled VFP, like:
config BR2_arm11mpcore
bool "mpcore"
[...]
select BR2_ARM_CPU_MAYBE_HAS_VFPV2
[...]
config BR2_GCC_TARGET_CPU
[...]
default "mpcore" if BR2_arm11mpcore && BR2_ARM_CPU_HAS_VFPV2
default "mpcorenovfp" if BR2_arm11mpcore
[...]
(note that the second default does not need !VFPV2, since Kconfig will
stop on the first matching default, so the second will only match if the
first does not, which means it would only match without a VFP).
(also note that I just named the prompt 'mpcore' instead of
'arm11mpcore', since that's how gcc knows it as).
Also, since the selection gets a bit more tricky, you need to explain
that in the commit log, with something along the lines of (feel free to
adapt to your own taste! ;-) ):
gcc differentiates the mpcore-with-vfp from the mcpore-without-vfp
CPUs. The former is named just 'mpcore', while the latter is named
'mpcorenovfp'.
We only add one entry, 'mpcore' and let the user select whether or
not to use the VFP. We then name the CPU according to the user's
selection.
Care to fix and resend, please?
Regards,
Yann E. MORIN.
> + select BR2_ARM_CPU_HAS_THUMB
> + select BR2_ARM_CPU_ARMV6
> + select BR2_ARCH_HAS_MMU_OPTIONAL
> config BR2_cortex_a5
> bool "cortex-A5"
> select BR2_ARM_CPU_HAS_ARM
> @@ -419,6 +426,7 @@ config BR2_GCC_TARGET_CPU
> default "arm1136jf-s" if BR2_arm1136jf_s
> default "arm1176jz-s" if BR2_arm1176jz_s
> default "arm1176jzf-s" if BR2_arm1176jzf_s
> + default "mpcore" if BR2_arm11mpcore
> default "cortex-a5" if BR2_cortex_a5
> default "cortex-a7" if BR2_cortex_a7
> default "cortex-a8" if BR2_cortex_a8
> --
> 2.6.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 8+ messages in thread* [Buildroot] [PATCH 1/1] Add ARM11 MPCore CPU target support
2015-11-28 14:30 ` Yann E. MORIN
@ 2015-12-23 22:10 ` Thomas Petazzoni
2015-12-27 17:04 ` Yann E. MORIN
0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2015-12-23 22:10 UTC (permalink / raw)
To: buildroot
Yann,
Sergi sent a v2 of his patch... but your suggestion doesn't work. See
below.
On Sat, 28 Nov 2015 15:30:30 +0100, Yann E. MORIN wrote:
> I wonder if we should not make VFP optional, and change the CPU nme on
> whether the user has enabled VFP, like:
>
> config BR2_arm11mpcore
> bool "mpcore"
> [...]
> select BR2_ARM_CPU_MAYBE_HAS_VFPV2
> [...]
>
> config BR2_GCC_TARGET_CPU
> [...]
> default "mpcore" if BR2_arm11mpcore && BR2_ARM_CPU_HAS_VFPV2
> default "mpcorenovfp" if BR2_arm11mpcore
> [...]
This doesn't work, because BR2_ARM_CPU_HAS_VFPV2 is not a user visible
option, and there is nothing that selects it in the current Buildroot.
Therefore the "mpcore" case can never be reached.
Consequently, I am tempted to take v1 of Sergi's patch. Yes, it means
we don't support the no-VFP variant of ARM11 MPCore, but I'm not sure
there are lots of ARM11 MPCore without a VFP, so maybe supporting
mpcorenovfp is not worth the effort for the moment.
Thoughts?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] Add ARM11 MPCore CPU target support
2015-12-23 22:10 ` Thomas Petazzoni
@ 2015-12-27 17:04 ` Yann E. MORIN
2015-12-27 17:50 ` Thomas Petazzoni
0 siblings, 1 reply; 8+ messages in thread
From: Yann E. MORIN @ 2015-12-27 17:04 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2015-12-23 23:10 +0100, Thomas Petazzoni spake thusly:
> Sergi sent a v2 of his patch... but your suggestion doesn't work. See
> below.
>
> On Sat, 28 Nov 2015 15:30:30 +0100, Yann E. MORIN wrote:
>
> > I wonder if we should not make VFP optional, and change the CPU nme on
> > whether the user has enabled VFP, like:
> >
> > config BR2_arm11mpcore
> > bool "mpcore"
> > [...]
> > select BR2_ARM_CPU_MAYBE_HAS_VFPV2
> > [...]
> >
> > config BR2_GCC_TARGET_CPU
> > [...]
> > default "mpcore" if BR2_arm11mpcore && BR2_ARM_CPU_HAS_VFPV2
> > default "mpcorenovfp" if BR2_arm11mpcore
> > [...]
>
> This doesn't work, because BR2_ARM_CPU_HAS_VFPV2 is not a user visible
> option, and there is nothing that selects it in the current Buildroot.
> Therefore the "mpcore" case can never be reached.
>
> Consequently, I am tempted to take v1 of Sergi's patch. Yes, it means
> we don't support the no-VFP variant of ARM11 MPCore, but I'm not sure
> there are lots of ARM11 MPCore without a VFP, so maybe supporting
> mpcorenovfp is not worth the effort for the moment.
>
> Thoughts?
I think that with the newly VFP stuff we committed today, we could
slightly rework that patch and make it work, no? ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] Add ARM11 MPCore CPU target support
@ 2015-11-28 14:55 Sergi Granell
2015-12-27 19:58 ` Yann E. MORIN
0 siblings, 1 reply; 8+ messages in thread
From: Sergi Granell @ 2015-11-28 14:55 UTC (permalink / raw)
To: buildroot
gcc differentiates the mpcore-with-vfp from the mcpore-without-vfp
CPUs. The former is named just 'mpcore', while the latter is named
'mpcorenovfp'.
We only add one entry, 'mpcore' and let the user select whether or
not to use the VFP. We then name the CPU according to the user's
selection.
Signed-off-by: Sergi Granell <xerpi.g.12@gmail.com>
---
arch/Config.in.arm | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/Config.in.arm b/arch/Config.in.arm
index 67ff384..1bf1fe2 100644
--- a/arch/Config.in.arm
+++ b/arch/Config.in.arm
@@ -104,6 +104,13 @@ config BR2_arm1176jzf_s
select BR2_ARM_CPU_HAS_THUMB
select BR2_ARM_CPU_ARMV6
select BR2_ARCH_HAS_MMU_OPTIONAL
+config BR2_arm11mpcore
+ bool "mpcore"
+ select BR2_ARM_CPU_HAS_ARM
+ select BR2_ARM_CPU_MAYBE_HAS_VFPV2
+ select BR2_ARM_CPU_HAS_THUMB
+ select BR2_ARM_CPU_ARMV6
+ select BR2_ARCH_HAS_MMU_OPTIONAL
config BR2_cortex_a5
bool "cortex-A5"
select BR2_ARM_CPU_HAS_ARM
@@ -419,6 +426,8 @@ config BR2_GCC_TARGET_CPU
default "arm1136jf-s" if BR2_arm1136jf_s
default "arm1176jz-s" if BR2_arm1176jz_s
default "arm1176jzf-s" if BR2_arm1176jzf_s
+ default "mpcore" if BR2_arm11mpcore && BR2_ARM_CPU_HAS_VFPV2
+ default "mpcorenovfp" if BR2_arm11mpcore
default "cortex-a5" if BR2_cortex_a5
default "cortex-a7" if BR2_cortex_a7
default "cortex-a8" if BR2_cortex_a8
--
2.6.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] Add ARM11 MPCore CPU target support
2015-11-28 14:55 Sergi Granell
@ 2015-12-27 19:58 ` Yann E. MORIN
2016-01-03 21:39 ` Peter Korsgaard
0 siblings, 1 reply; 8+ messages in thread
From: Yann E. MORIN @ 2015-12-27 19:58 UTC (permalink / raw)
To: buildroot
Sergi, All,
On 2015-11-28 15:55 +0100, Sergi Granell spake thusly:
> gcc differentiates the mpcore-with-vfp from the mcpore-without-vfp
> CPUs. The former is named just 'mpcore', while the latter is named
> 'mpcorenovfp'.
>
> We only add one entry, 'mpcore' and let the user select whether or
> not to use the VFP. We then name the CPU according to the user's
> selection.
>
> Signed-off-by: Sergi Granell <xerpi.g.12@gmail.com>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[yann.morin.1998 at free.fr: build-tested only]
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> arch/Config.in.arm | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/Config.in.arm b/arch/Config.in.arm
> index 67ff384..1bf1fe2 100644
> --- a/arch/Config.in.arm
> +++ b/arch/Config.in.arm
> @@ -104,6 +104,13 @@ config BR2_arm1176jzf_s
> select BR2_ARM_CPU_HAS_THUMB
> select BR2_ARM_CPU_ARMV6
> select BR2_ARCH_HAS_MMU_OPTIONAL
> +config BR2_arm11mpcore
> + bool "mpcore"
> + select BR2_ARM_CPU_HAS_ARM
> + select BR2_ARM_CPU_MAYBE_HAS_VFPV2
> + select BR2_ARM_CPU_HAS_THUMB
> + select BR2_ARM_CPU_ARMV6
> + select BR2_ARCH_HAS_MMU_OPTIONAL
> config BR2_cortex_a5
> bool "cortex-A5"
> select BR2_ARM_CPU_HAS_ARM
> @@ -419,6 +426,8 @@ config BR2_GCC_TARGET_CPU
> default "arm1136jf-s" if BR2_arm1136jf_s
> default "arm1176jz-s" if BR2_arm1176jz_s
> default "arm1176jzf-s" if BR2_arm1176jzf_s
> + default "mpcore" if BR2_arm11mpcore && BR2_ARM_CPU_HAS_VFPV2
> + default "mpcorenovfp" if BR2_arm11mpcore
> default "cortex-a5" if BR2_cortex_a5
> default "cortex-a7" if BR2_cortex_a7
> default "cortex-a8" if BR2_cortex_a8
> --
> 2.6.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] Add ARM11 MPCore CPU target support
2015-12-27 19:58 ` Yann E. MORIN
@ 2016-01-03 21:39 ` Peter Korsgaard
0 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2016-01-03 21:39 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Sergi, All,
> On 2015-11-28 15:55 +0100, Sergi Granell spake thusly:
>> gcc differentiates the mpcore-with-vfp from the mcpore-without-vfp
>> CPUs. The former is named just 'mpcore', while the latter is named
>> 'mpcorenovfp'.
>>
>> We only add one entry, 'mpcore' and let the user select whether or
>> not to use the VFP. We then name the CPU according to the user's
>> selection.
>>
>> Signed-off-by: Sergi Granell <xerpi.g.12@gmail.com>
> Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> [yann.morin.1998 at free.fr: build-tested only]
> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-01-03 21:39 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-28 9:59 [Buildroot] [PATCH 1/1] Add ARM11 MPCore CPU target support Sergi Granell
2015-11-28 14:30 ` Yann E. MORIN
2015-12-23 22:10 ` Thomas Petazzoni
2015-12-27 17:04 ` Yann E. MORIN
2015-12-27 17:50 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2015-11-28 14:55 Sergi Granell
2015-12-27 19:58 ` Yann E. MORIN
2016-01-03 21:39 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox