* [Buildroot] [PATCH 1/1] gstreamer1: use a relative symlink to gstconfig.h
@ 2016-01-28 13:19 Phil Eichinger
2016-01-28 16:55 ` Peter Korsgaard
2016-01-31 19:50 ` Peter Korsgaard
0 siblings, 2 replies; 6+ messages in thread
From: Phil Eichinger @ 2016-01-28 13:19 UTC (permalink / raw)
To: buildroot
Signed-off-by: Phil Eichinger <phil@zankapfel.net>
---
package/gstreamer1/gstreamer1/gstreamer1.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/gstreamer1/gstreamer1/gstreamer1.mk b/package/gstreamer1/gstreamer1/gstreamer1.mk
index 4548773..0eb46e8 100644
--- a/package/gstreamer1/gstreamer1/gstreamer1.mk
+++ b/package/gstreamer1/gstreamer1/gstreamer1.mk
@@ -41,7 +41,7 @@ GSTREAMER1_DEPENDENCIES = libglib2 host-pkgconf host-bison host-flex
# updated to look in the correct location.
# Add a symlink to the legacy location
define GSTREAMER1_LEGACY_CGSTCONFIG_H
- ln -sf $(STAGING_DIR)/usr/lib/gstreamer-1.0/include/gst/gstconfig.h \
+ ln -srf $(STAGING_DIR)/usr/lib/gstreamer-1.0/include/gst/gstconfig.h \
$(STAGING_DIR)/usr/include/gstreamer-1.0/gst/gstconfig.h
endef
GSTREAMER1_POST_INSTALL_STAGING_HOOKS += GSTREAMER1_LEGACY_CGSTCONFIG_H
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] gstreamer1: use a relative symlink to gstconfig.h
2016-01-28 13:19 [Buildroot] [PATCH 1/1] gstreamer1: use a relative symlink to gstconfig.h Phil Eichinger
@ 2016-01-28 16:55 ` Peter Korsgaard
2016-01-29 13:10 ` Phil Eichinger
2016-01-31 19:50 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2016-01-28 16:55 UTC (permalink / raw)
To: buildroot
>>>>> "Phil" == Phil Eichinger <phil.eichinger@gmail.com> writes:
> Signed-off-by: Phil Eichinger <phil@zankapfel.net>
Why? Does that fix anything or is it just "prettier"? I get it that we
would need it for a relocatable host dir, but we're not there yet.
A bit more detailed commit message would be good.
> ---
> package/gstreamer1/gstreamer1/gstreamer1.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/gstreamer1/gstreamer1/gstreamer1.mk b/package/gstreamer1/gstreamer1/gstreamer1.mk
> index 4548773..0eb46e8 100644
> --- a/package/gstreamer1/gstreamer1/gstreamer1.mk
> +++ b/package/gstreamer1/gstreamer1/gstreamer1.mk
> @@ -41,7 +41,7 @@ GSTREAMER1_DEPENDENCIES = libglib2 host-pkgconf host-bison host-flex
> # updated to look in the correct location.
> # Add a symlink to the legacy location
> define GSTREAMER1_LEGACY_CGSTCONFIG_H
> - ln -sf $(STAGING_DIR)/usr/lib/gstreamer-1.0/include/gst/gstconfig.h \
> + ln -srf $(STAGING_DIR)/usr/lib/gstreamer-1.0/include/gst/gstconfig.h \
> $(STAGING_DIR)/usr/include/gstreamer-1.0/gst/gstconfig.h
> endef
> GSTREAMER1_POST_INSTALL_STAGING_HOOKS += GSTREAMER1_LEGACY_CGSTCONFIG_H
> --
> 2.1.4
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] gstreamer1: use a relative symlink to gstconfig.h
2016-01-28 16:55 ` Peter Korsgaard
@ 2016-01-29 13:10 ` Phil Eichinger
2016-01-29 13:33 ` Samuel Martin
0 siblings, 1 reply; 6+ messages in thread
From: Phil Eichinger @ 2016-01-29 13:10 UTC (permalink / raw)
To: buildroot
On 28 January 2016 at 17:55, Peter Korsgaard <peter@korsgaard.com> wrote:
> >>>>> "Phil" == Phil Eichinger <phil.eichinger@gmail.com> writes:
>
> > Signed-off-by: Phil Eichinger <phil@zankapfel.net>
>
> Why? Does that fix anything or is it just "prettier"? I get it that we
> would need it for a relocatable host dir, but we're not there yet.
>
> A bit more detailed commit message would be good.
>
Yes, it is for relocation, sorry for not being more elaborate on that, will
do better in the future.
I actually relocate the host dir with some tricks, that aren't upstreamable
yet because they are not generally usable for buildroot.
This patch just eases the relocation and I didn't see any harm in using a
relative symlink instead of an absolute one.
So it actually fixes something, it's not just "prettier"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160129/d1e910ae/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] gstreamer1: use a relative symlink to gstconfig.h
2016-01-29 13:10 ` Phil Eichinger
@ 2016-01-29 13:33 ` Samuel Martin
2016-01-29 14:16 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Samuel Martin @ 2016-01-29 13:33 UTC (permalink / raw)
To: buildroot
Hi Phil,
On Fri, Jan 29, 2016 at 2:10 PM, Phil Eichinger
<phil.eichinger@gmail.com> wrote:
> On 28 January 2016 at 17:55, Peter Korsgaard <peter@korsgaard.com> wrote:
>>
>> >>>>> "Phil" == Phil Eichinger <phil.eichinger@gmail.com> writes:
>>
>> > Signed-off-by: Phil Eichinger <phil@zankapfel.net>
>>
>> Why? Does that fix anything or is it just "prettier"? I get it that we
>> would need it for a relocatable host dir, but we're not there yet.
>>
>> A bit more detailed commit message would be good.
>
>
> Yes, it is for relocation, sorry for not being more elaborate on that, will
> do better in the future.
>
> I actually relocate the host dir with some tricks, that aren't upstreamable
> yet because they are not generally usable for buildroot.
> This patch just eases the relocation and I didn't see any harm in using a
> relative symlink instead of an absolute one.
> So it actually fixes something, it's not just "prettier"
Could you share the tricks you are doing so far?
I'm working on making the SDK (host dir. and staging dir.) relocatable.
You can check the current state of my branch [1].
I hope to submit a first step before the 2016.02 RC month, but this is
not yet ready :-/
Anyway, I'm really interested in gathering all that have to be done
for the relocatable SDK. ;-)
[1] https://github.com/tSed/buildroot/tree/sma/host-pkg-rpath/wip
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] gstreamer1: use a relative symlink to gstconfig.h
2016-01-29 13:33 ` Samuel Martin
@ 2016-01-29 14:16 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-01-29 14:16 UTC (permalink / raw)
To: buildroot
Hello Samuel,
On Fri, 29 Jan 2016 14:33:23 +0100, Samuel Martin wrote:
> I'm working on making the SDK (host dir. and staging dir.) relocatable.
> You can check the current state of my branch [1].
> I hope to submit a first step before the 2016.02 RC month, but this is
> not yet ready :-/
>
> Anyway, I'm really interested in gathering all that have to be done
> for the relocatable SDK. ;-)
Glad to hear you are working on making the SDK relocatable !
However, if I may have a suggestion, I believe you shouldn't submit all
the changes needed in one big patch series.
Instead, what I would suggest is that you:
1/ Write up a web-page or Wiki-page with a list of things that need to
be fixed.
2/ Send one patch series for each thing that needs to be fixed. And
maybe not send all patch series at the same time: handle one or two
topics at a time.
3/ Keep your Wiki page updated with the things that have been merged,
and things that remain to be merged, that remain to be submitted,
etc.
Moving to a relocatable SDK is a big change that requires lots of
smaller changes. We have to handle it progressively, otherwise it will
never be merged due to the amount of required changes.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] gstreamer1: use a relative symlink to gstconfig.h
2016-01-28 13:19 [Buildroot] [PATCH 1/1] gstreamer1: use a relative symlink to gstconfig.h Phil Eichinger
2016-01-28 16:55 ` Peter Korsgaard
@ 2016-01-31 19:50 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2016-01-31 19:50 UTC (permalink / raw)
To: buildroot
>>>>> "Phil" == Phil Eichinger <phil.eichinger@gmail.com> writes:
> Signed-off-by: Phil Eichinger <phil@zankapfel.net>
Committed with a bit more detailed description about why, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-31 19:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-28 13:19 [Buildroot] [PATCH 1/1] gstreamer1: use a relative symlink to gstconfig.h Phil Eichinger
2016-01-28 16:55 ` Peter Korsgaard
2016-01-29 13:10 ` Phil Eichinger
2016-01-29 13:33 ` Samuel Martin
2016-01-29 14:16 ` Thomas Petazzoni
2016-01-31 19:50 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox