* [Buildroot] [PATCH] package: aespipe: add host variant
@ 2016-02-01 15:37 Ariel D'Alessandro
2016-02-01 18:41 ` Arnout Vandecappelle
2016-02-01 19:02 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Ariel D'Alessandro @ 2016-02-01 15:37 UTC (permalink / raw)
To: buildroot
Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
---
package/Config.in.host | 1 +
package/aespipe/Config.in.host | 10 ++++++++++
package/aespipe/aespipe.mk | 1 +
3 files changed, 12 insertions(+)
create mode 100644 package/aespipe/Config.in.host
diff --git a/package/Config.in.host b/package/Config.in.host
index 8e6b870..1c691a3 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -1,5 +1,6 @@
menu "Host utilities"
+ source "package/aespipe/Config.in.host"
source "package/checkpolicy/Config.in.host"
source "package/cramfs/Config.in.host"
source "package/dfu-util/Config.in.host"
diff --git a/package/aespipe/Config.in.host b/package/aespipe/Config.in.host
new file mode 100644
index 0000000..29f6232
--- /dev/null
+++ b/package/aespipe/Config.in.host
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_HOST_AESPIPE
+ bool "host aespipe"
+ depends on BR2_USE_MMU # fork()
+ help
+ aespipe program is AES encrypting or decrypting pipe. It reads from
+ standard input and writes to standard output. It can be used to
+ create and restore encrypted tar or cpio archives. It can be used to
+ encrypt and decrypt loop-AES compatible encrypted disk images.
+
+ http://koti.tnnet.fi/jari.ruusu/linux/
diff --git a/package/aespipe/aespipe.mk b/package/aespipe/aespipe.mk
index a220688..c567092 100644
--- a/package/aespipe/aespipe.mk
+++ b/package/aespipe/aespipe.mk
@@ -10,3 +10,4 @@ AESPIPE_SITE = http://loop-aes.sourceforge.net/aespipe
AESPIPE_LICENSE = GPL
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package: aespipe: add host variant
2016-02-01 15:37 [Buildroot] [PATCH] package: aespipe: add host variant Ariel D'Alessandro
@ 2016-02-01 18:41 ` Arnout Vandecappelle
2016-02-02 21:36 ` Ariel D'Alessandro
2016-02-01 19:02 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2016-02-01 18:41 UTC (permalink / raw)
To: buildroot
On 01-02-16 16:37, Ariel D'Alessandro wrote:
> Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
Your commit message should explain why this is needed. Something like:
Post-image scripts may want to encrypt the resulting image with aespipe
(and decrypt it in the update tool on the target), so it is useful to have
the host version and to be able to select it in the configuration.
> ---
> package/Config.in.host | 1 +
> package/aespipe/Config.in.host | 10 ++++++++++
> package/aespipe/aespipe.mk | 1 +
> 3 files changed, 12 insertions(+)
> create mode 100644 package/aespipe/Config.in.host
>
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 8e6b870..1c691a3 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -1,5 +1,6 @@
> menu "Host utilities"
>
> + source "package/aespipe/Config.in.host"
> source "package/checkpolicy/Config.in.host"
> source "package/cramfs/Config.in.host"
> source "package/dfu-util/Config.in.host"
> diff --git a/package/aespipe/Config.in.host b/package/aespipe/Config.in.host
> new file mode 100644
> index 0000000..29f6232
> --- /dev/null
> +++ b/package/aespipe/Config.in.host
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_HOST_AESPIPE
> + bool "host aespipe"
> + depends on BR2_USE_MMU # fork()
This shouldn't be there. If the target doesn't have a MMU, you can still build
it for the host.
Otherwise looks good to me.
Regards,
Arnout
> + help
> + aespipe program is AES encrypting or decrypting pipe. It reads from
> + standard input and writes to standard output. It can be used to
> + create and restore encrypted tar or cpio archives. It can be used to
> + encrypt and decrypt loop-AES compatible encrypted disk images.
> +
> + http://koti.tnnet.fi/jari.ruusu/linux/
> diff --git a/package/aespipe/aespipe.mk b/package/aespipe/aespipe.mk
> index a220688..c567092 100644
> --- a/package/aespipe/aespipe.mk
> +++ b/package/aespipe/aespipe.mk
> @@ -10,3 +10,4 @@ AESPIPE_SITE = http://loop-aes.sourceforge.net/aespipe
> AESPIPE_LICENSE = GPL
>
> $(eval $(autotools-package))
> +$(eval $(host-autotools-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package: aespipe: add host variant
2016-02-01 18:41 ` Arnout Vandecappelle
@ 2016-02-02 21:36 ` Ariel D'Alessandro
0 siblings, 0 replies; 6+ messages in thread
From: Ariel D'Alessandro @ 2016-02-02 21:36 UTC (permalink / raw)
To: buildroot
Arnout,
El 01/02/16 a las 15:41, Arnout Vandecappelle escribi?:
> On 01-02-16 16:37, Ariel D'Alessandro wrote:
>> Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
>
> Your commit message should explain why this is needed. Something like:
>
> Post-image scripts may want to encrypt the resulting image with aespipe
> (and decrypt it in the update tool on the target), so it is useful to have
> the host version and to be able to select it in the configuration.
Yeah, I think that explanation is pretty good. I'll add it.
>
>> ---
>> package/Config.in.host | 1 +
>> package/aespipe/Config.in.host | 10 ++++++++++
>> package/aespipe/aespipe.mk | 1 +
>> 3 files changed, 12 insertions(+)
>> create mode 100644 package/aespipe/Config.in.host
>>
>> diff --git a/package/Config.in.host b/package/Config.in.host
>> index 8e6b870..1c691a3 100644
>> --- a/package/Config.in.host
>> +++ b/package/Config.in.host
>> @@ -1,5 +1,6 @@
>> menu "Host utilities"
>>
>> + source "package/aespipe/Config.in.host"
>> source "package/checkpolicy/Config.in.host"
>> source "package/cramfs/Config.in.host"
>> source "package/dfu-util/Config.in.host"
>> diff --git a/package/aespipe/Config.in.host b/package/aespipe/Config.in.host
>> new file mode 100644
>> index 0000000..29f6232
>> --- /dev/null
>> +++ b/package/aespipe/Config.in.host
>> @@ -0,0 +1,10 @@
>> +config BR2_PACKAGE_HOST_AESPIPE
>> + bool "host aespipe"
>> + depends on BR2_USE_MMU # fork()
>
> This shouldn't be there. If the target doesn't have a MMU, you can still build
> it for the host.
>
> Otherwise looks good to me.
Oops, you're right, don't know why I missed that :(
Thanks!
--
Ariel D'Alessandro, VanguardiaSur
www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package: aespipe: add host variant
2016-02-01 15:37 [Buildroot] [PATCH] package: aespipe: add host variant Ariel D'Alessandro
2016-02-01 18:41 ` Arnout Vandecappelle
@ 2016-02-01 19:02 ` Thomas Petazzoni
2016-02-02 21:43 ` Ariel D'Alessandro
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-02-01 19:02 UTC (permalink / raw)
To: buildroot
Dear Ariel D'Alessandro,
On Mon, 1 Feb 2016 12:37:27 -0300, Ariel D'Alessandro wrote:
> Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
> ---
> package/Config.in.host | 1 +
> package/aespipe/Config.in.host | 10 ++++++++++
> package/aespipe/aespipe.mk | 1 +
> 3 files changed, 12 insertions(+)
> create mode 100644 package/aespipe/Config.in.host
Can you give a justification as to why we would want to add aespipe as
a host package ? We generally try to limit the number of host packages
we add to package/Config.in.host, so it's good to include a
justification as to why it is a good idea to include aespipe as a
menuconfig-selectable host package.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package: aespipe: add host variant
2016-02-01 19:02 ` Thomas Petazzoni
@ 2016-02-02 21:43 ` Ariel D'Alessandro
2016-02-03 8:31 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Ariel D'Alessandro @ 2016-02-02 21:43 UTC (permalink / raw)
To: buildroot
Thomas,
El 01/02/16 a las 16:02, Thomas Petazzoni escribi?:
> Dear Ariel D'Alessandro,
>
> On Mon, 1 Feb 2016 12:37:27 -0300, Ariel D'Alessandro wrote:
>> Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
>> ---
>> package/Config.in.host | 1 +
>> package/aespipe/Config.in.host | 10 ++++++++++
>> package/aespipe/aespipe.mk | 1 +
>> 3 files changed, 12 insertions(+)
>> create mode 100644 package/aespipe/Config.in.host
>
> Can you give a justification as to why we would want to add aespipe as
> a host package ? We generally try to limit the number of host packages
> we add to package/Config.in.host, so it's good to include a
> justification as to why it is a good idea to include aespipe as a
> menuconfig-selectable host package.
The justification is pretty much what Arnout said:
""
Post-image scripts may want to encrypt the resulting image with aespipe
(and decrypt it in the update tool on the target), so it is useful to
have the host version and to be able to select it in the configuration.
""
In fact, that's exactly why I added host-aespipe to one of my projects.
Is this enough to include it as a host package?
Thanks!
--
Ariel D'Alessandro, VanguardiaSur
www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package: aespipe: add host variant
2016-02-02 21:43 ` Ariel D'Alessandro
@ 2016-02-03 8:31 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-02-03 8:31 UTC (permalink / raw)
To: buildroot
Dear Ariel D'Alessandro,
On Tue, 2 Feb 2016 18:43:17 -0300, Ariel D'Alessandro wrote:
> The justification is pretty much what Arnout said:
>
> ""
> Post-image scripts may want to encrypt the resulting image with aespipe
> (and decrypt it in the update tool on the target), so it is useful to
> have the host version and to be able to select it in the configuration.
> ""
>
> In fact, that's exactly why I added host-aespipe to one of my projects.
> Is this enough to include it as a host package?
Yes, this justification is good. It should have been part of the commit
log originally though :-)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-03 8:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-01 15:37 [Buildroot] [PATCH] package: aespipe: add host variant Ariel D'Alessandro
2016-02-01 18:41 ` Arnout Vandecappelle
2016-02-02 21:36 ` Ariel D'Alessandro
2016-02-01 19:02 ` Thomas Petazzoni
2016-02-02 21:43 ` Ariel D'Alessandro
2016-02-03 8:31 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox