[Buildroot] [PATCH] yad: fix libgtk3 dependency

[Buildroot] [PATCH] yad: fix libgtk3 dependency

[Gustavo Zacarias]

Make it depend explicitly on BR2_PACKAGE_LIBGTK3_X11 (the X11 backend
option) to avoid the checker from complaining.
Also add a comment about yad requiring the X11 backend otherwise it's
ambiguous if a user has libgtk3 enabled with broadway/wayland and the
comment shows up. Fixes:
http://autobuild.buildroot.net/results/84d/84d97bbcc0ea4f8eaa50dd25bf9ee8fdee4b937f/

Also cleanup some tiny whitespace in the package mk file.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/yad/Config.in | 6 +++---
 package/yad/yad.mk    | 1 -
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/package/yad/Config.in b/package/yad/Config.in
index e4b63a2..50b97c5 100644
--- a/package/yad/Config.in
+++ b/package/yad/Config.in
@@ -1,13 +1,13 @@
 config BR2_PACKAGE_YAD
 	bool "yad"
 	depends on BR2_PACKAGE_XORG7
-	depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3
+	depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3_X11
 	help
 	  YAD (yet another dialog) is a tool for create graphical dialogs
 	  from shell scripts.
 
 	  http://sourceforge.net/projects/yad-dialog/
 
-comment "yad needs libgtk2 or libgtk3"
+comment "yad needs libgtk2 or libgtk3 w/ X11 backend"
 	depends on BR2_PACKAGE_XORG7
-	depends on !BR2_PACKAGE_LIBGTK2 && !BR2_PACKAGE_LIBGTK3
+	depends on !BR2_PACKAGE_LIBGTK2 && !BR2_PACKAGE_LIBGTK3_X11
diff --git a/package/yad/yad.mk b/package/yad/yad.mk
index fc25267..24d331c 100644
--- a/package/yad/yad.mk
+++ b/package/yad/yad.mk
@@ -10,7 +10,6 @@ YAD_SITE = http://sourceforge.net/projects/yad-dialog/files
 YAD_LICENSE = GPLv3
 YAD_LICENSE_FILES = COPYING
 YAD_DEPENDENCIES = host-intltool host-pkgconf
-
 YAD_CONF_OPTS = --enable-html=no
 
 ifeq ($(BR2_PACKAGE_LIBGTK3_X11),y)
-- 
2.4.10

[Buildroot] [PATCH] yad: fix libgtk3 dependency

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Wed,  3 Feb 2016 10:01:55 -0300, Gustavo Zacarias wrote:
> Make it depend explicitly on BR2_PACKAGE_LIBGTK3_X11 (the X11 backend
> option) to avoid the checker from complaining.
> Also add a comment about yad requiring the X11 backend otherwise it's
> ambiguous if a user has libgtk3 enabled with broadway/wayland and the
> comment shows up. Fixes:
> http://autobuild.buildroot.net/results/84d/84d97bbcc0ea4f8eaa50dd25bf9ee8fdee4b937f/
> 
> Also cleanup some tiny whitespace in the package mk file.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Applied, but see one question below.

> ---
>  package/yad/Config.in | 6 +++---
>  package/yad/yad.mk    | 1 -
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/package/yad/Config.in b/package/yad/Config.in
> index e4b63a2..50b97c5 100644
> --- a/package/yad/Config.in
> +++ b/package/yad/Config.in
> @@ -1,13 +1,13 @@
>  config BR2_PACKAGE_YAD
>  	bool "yad"
>  	depends on BR2_PACKAGE_XORG7
> -	depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3
> +	depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3_X11

Is the BR2_PACKAGE_XORG7 dependency still needed, then?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] yad: fix libgtk3 dependency

[Gustavo Zacarias]

On 07/02/16 19:32, Thomas Petazzoni wrote:

>>   config BR2_PACKAGE_YAD
>>   	bool "yad"
>>   	depends on BR2_PACKAGE_XORG7
>> -	depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3
>> +	depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3_X11
>
> Is the BR2_PACKAGE_XORG7 dependency still needed, then?

Hi.
I believe it isn't, the only weak spot right now is that libgtk3 isn't 
deterministic - you can select multiple backends like x11 & wayland, 
however i'm unsure if that's allowed, IIRC there's no way to select 
which one you want.
Though that's a separate issue that i've already addressed in v3 of the 
libgtk3 bump by making it a choice.
Regards.

[Buildroot] [PATCH] yad: fix libgtk3 dependency

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Sun, 7 Feb 2016 21:22:12 -0300, Gustavo Zacarias wrote:
> On 07/02/16 19:32, Thomas Petazzoni wrote:
> 
> >>   config BR2_PACKAGE_YAD
> >>   	bool "yad"
> >>   	depends on BR2_PACKAGE_XORG7
> >> -	depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3
> >> +	depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3_X11
> >
> > Is the BR2_PACKAGE_XORG7 dependency still needed, then?
> 
> Hi.
> I believe it isn't, the only weak spot right now is that libgtk3 isn't 
> deterministic - you can select multiple backends like x11 & wayland, 
> however i'm unsure if that's allowed, IIRC there's no way to select 
> which one you want.

I'm not sure to understand: following your patch, we depend on
BR2_PACKAGE_LIBGTK3_X11, so yad can only be enabled if the Gtk3 X11
backend was selected.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com