From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/numactl: Fix uClibc compile breakage after musl compile fix
Date: Sun, 14 Feb 2016 13:51:41 +0100 [thread overview]
Message-ID: <20160214135141.3b0cbd49@free-electrons.com> (raw)
In-Reply-To: <1455393768-26580-1-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Sat, 13 Feb 2016 21:02:48 +0100, Bernd Kuhls wrote:
> --#if defined(__GLIBC__) && __GLIBC_PREREQ(2, 11)
> -+#if defined(__GLIBC__)
> -+# if __GLIBC_PREREQ(2,11)
> ++#ifndef __GLIBC_PREREQ
> ++# define __GLIBC_PREREQ(x,y) 0
> ++#endif
> ++
> + #if defined(__GLIBC__) && __GLIBC_PREREQ(2, 11)
I still don't understand why
#if defined(__GLIBC__)
#if __GLIBC_PREREQ(2, 11)
...
#endif
#endif
isn't the proposed solution. It looks so much cleaner and simpler than
defining __GLIBC_PREREQ to 0 when __GLIBC__ is not defined. And it is
actually the most correct solution I believe: only use __GLIBC_PREREQ
when __GLIBC__ is defined.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-14 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 20:02 [Buildroot] [PATCH v3 1/1] package/numactl: Fix uClibc compile breakage after musl compile fix Bernd Kuhls
2016-02-14 12:51 ` Thomas Petazzoni [this message]
2016-02-14 14:11 ` Bernd Kuhls
2016-02-15 22:30 ` Thomas Petazzoni
2016-02-24 10:57 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160214135141.3b0cbd49@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox