From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/numactl: Fix uClibc compile breakage after musl compile fix
Date: Mon, 15 Feb 2016 23:30:43 +0100 [thread overview]
Message-ID: <20160215233043.39f36d97@free-electrons.com> (raw)
In-Reply-To: <6ie6pcx556.ln2@ID-313208.user.individual.net>
Bernd,
On Sun, 14 Feb 2016 15:11:50 +0100, Bernd Kuhls wrote:
> the code you mentioned above was the first PR I sent on github[1] and
> received this answer:
> https://github.com/numactl/numactl/pull/4#issuecomment-183441544
>
> "I don't think the patch is correct. If GLIBC_PREREQ fails the #elif
> defined(__x86_64) path still needs to be taken. So you need to combine
> the two #ifs into one line"
>
> And combining the two #ifs into one line breaks compilation on musl so I
> wrote the current patch.
Can you try the below patch instead?
Index: b/syscall.c
===================================================================
--- a/syscall.c
+++ b/syscall.c
@@ -115,7 +115,13 @@
#endif
-#if defined(__GLIBC__) && __GLIBC_PREREQ(2, 11)
+#if defined(__GLIBC__)
+# if __GLIBC_PREREQ(2, 11)
+# define GLIBC_HAS_WORKING_SYSCALL6
+# endif
+#endif
+
+#if defined(GLIBC_HAS_WORKING_SYSCALL6)
/* glibc 2.11 seems to have working 6 argument sycall. Use the
glibc supplied syscall in this case.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-15 22:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 20:02 [Buildroot] [PATCH v3 1/1] package/numactl: Fix uClibc compile breakage after musl compile fix Bernd Kuhls
2016-02-14 12:51 ` Thomas Petazzoni
2016-02-14 14:11 ` Bernd Kuhls
2016-02-15 22:30 ` Thomas Petazzoni [this message]
2016-02-24 10:57 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215233043.39f36d97@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox