From: Bernd Kuhls <bernd.kuhls@t-online.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/numactl: Fix uClibc compile breakage after musl compile fix
Date: Sun, 14 Feb 2016 15:11:50 +0100 [thread overview]
Message-ID: <6ie6pcx556.ln2@ID-313208.user.individual.net> (raw)
In-Reply-To: 20160214135141.3b0cbd49@free-electrons.com
Am Sun, 14 Feb 2016 13:51:41 +0100 schrieb Thomas Petazzoni:
> I still don't understand why
>
> #if defined(__GLIBC__)
> #if __GLIBC_PREREQ(2, 11)
> ...
> #endif #endif
>
> isn't the proposed solution. It looks so much cleaner and simpler than
> defining __GLIBC_PREREQ to 0 when __GLIBC__ is not defined. And it is
> actually the most correct solution I believe: only use __GLIBC_PREREQ
> when __GLIBC__ is defined.
Hi,
the code you mentioned above was the first PR I sent on github[1] and
received this answer:
https://github.com/numactl/numactl/pull/4#issuecomment-183441544
"I don't think the patch is correct. If GLIBC_PREREQ fails the #elif
defined(__x86_64) path still needs to be taken. So you need to combine
the two #ifs into one line"
And combining the two #ifs into one line breaks compilation on musl so I
wrote the current patch.
Regards, Bernd
[1] http://patchwork.ozlabs.org/patch/575931/
next prev parent reply other threads:[~2016-02-14 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 20:02 [Buildroot] [PATCH v3 1/1] package/numactl: Fix uClibc compile breakage after musl compile fix Bernd Kuhls
2016-02-14 12:51 ` Thomas Petazzoni
2016-02-14 14:11 ` Bernd Kuhls [this message]
2016-02-15 22:30 ` Thomas Petazzoni
2016-02-24 10:57 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ie6pcx556.ln2@ID-313208.user.individual.net \
--to=bernd.kuhls@t-online.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox