* [Buildroot] [PATCH] elfutils: do not override ELFUTILS_CFLAGS variable
@ 2016-06-18 16:43 Vicente Olivert Riera
2016-06-18 20:58 ` Thomas Petazzoni
2016-06-19 8:57 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Vicente Olivert Riera @ 2016-06-18 16:43 UTC (permalink / raw)
To: buildroot
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/elfutils/elfutils.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/elfutils/elfutils.mk b/package/elfutils/elfutils.mk
index a2012d6..88837fb 100644
--- a/package/elfutils/elfutils.mk
+++ b/package/elfutils/elfutils.mk
@@ -18,11 +18,11 @@ ELFUTILS_CONF_OPTS += --disable-werror
# sparc64 needs -fPIC instead of -fpic
ifeq ($(BR2_sparc64),y)
-ELFUTILS_CFLAGS += -fPIC
+ELFUTILS_CFLAGS = -fPIC
endif
# elfutils gets confused when lfs mode is forced, so don't
-ELFUTILS_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
+ELFUTILS_CFLAGS += $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
ELFUTILS_CPPFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CPPFLAGS))
ELFUTILS_CONF_ENV += \
--
2.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] elfutils: do not override ELFUTILS_CFLAGS variable
2016-06-18 16:43 [Buildroot] [PATCH] elfutils: do not override ELFUTILS_CFLAGS variable Vicente Olivert Riera
@ 2016-06-18 20:58 ` Thomas Petazzoni
2016-06-19 8:57 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-06-18 20:58 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 18 Jun 2016 17:43:26 +0100, Vicente Olivert Riera wrote:
> # sparc64 needs -fPIC instead of -fpic
> ifeq ($(BR2_sparc64),y)
> -ELFUTILS_CFLAGS += -fPIC
> +ELFUTILS_CFLAGS = -fPIC
This change is wrong, += should be kept here.
> # elfutils gets confused when lfs mode is forced, so don't
> -ELFUTILS_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
> +ELFUTILS_CFLAGS += $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
Either you change to += like you propose, or you move the assignment
earlier. Changing to += is fine for me, but you should not change the
conditional assignment to = in the sparc64 condition.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] elfutils: do not override ELFUTILS_CFLAGS variable
2016-06-18 16:43 [Buildroot] [PATCH] elfutils: do not override ELFUTILS_CFLAGS variable Vicente Olivert Riera
2016-06-18 20:58 ` Thomas Petazzoni
@ 2016-06-19 8:57 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-06-19 8:57 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 18 Jun 2016 17:43:26 +0100, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/elfutils/elfutils.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master after re-ordering the assignments.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-19 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-18 16:43 [Buildroot] [PATCH] elfutils: do not override ELFUTILS_CFLAGS variable Vicente Olivert Riera
2016-06-18 20:58 ` Thomas Petazzoni
2016-06-19 8:57 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox