* [Buildroot] [PATCH 2/4] Package netsnmp: Removed 'set -e'
2016-02-25 21:24 [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload() Andreas Ehmanns
@ 2016-02-25 21:24 ` Andreas Ehmanns
2016-07-01 10:10 ` Yann E. MORIN
2016-02-25 21:24 ` [Buildroot] [PATCH 3/4] Package netsnmp: Added missing reload of snmptrapd Andreas Ehmanns
` (3 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: Andreas Ehmanns @ 2016-02-25 21:24 UTC (permalink / raw)
To: buildroot
set -e has been removed from init script since
it causes the init script to terminate if an
error occurs. This prevents the script to create
an "FAIL" printout in case of an error.
Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
---
package/netsnmp/S59snmpd | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/package/netsnmp/S59snmpd b/package/netsnmp/S59snmpd
index cfda625..2762082 100755
--- a/package/netsnmp/S59snmpd
+++ b/package/netsnmp/S59snmpd
@@ -1,4 +1,4 @@
-#! /bin/sh -e
+#! /bin/sh
### BEGIN INIT INFO
# Provides: snmpd snmptrapd
# Required-Start: $network $local_fs
@@ -11,7 +11,6 @@
#
# Author: Jochen Friedrich <jochen@scram.de>
#
-set -e
export PATH=/sbin:/usr/sbin:/bin:/usr/bin
--
2.1.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [Buildroot] [PATCH 2/4] Package netsnmp: Removed 'set -e'
2016-02-25 21:24 ` [Buildroot] [PATCH 2/4] Package netsnmp: Removed 'set -e' Andreas Ehmanns
@ 2016-07-01 10:10 ` Yann E. MORIN
0 siblings, 0 replies; 13+ messages in thread
From: Yann E. MORIN @ 2016-07-01 10:10 UTC (permalink / raw)
To: buildroot
Andreas, All,
On 2016-02-25 22:24 +0100, Andreas Ehmanns spake thusly:
> set -e has been removed from init script since
> it causes the init script to terminate if an
> error occurs. This prevents the script to create
> an "FAIL" printout in case of an error.
And we're not doing it consistently either. I've looked at the startup
script for busybox (mdev, watchdog, telnet, logging) and none uses
'set -e'.
> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/netsnmp/S59snmpd | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/package/netsnmp/S59snmpd b/package/netsnmp/S59snmpd
> index cfda625..2762082 100755
> --- a/package/netsnmp/S59snmpd
> +++ b/package/netsnmp/S59snmpd
> @@ -1,4 +1,4 @@
> -#! /bin/sh -e
> +#! /bin/sh
> ### BEGIN INIT INFO
> # Provides: snmpd snmptrapd
> # Required-Start: $network $local_fs
> @@ -11,7 +11,6 @@
> #
> # Author: Jochen Friedrich <jochen@scram.de>
> #
> -set -e
>
> export PATH=/sbin:/usr/sbin:/bin:/usr/bin
>
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 3/4] Package netsnmp: Added missing reload of snmptrapd
2016-02-25 21:24 [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload() Andreas Ehmanns
2016-02-25 21:24 ` [Buildroot] [PATCH 2/4] Package netsnmp: Removed 'set -e' Andreas Ehmanns
@ 2016-02-25 21:24 ` Andreas Ehmanns
2016-07-01 12:34 ` Yann E. MORIN
2016-02-25 21:24 ` [Buildroot] [PATCH 4/4] Package netsnmp: Added OK/FAIL output Andreas Ehmanns
` (2 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: Andreas Ehmanns @ 2016-02-25 21:24 UTC (permalink / raw)
To: buildroot
In case of a reload command the snmpdtrapd wasn't
restarted.
Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
---
package/netsnmp/S59snmpd | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/netsnmp/S59snmpd b/package/netsnmp/S59snmpd
index 2762082..2d076e0 100755
--- a/package/netsnmp/S59snmpd
+++ b/package/netsnmp/S59snmpd
@@ -65,6 +65,11 @@ reload() {
start-stop-daemon -q -K -s 1 -p /var/run/snmpd.pid -x /usr/sbin/snmpd
printf " snmpd"
fi
+
+ if [ "$TRAPDRUN" = "yes" -a -f /etc/snmp/snmptrapd.conf ]; then
+ start-stop-daemon -q -K -s 1 -p /var/run/snmptrapd.pid -x /usr/sbin/snmptrapd
+ printf " snmptrapd"
+ fi
echo "."
}
--
2.1.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [Buildroot] [PATCH 3/4] Package netsnmp: Added missing reload of snmptrapd
2016-02-25 21:24 ` [Buildroot] [PATCH 3/4] Package netsnmp: Added missing reload of snmptrapd Andreas Ehmanns
@ 2016-07-01 12:34 ` Yann E. MORIN
0 siblings, 0 replies; 13+ messages in thread
From: Yann E. MORIN @ 2016-07-01 12:34 UTC (permalink / raw)
To: buildroot
Andreas, All
[not sure why, but my previous reply did not make it to the list...]
On 2016-02-25 22:24 +0100, Andreas Ehmanns spake thusly:
> In case of a reload command the snmpdtrapd wasn't
> restarted.
>
> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/netsnmp/S59snmpd | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/netsnmp/S59snmpd b/package/netsnmp/S59snmpd
> index 2762082..2d076e0 100755
> --- a/package/netsnmp/S59snmpd
> +++ b/package/netsnmp/S59snmpd
> @@ -65,6 +65,11 @@ reload() {
> start-stop-daemon -q -K -s 1 -p /var/run/snmpd.pid -x /usr/sbin/snmpd
> printf " snmpd"
> fi
> +
> + if [ "$TRAPDRUN" = "yes" -a -f /etc/snmp/snmptrapd.conf ]; then
> + start-stop-daemon -q -K -s 1 -p /var/run/snmptrapd.pid -x /usr/sbin/snmptrapd
> + printf " snmptrapd"
> + fi
> echo "."
> }
>
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 4/4] Package netsnmp: Added OK/FAIL output
2016-02-25 21:24 [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload() Andreas Ehmanns
2016-02-25 21:24 ` [Buildroot] [PATCH 2/4] Package netsnmp: Removed 'set -e' Andreas Ehmanns
2016-02-25 21:24 ` [Buildroot] [PATCH 3/4] Package netsnmp: Added missing reload of snmptrapd Andreas Ehmanns
@ 2016-02-25 21:24 ` Andreas Ehmanns
2016-07-01 12:36 ` Yann E. MORIN
2016-07-01 10:08 ` [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload() Yann E. MORIN
2016-07-01 13:01 ` Thomas Petazzoni
4 siblings, 1 reply; 13+ messages in thread
From: Andreas Ehmanns @ 2016-02-25 21:24 UTC (permalink / raw)
To: buildroot
Reworked output of start(), stop() and reload() functions.
Return values of start-stop-daemon are now checked and
a OK or FAIL message is printed out.
Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
---
package/netsnmp/S59snmpd | 35 +++++++++++++++++++++--------------
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/package/netsnmp/S59snmpd b/package/netsnmp/S59snmpd
index 2d076e0..94773db 100755
--- a/package/netsnmp/S59snmpd
+++ b/package/netsnmp/S59snmpd
@@ -38,39 +38,45 @@ if [ "$SNMPDCOMPAT" = "yes" ]; then
fi
start() {
- printf "Starting network management services:"
if [ "$SNMPDRUN" = "yes" -a -f /etc/snmp/snmpd.conf ]; then
+ printf "Starting SNMP daemon: "
start-stop-daemon -q -S -x /usr/sbin/snmpd -- $SNMPDOPTS
- printf " snmpd"
+ [ $? = 0 ] && echo "OK" || echo "FAIL"
fi
+
if [ "$TRAPDRUN" = "yes" -a -f /etc/snmp/snmptrapd.conf ]; then
+ printf "Starting SNMP trap daemon: "
start-stop-daemon -q -S -x /usr/sbin/snmptrapd -- $TRAPDOPTS
- printf " snmptrapd"
+ [ $? = 0 ] && echo "OK" || echo "FAIL"
fi
- echo "."
}
stop() {
- printf "Stopping network management services:"
- start-stop-daemon -q -K $ssd_oknodo -x /usr/sbin/snmpd
- printf " snmpd"
- start-stop-daemon -q -K $ssd_oknodo -x /usr/sbin/snmptrapd
- printf " snmptrapd"
- echo "."
+ if [ "$SNMPDRUN" = "yes" -a -f /etc/snmp/snmpd.conf ]; then
+ printf "Stopping SNMP daemon: "
+ start-stop-daemon -q -K $ssd_oknodo -x /usr/sbin/snmpd
+ [ $? = 0 ] && echo "OK" || echo "FAIL"
+ fi
+
+ if [ "$TRAPDRUN" = "yes" -a -f /etc/snmp/snmptrapd.conf ]; then
+ printf "Stopping SNMP trap daemon: "
+ start-stop-daemon -q -K $ssd_oknodo -x /usr/sbin/snmptrapd
+ [ $? = 0 ] && echo "OK" || echo "FAIL"
+ fi
}
reload() {
- printf "Reloading network management services:"
if [ "$SNMPDRUN" = "yes" -a -f /etc/snmp/snmpd.conf ]; then
+ printf "Reloading SNMP daemon: "
start-stop-daemon -q -K -s 1 -p /var/run/snmpd.pid -x /usr/sbin/snmpd
- printf " snmpd"
+ [ $? = 0 ] && echo "OK" || echo "FAIL"
fi
if [ "$TRAPDRUN" = "yes" -a -f /etc/snmp/snmptrapd.conf ]; then
+ printf "Reloading SNMP trap daemon: "
start-stop-daemon -q -K -s 1 -p /var/run/snmptrapd.pid -x /usr/sbin/snmptrapd
- printf " snmptrapd"
+ [ $? = 0 ] && echo "OK" || echo "FAIL"
fi
- echo "."
}
case "$1" in
@@ -92,6 +98,7 @@ case "$1" in
reload|force-reload)
reload
;;
+
*)
echo "Usage: $0 {start|stop|restart|reload|force-reload}"
exit 1
--
2.1.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [Buildroot] [PATCH 4/4] Package netsnmp: Added OK/FAIL output
2016-02-25 21:24 ` [Buildroot] [PATCH 4/4] Package netsnmp: Added OK/FAIL output Andreas Ehmanns
@ 2016-07-01 12:36 ` Yann E. MORIN
2016-07-01 13:04 ` Thomas Petazzoni
0 siblings, 1 reply; 13+ messages in thread
From: Yann E. MORIN @ 2016-07-01 12:36 UTC (permalink / raw)
To: buildroot
Andreas, All,
On 2016-02-25 22:24 +0100, Andreas Ehmanns spake thusly:
> Reworked output of start(), stop() and reload() functions.
> Return values of start-stop-daemon are now checked and
> a OK or FAIL message is printed out.
>
> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
> ---
> package/netsnmp/S59snmpd | 35 +++++++++++++++++++++--------------
> 1 file changed, 21 insertions(+), 14 deletions(-)
>
> diff --git a/package/netsnmp/S59snmpd b/package/netsnmp/S59snmpd
> index 2d076e0..94773db 100755
> --- a/package/netsnmp/S59snmpd
> +++ b/package/netsnmp/S59snmpd
[--SNIP--]
> @@ -92,6 +98,7 @@ case "$1" in
> reload|force-reload)
> reload
> ;;
> +
Spurious empty line.
Otherwise:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> *)
> echo "Usage: $0 {start|stop|restart|reload|force-reload}"
> exit 1
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 13+ messages in thread* [Buildroot] [PATCH 4/4] Package netsnmp: Added OK/FAIL output
2016-07-01 12:36 ` Yann E. MORIN
@ 2016-07-01 13:04 ` Thomas Petazzoni
2016-07-06 16:47 ` Andreas Ehmanns
0 siblings, 1 reply; 13+ messages in thread
From: Thomas Petazzoni @ 2016-07-01 13:04 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 1 Jul 2016 14:36:44 +0200, Yann E. MORIN wrote:
> > @@ -92,6 +98,7 @@ case "$1" in
> > reload|force-reload)
> > reload
> > ;;
> > +
>
> Spurious empty line.
It's indeed not strictly related, but in all other cases of this
switch, there is an empty line separating cases. So I think it's good
to also have this one for consistency. It could have been in a separate
commit, but oh well, that was good enough.
Thanks for the review!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 4/4] Package netsnmp: Added OK/FAIL output
2016-07-01 13:04 ` Thomas Petazzoni
@ 2016-07-06 16:47 ` Andreas Ehmanns
0 siblings, 0 replies; 13+ messages in thread
From: Andreas Ehmanns @ 2016-07-06 16:47 UTC (permalink / raw)
To: buildroot
Dear Thomas, Yann, all,
thanks for revising the patch series and for incorporating the changes
into buildroot.
Regards,
Andreas
Am 01.07.2016 um 15:04 schrieb Thomas Petazzoni:
> Hello,
>
> On Fri, 1 Jul 2016 14:36:44 +0200, Yann E. MORIN wrote:
>
>>> @@ -92,6 +98,7 @@ case "$1" in
>>> reload|force-reload)
>>> reload
>>> ;;
>>> +
>> Spurious empty line.
> It's indeed not strictly related, but in all other cases of this
> switch, there is an empty line separating cases. So I think it's good
> to also have this one for consistency. It could have been in a separate
> commit, but oh well, that was good enough.
>
> Thanks for the review!
>
> Thomas
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload().
2016-02-25 21:24 [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload() Andreas Ehmanns
` (2 preceding siblings ...)
2016-02-25 21:24 ` [Buildroot] [PATCH 4/4] Package netsnmp: Added OK/FAIL output Andreas Ehmanns
@ 2016-07-01 10:08 ` Yann E. MORIN
2016-07-01 13:01 ` Thomas Petazzoni
4 siblings, 0 replies; 13+ messages in thread
From: Yann E. MORIN @ 2016-07-01 10:08 UTC (permalink / raw)
To: buildroot
Andreas, All,
On 2016-02-25 22:24 +0100, Andreas Ehmanns spake thusly:
> Changed init script to get rid of double code.
> Start, stop and reload code has been put into
> separate functions and 'restart' will just call
> stop() and start() with a delay in between.
>
> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/netsnmp/S59snmpd | 71 +++++++++++++++++++++++++-----------------------
> 1 file changed, 37 insertions(+), 34 deletions(-)
>
> diff --git a/package/netsnmp/S59snmpd b/package/netsnmp/S59snmpd
> index 4eea512..cfda625 100755
> --- a/package/netsnmp/S59snmpd
> +++ b/package/netsnmp/S59snmpd
> @@ -38,56 +38,59 @@ if [ "$SNMPDCOMPAT" = "yes" ]; then
> ln -sf /var/agentx/master /var/run/agentx
> fi
>
> -case "$1" in
> - start)
> +start() {
> printf "Starting network management services:"
> if [ "$SNMPDRUN" = "yes" -a -f /etc/snmp/snmpd.conf ]; then
> - start-stop-daemon -q -S -x /usr/sbin/snmpd -- $SNMPDOPTS
> - printf " snmpd"
> + start-stop-daemon -q -S -x /usr/sbin/snmpd -- $SNMPDOPTS
> + printf " snmpd"
> fi
> if [ "$TRAPDRUN" = "yes" -a -f /etc/snmp/snmptrapd.conf ]; then
> - start-stop-daemon -q -S -x /usr/sbin/snmptrapd -- $TRAPDOPTS
> - printf " snmptrapd"
> + start-stop-daemon -q -S -x /usr/sbin/snmptrapd -- $TRAPDOPTS
> + printf " snmptrapd"
> fi
> echo "."
> - ;;
> - stop)
> +}
> +
> +stop() {
> printf "Stopping network management services:"
> start-stop-daemon -q -K $ssd_oknodo -x /usr/sbin/snmpd
> printf " snmpd"
> start-stop-daemon -q -K $ssd_oknodo -x /usr/sbin/snmptrapd
> printf " snmptrapd"
> echo "."
> - ;;
> - restart)
> - printf "Restarting network management services:"
> - start-stop-daemon -q -K $ssd_oknodo -x /usr/sbin/snmpd
> - start-stop-daemon -q -K $ssd_oknodo -x /usr/sbin/snmptrapd
> - # Allow the daemons time to exit completely.
> - sleep 2
> - if [ "$SNMPDRUN" = "yes" -a -f /etc/snmp/snmpd.conf ]; then
> - start-stop-daemon -q -S -x /usr/sbin/snmpd -- $SNMPDOPTS
> - printf " snmpd"
> - fi
> - if [ "$TRAPDRUN" = "yes" -a -f /etc/snmp/snmptrapd.conf ]; then
> - # Allow snmpd time to start up.
> - sleep 1
> - start-stop-daemon -q -S -x /usr/sbin/snmptrapd -- $TRAPDOPTS
> - printf " snmptrapd"
> - fi
> - echo "."
> - ;;
> - reload|force-reload)
> +}
> +
> +reload() {
> printf "Reloading network management services:"
> if [ "$SNMPDRUN" = "yes" -a -f /etc/snmp/snmpd.conf ]; then
> - start-stop-daemon -q -K -s 1 -p /var/run/snmpd.pid -x /usr/sbin/snmpd
> - printf " snmpd"
> + start-stop-daemon -q -K -s 1 -p /var/run/snmpd.pid -x /usr/sbin/snmpd
> + printf " snmpd"
> fi
> echo "."
> - ;;
> - *)
> - echo "Usage: /etc/init.d/snmpd {start|stop|restart|reload|force-reload}"
> - exit 1
> +}
> +
> +case "$1" in
> + start)
> + start
> + ;;
> +
> + stop)
> + stop
> + ;;
> +
> + restart)
> + stop
> + # Allow the daemons time to exit completely.
> + sleep 2
> + start
> + ;;
> +
> + reload|force-reload)
> + reload
> + ;;
> + *)
> + echo "Usage: $0 {start|stop|restart|reload|force-reload}"
> + exit 1
> esac
>
> exit 0
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 13+ messages in thread* [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload().
2016-02-25 21:24 [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload() Andreas Ehmanns
` (3 preceding siblings ...)
2016-07-01 10:08 ` [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload() Yann E. MORIN
@ 2016-07-01 13:01 ` Thomas Petazzoni
2016-07-02 10:25 ` Peter Korsgaard
4 siblings, 1 reply; 13+ messages in thread
From: Thomas Petazzoni @ 2016-07-01 13:01 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 25 Feb 2016 22:24:41 +0100, Andreas Ehmanns wrote:
> Changed init script to get rid of double code.
> Start, stop and reload code has been put into
> separate functions and 'restart' will just call
> stop() and start() with a delay in between.
>
> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
> ---
> package/netsnmp/S59snmpd | 71 +++++++++++++++++++++++++-----------------------
> 1 file changed, 37 insertions(+), 34 deletions(-)
Entire series applied, after tweaking the commit titles and in some
cases the commit log.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 13+ messages in thread* [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload().
2016-07-01 13:01 ` Thomas Petazzoni
@ 2016-07-02 10:25 ` Peter Korsgaard
2016-07-02 10:40 ` Thomas Petazzoni
0 siblings, 1 reply; 13+ messages in thread
From: Peter Korsgaard @ 2016-07-02 10:25 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Hello,
> On Thu, 25 Feb 2016 22:24:41 +0100, Andreas Ehmanns wrote:
>> Changed init script to get rid of double code.
>> Start, stop and reload code has been put into
>> separate functions and 'restart' will just call
>> stop() and start() with a delay in between.
>>
>> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
>> ---
>> package/netsnmp/S59snmpd | 71 +++++++++++++++++++++++++-----------------------
>> 1 file changed, 37 insertions(+), 34 deletions(-)
> Entire series applied, after tweaking the commit titles and in some
> cases the commit log.
For the future, please use your full name in the From: as well (git
commit user.name "Andreas Ehmanns"). Now these commits are listed as
being from "universe II".
Thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload().
2016-07-02 10:25 ` Peter Korsgaard
@ 2016-07-02 10:40 ` Thomas Petazzoni
0 siblings, 0 replies; 13+ messages in thread
From: Thomas Petazzoni @ 2016-07-02 10:40 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 02 Jul 2016 12:25:50 +0200, Peter Korsgaard wrote:
> For the future, please use your full name in the From: as well (git
> commit user.name "Andreas Ehmanns"). Now these commits are listed as
> being from "universe II".
Yeah, also noticed that, but after pushing :-/ The Signed-off-by line
is more visible and that one was correct, so I didn't notice.
Sadly, the new pedantic git commit hook checks that the e-mail between
the From and the SoB line are matching, but not the name itself.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 13+ messages in thread