Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] vala: fix package suffix
@ 2017-01-12 13:38 Vicente Olivert Riera
  2017-01-12 13:38 ` [Buildroot] [PATCH 2/2] vala: bump version to 0.35.3 Vicente Olivert Riera
  2017-01-24 10:14 ` [Buildroot] [PATCH 1/2] vala: fix package suffix Thomas Petazzoni
  0 siblings, 2 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2017-01-12 13:38 UTC (permalink / raw)
  To: buildroot

vala executable has a suffix and we reffer to it in our vala wrapper,
but we assume that suffix is always the same as the major version. This
can be wrong, so better to obtain the suffix number from the config.h
file.

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/vala/vala.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/vala/vala.mk b/package/vala/vala.mk
index dadfdfc..baa97ab 100644
--- a/package/vala/vala.mk
+++ b/package/vala/vala.mk
@@ -23,7 +23,7 @@ define HOST_VALA_INSTALL_WRAPPER
 		$(HOST_DIR)/usr/bin/vala
 	$(INSTALL) -D -m 0755 package/vala/vala-wrapper \
 		$(HOST_DIR)/usr/bin/valac
-	$(SED) 's, at VALA_VERSION@,$(VALA_VERSION_MAJOR),' \
+	$(SED) 's, at VALA_VERSION@,$(shell grep PACKAGE_SUFFIX $(@D)/config.h | grep -o -E "[0-9]+\.[0-9]+"),' \
 		$(HOST_DIR)/usr/bin/vala \
 		$(HOST_DIR)/usr/bin/valac
 endef
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] vala: bump version to 0.35.3
  2017-01-12 13:38 [Buildroot] [PATCH 1/2] vala: fix package suffix Vicente Olivert Riera
@ 2017-01-12 13:38 ` Vicente Olivert Riera
  2017-01-24 10:14 ` [Buildroot] [PATCH 1/2] vala: fix package suffix Thomas Petazzoni
  1 sibling, 0 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2017-01-12 13:38 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/vala/vala.hash | 4 ++--
 package/vala/vala.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/vala/vala.hash b/package/vala/vala.hash
index ca5873c..7b6c287 100644
--- a/package/vala/vala.hash
+++ b/package/vala/vala.hash
@@ -1,2 +1,2 @@
-# From https://download.gnome.org/sources/vala/0.34/vala-0.34.4.sha256sum
-sha256 6b17bd339414563ebc51f64b0b837919ea7552d8a8ffa71cdc837d25c9696b83  vala-0.34.4.tar.xz
+# From https://download.gnome.org/sources/vala/0.35/vala-0.35.3.sha256sum
+sha256 2d61184a2b483fe82f6f588271cd95575ed039e830a4d80d46774124b2e2b982  vala-0.35.3.tar.xz
diff --git a/package/vala/vala.mk b/package/vala/vala.mk
index baa97ab..c118c34 100644
--- a/package/vala/vala.mk
+++ b/package/vala/vala.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-VALA_VERSION_MAJOR = 0.34
-VALA_VERSION = $(VALA_VERSION_MAJOR).4
+VALA_VERSION_MAJOR = 0.35
+VALA_VERSION = $(VALA_VERSION_MAJOR).3
 VALA_SITE = http://download.gnome.org/sources/vala/$(VALA_VERSION_MAJOR)
 VALA_SOURCE = vala-$(VALA_VERSION).tar.xz
 VALA_LICENSE = LGPLv2.1+
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] vala: fix package suffix
  2017-01-12 13:38 [Buildroot] [PATCH 1/2] vala: fix package suffix Vicente Olivert Riera
  2017-01-12 13:38 ` [Buildroot] [PATCH 2/2] vala: bump version to 0.35.3 Vicente Olivert Riera
@ 2017-01-24 10:14 ` Thomas Petazzoni
  2017-01-24 10:17   ` Gustavo Zacarias
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2017-01-24 10:14 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 12 Jan 2017 13:38:30 +0000, Vicente Olivert Riera wrote:
> vala executable has a suffix and we reffer to it in our vala wrapper,
> but we assume that suffix is always the same as the major version. This
> can be wrong, so better to obtain the suffix number from the config.h
> file.
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Nope, that is not needed I believe.

Like all Gnome projects, 0.35 is not a stable vala version, so there's
no reason to package it. And I guess that also explains why vala 0.35
still uses 0.34 as the package suffix.

So, by not package a development version, we also don't need this "fix
package suffix" patch.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] vala: fix package suffix
  2017-01-24 10:14 ` [Buildroot] [PATCH 1/2] vala: fix package suffix Thomas Petazzoni
@ 2017-01-24 10:17   ` Gustavo Zacarias
  0 siblings, 0 replies; 4+ messages in thread
From: Gustavo Zacarias @ 2017-01-24 10:17 UTC (permalink / raw)
  To: buildroot

On 24/01/17 07:14, Thomas Petazzoni wrote:

> Nope, that is not needed I believe.
>
> Like all Gnome projects, 0.35 is not a stable vala version, so there's
> no reason to package it. And I guess that also explains why vala 0.35
> still uses 0.34 as the package suffix.
>
> So, by not package a development version, we also don't need this "fix
> package suffix" patch.
>
> Best regards,
>
> Thomas

Hi All.
Indeed, odd major numbers in the gnome project are development versions, 
like gtk 3.89, glib 2.51 and others.
Regards.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-24 10:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-12 13:38 [Buildroot] [PATCH 1/2] vala: fix package suffix Vicente Olivert Riera
2017-01-12 13:38 ` [Buildroot] [PATCH 2/2] vala: bump version to 0.35.3 Vicente Olivert Riera
2017-01-24 10:14 ` [Buildroot] [PATCH 1/2] vala: fix package suffix Thomas Petazzoni
2017-01-24 10:17   ` Gustavo Zacarias

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox