From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Add BR2_CMAKE_USE_NINJA_BACKEND option
Date: Wed, 25 Jan 2017 14:37:43 +1300 [thread overview]
Message-ID: <20170125143743.0df51d6d@free-electrons.com> (raw)
In-Reply-To: <20170106223748.2203-1-cedric.marie@openmailbox.org>
Hello,
On Fri, 6 Jan 2017 23:37:47 +0100, C?dric Marie wrote:
> $(2)_CONF_ENV ?=
> $(2)_CONF_OPTS ?=
> +$(2)_INSTALL_STAGING_ENV ?= DESTDIR=$$(STAGING_DIR)
> +$(2)_INSTALL_TARGET_ENV ?= DESTDIR=$$(TARGET_DIR)
We don't have such options in any other package infrastructure. So I
think I'd prefer if you kept just INSTALL_STAGING_OPTS and
INSTALL_TARGET_OPTS, and define them to the appropriate value depending
on whether you're using Ninja or Make.
Are there any existing CMake package that overrides
INSTALL_STAGING_OPTS or INSTALL_TARGET_OPTS ? If that's the case, then
we cannot change its semantic like this without taking care of those
packages first.
But as I said in my other reply on this thread, I'd really like to get
some justification of why adding support for the Ninja backend is
useful.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-01-25 1:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 22:37 [Buildroot] [PATCH 1/2] Add BR2_CMAKE_USE_NINJA_BACKEND option Cédric Marie
2017-01-06 22:37 ` [Buildroot] [PATCH 2/2] Update documentation of CMake infrastructure Cédric Marie
2017-01-25 3:27 ` Thomas Petazzoni
2017-01-21 22:25 ` [Buildroot] [PATCH 1/2] Add BR2_CMAKE_USE_NINJA_BACKEND option Romain Naour
2017-01-23 13:39 ` Cédric Marie
2017-01-24 21:48 ` Romain Naour
2017-01-25 1:27 ` Thomas Petazzoni
2017-01-26 17:27 ` Cédric Marie
2017-01-30 9:23 ` Thomas Petazzoni
2017-02-01 17:01 ` Cédric Marie
2017-02-01 20:12 ` Thomas Petazzoni
2017-02-03 10:44 ` Cédric Marie
2017-01-25 1:37 ` Thomas Petazzoni [this message]
2017-07-11 11:56 ` Thomas Petazzoni
2017-07-11 13:25 ` Cédric Marie
2017-07-11 13:35 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125143743.0df51d6d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox