Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] Update documentation of CMake infrastructure
Date: Wed, 25 Jan 2017 16:27:05 +1300	[thread overview]
Message-ID: <20170125162705.7b50849e@free-electrons.com> (raw)
In-Reply-To: <20170106223748.2203-2-cedric.marie@openmailbox.org>

Hello,

On Fri,  6 Jan 2017 23:37:48 +0100, C?dric Marie wrote:

> diff --git a/docs/manual/adding-packages-cmake.txt b/docs/manual/adding-packages-cmake.txt
> index 6ccf390..06331dd 100644
> --- a/docs/manual/adding-packages-cmake.txt
> +++ b/docs/manual/adding-packages-cmake.txt
> @@ -117,25 +117,38 @@ typical packages will therefore only use a few of them.
>    the given package, for one reason or another. By default, set to
>    +$(MAKE)+. If parallel building is not supported by the package,
>    then it should be set to +LIBFOO_MAKE=$(MAKE1)+.
> +  When +BR2_CMAKE_USE_NINJA_BACKEND+ is enabled, the default value is
> +  +$(HOST_DIR)/usr/bin/ninja+. If parallel building is not supported by
> +  the package, then it should be set to
> +  +LIBFOO_MAKE=$(HOST_DIR)/usr/bin/ninja -j1+.

That's a bit annoying, because it means packages would have to do:

ifeq ($(BR2_CMAKE_USE_NINJA_BACKEND),y)
LIBFOO_MAKE = $(HOST_DIR)/usr/bin/ninja -j1
else
LIBFOO_MAKE = $(MAKE1)
endif

So perhaps in this case we instead need a variable like
LIBFOO_SUPPORTS_PARALLEL_BUILD so that the infrastructure can do the
right thing.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-01-25  3:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 22:37 [Buildroot] [PATCH 1/2] Add BR2_CMAKE_USE_NINJA_BACKEND option Cédric Marie
2017-01-06 22:37 ` [Buildroot] [PATCH 2/2] Update documentation of CMake infrastructure Cédric Marie
2017-01-25  3:27   ` Thomas Petazzoni [this message]
2017-01-21 22:25 ` [Buildroot] [PATCH 1/2] Add BR2_CMAKE_USE_NINJA_BACKEND option Romain Naour
2017-01-23 13:39   ` Cédric Marie
2017-01-24 21:48     ` Romain Naour
2017-01-25  1:27       ` Thomas Petazzoni
2017-01-26 17:27         ` Cédric Marie
2017-01-30  9:23           ` Thomas Petazzoni
2017-02-01 17:01             ` Cédric Marie
2017-02-01 20:12               ` Thomas Petazzoni
2017-02-03 10:44                 ` Cédric Marie
2017-01-25  1:37 ` Thomas Petazzoni
2017-07-11 11:56 ` Thomas Petazzoni
2017-07-11 13:25   ` Cédric Marie
2017-07-11 13:35     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125162705.7b50849e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox