Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Add BR2_CMAKE_USE_NINJA_BACKEND option
Date: Tue, 11 Jul 2017 15:35:41 +0200	[thread overview]
Message-ID: <20170711153541.136d2367@windsurf.lan> (raw)
In-Reply-To: <723cceef4b58126fadeced55d5bcb326@openmailbox.org>

Hello,

On Tue, 11 Jul 2017 15:25:46 +0200, C?dric Marie wrote:

> Le 2017-07-11 13:56, Thomas Petazzoni a ?crit?:
> > Do you know why a CMake package could be working with the make backend,
> > but not with the ninja backend ?  
> 
> In file CMakeLists.txt, in the root directory of the bullet package, I 
> have found:
> 
> IF("${CMAKE_GENERATOR}" MATCHES "Unix Makefiles")
> 	OPTION(INSTALL_LIBS "Set when you want to install libraries" ON)
> ELSE()
> 	IF(APPLE AND FRAMEWORK)
> 		OPTION(INSTALL_LIBS "Set when you want to install libraries" ON)
> 	ELSE()
> #by default, don't enable the 'INSTALL' option for Xcode and MSVC 
> projectfiles
> 		OPTION(INSTALL_LIBS "Set when you want to install libraries" OFF)
> 	ENDIF()
> ENDIF()
> 
> 
> I believe that's the reason :)

Indeed! I skimmed through the CMakeLists.txt file, but didn't spot this
obvious thing.

> I suppose the test was expecting to detect the type of machine, while it 
> is based on the type of backend...
> This should be fixed in "bullet" package, either by testing Ninja 
> backend as well, or changing the test (I don't know exactly what he's 
> trying to test...)

I think it's just a bug on their side. I've filed an issue
(https://github.com/bulletphysics/bullet3/issues/1225). Though with 286
open issues, I'm not sure how long it will take for this issue to be
looked at :)

But anyway, it is a very package-specific issue here, unlikely to
affect many other packages. Thanks for having investigated this!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2017-07-11 13:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 22:37 [Buildroot] [PATCH 1/2] Add BR2_CMAKE_USE_NINJA_BACKEND option Cédric Marie
2017-01-06 22:37 ` [Buildroot] [PATCH 2/2] Update documentation of CMake infrastructure Cédric Marie
2017-01-25  3:27   ` Thomas Petazzoni
2017-01-21 22:25 ` [Buildroot] [PATCH 1/2] Add BR2_CMAKE_USE_NINJA_BACKEND option Romain Naour
2017-01-23 13:39   ` Cédric Marie
2017-01-24 21:48     ` Romain Naour
2017-01-25  1:27       ` Thomas Petazzoni
2017-01-26 17:27         ` Cédric Marie
2017-01-30  9:23           ` Thomas Petazzoni
2017-02-01 17:01             ` Cédric Marie
2017-02-01 20:12               ` Thomas Petazzoni
2017-02-03 10:44                 ` Cédric Marie
2017-01-25  1:37 ` Thomas Petazzoni
2017-07-11 11:56 ` Thomas Petazzoni
2017-07-11 13:25   ` Cédric Marie
2017-07-11 13:35     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170711153541.136d2367@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox