[Buildroot] [PATCH 1/1] package/sngrep: needs ncurses form/menu/panel libraries

[Buildroot] [PATCH 1/1] package/sngrep: needs ncurses form/menu/panel libraries

[Bernd Kuhls]

Please see configure checks for the various ncurses libraries:

form
https://github.com/irontec/sngrep/blob/master/configure.ac#L90

menu
https://github.com/irontec/sngrep/blob/master/configure.ac#L94

panel
https://github.com/irontec/sngrep/blob/master/configure.ac#L86

Fixes
http://autobuild.buildroot.net/results/3a4/3a4751fcc6184d562df80d1cd6bf53e788e21392/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/sngrep/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/sngrep/Config.in b/package/sngrep/Config.in
index 4d0d80c13..1d2ee4787 100644
--- a/package/sngrep/Config.in
+++ b/package/sngrep/Config.in
@@ -5,6 +5,9 @@ config BR2_PACKAGE_SNGREP
 	bool "sngrep"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_NCURSES_TARGET_FORM
+	select BR2_PACKAGE_NCURSES_TARGET_MENU
+	select BR2_PACKAGE_NCURSES_TARGET_PANEL
 	select BR2_PACKAGE_LIBPCAP
 	help
 	  sngrep is a tool for displaying SIP calls message flows from
-- 
2.11.0

[Buildroot] [PATCH 1/1] package/sngrep: needs ncurses form/menu/panel libraries

[Thomas Petazzoni]

Hello,

On Sat, 28 Jan 2017 17:57:45 +0100, Bernd Kuhls wrote:
> Please see configure checks for the various ncurses libraries:
> 
> form
> https://github.com/irontec/sngrep/blob/master/configure.ac#L90
> 
> menu
> https://github.com/irontec/sngrep/blob/master/configure.ac#L94
> 
> panel
> https://github.com/irontec/sngrep/blob/master/configure.ac#L86
> 
> Fixes
> http://autobuild.buildroot.net/results/3a4/3a4751fcc6184d562df80d1cd6bf53e788e21392/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

I don't yet understand those build failures. Indeed, locally, I'm able
to build the following defconfig, which has form/menu/panel disabled,
but sngrep builds fine:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-basic-2016.11-236-ge309abf.tar.bz2"
BR2_TOOLCHAIN_EXTERNAL_GCC_5=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_8=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_SNGREP=y
# BR2_TARGET_ROOTFS_TAR is not set

The options are only about installing the libraries to the target, they
are always installed to staging it seems. So while I agree they are
needed, I still don't understand the build failures reported by the
autobuilders.

Am I missing something?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] package/sngrep: needs ncurses form/menu/panel libraries

[Bernd Kuhls]

Am Sun, 29 Jan 2017 14:30:37 +0100 schrieb Thomas Petazzoni:

> Hello,
> 
> On Sat, 28 Jan 2017 17:57:45 +0100, Bernd Kuhls wrote:
>> Please see configure checks for the various ncurses libraries:
>> 
>> form https://github.com/irontec/sngrep/blob/master/configure.ac#L90
>> 
>> menu https://github.com/irontec/sngrep/blob/master/configure.ac#L94
>> 
>> panel https://github.com/irontec/sngrep/blob/master/configure.ac#L86
>> 
>> Fixes
>> http://autobuild.buildroot.net/
results/3a4/3a4751fcc6184d562df80d1cd6bf53e788e21392/
>> 
>> Signed-off-by: Bernd Kuhls
>> <bernd.kuhls@t-online.de>
> 
> I don't yet understand those build failures. Indeed, locally, I'm able
> to build the following defconfig, which has form/menu/panel disabled,
> but sngrep builds fine:

Hi,

you are right, your defconfig works because BR2_PACKAGE_NCURSES_WCHAR is 
disabled. All autobuilder failures occur with BR2_PACKAGE_NCURSES_WCHAR=y.

sngrep.mk contains --disable-unicode due to problems while detecting 
ncurses.h, see commit log for details:
https://git.buildroot.net/buildroot/commit/package/sngrep?
id=bf09290977a5b43f53479dd52777fde0bb20bf5a

Using --disable-unicode forces the configure script to check for the 
ncurses libs without "w" in their name only:
https://github.com/irontec/sngrep/blob/master/configure.ac#L77, but they 
are not present with BR2_PACKAGE_NCURSES_WCHAR=y leading to the configure 
error seen by the autobuilders.

Quick fix: depends on !BR2_PACKAGE_NCURSES_WCHAR

Regards, Bernd