From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/5] package/cmake: re-introduce cmake-3.7
Date: Wed, 1 Mar 2017 08:59:28 +0100 [thread overview]
Message-ID: <20170301085928.6380ed25@free-electrons.com> (raw)
In-Reply-To: <1e11d59e-9274-f4fb-f966-002c26ca6247@mind.be>
Hello,
On Wed, 1 Mar 2017 08:49:47 +0100, Arnout Vandecappelle wrote:
> I don't think it makes much sense to keep the 4 separate patches. The history
> shows the authorship of the original bump. Having the 4 separate patches just
> adds noise to the history. Also, Thomas reported that the libuv dependency
> introduced by the bump is probably incorrect, so we'd have to revert patch 4/5
> and part of patch 2/5 again later on... And if the dependency on libuv *is*
> needed, then you re-introduce a non-bisectable commit between patch 2/5 and 4/5.
Well, the libuv dependency is incorrect in the sense that ctest doesn't
seem to use libuv.
*However*, the libuv dependency is correct in the sense that the
CMakeLists.txt checks it, and if not, builds the cmake built-in version
of libuv. But since for the target we only build ctest, this whole
libuv is not used.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-01 7:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 18:07 [Buildroot] [PATCH 0/5] package/cmake: re-introduce cmake-3.7 Yann E. MORIN
2017-02-28 18:07 ` [Buildroot] [PATCH 1/5] core/pkg-cmake: provide our own platform description Yann E. MORIN
2017-02-28 18:26 ` Baruch Siach
2017-02-28 20:03 ` Yann E. MORIN
2017-02-28 20:41 ` Jörg Krause
2017-02-28 20:58 ` Yann E. MORIN
2017-02-28 22:15 ` Jörg Krause
2017-03-01 8:01 ` Arnout Vandecappelle
2017-03-01 7:58 ` Arnout Vandecappelle
2017-03-01 8:17 ` Thomas Petazzoni
2017-03-01 8:35 ` Arnout Vandecappelle
2017-03-01 18:43 ` Yann E. MORIN
2017-03-05 23:27 ` Arnout Vandecappelle
2017-03-06 17:00 ` Yann E. MORIN
2017-03-06 22:02 ` Arnout Vandecappelle
2017-03-02 12:29 ` Baruch Siach
2017-03-02 12:41 ` Thomas Petazzoni
2017-02-28 18:07 ` [Buildroot] [PATCH 2/5] cmake: bump version to 3.7.0 Yann E. MORIN
2017-02-28 18:07 ` [Buildroot] [PATCH 3/5] cmake: bump version to 3.7.1 Yann E. MORIN
2017-02-28 18:07 ` [Buildroot] [PATCH 4/5] cmake: adjust dependencies added for libuv Yann E. MORIN
2017-02-28 18:07 ` [Buildroot] [PATCH 5/5] cmake: bump version to 3.7.2 Yann E. MORIN
2017-03-01 7:49 ` [Buildroot] [PATCH 0/5] package/cmake: re-introduce cmake-3.7 Arnout Vandecappelle
2017-03-01 7:59 ` Thomas Petazzoni [this message]
2017-03-01 21:14 ` Thomas Petazzoni
2017-03-02 8:41 ` Thomas Petazzoni
2017-03-02 17:39 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301085928.6380ed25@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox