From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] core/pkg-cmake: provide our own platform description
Date: Wed, 1 Mar 2017 19:43:43 +0100 [thread overview]
Message-ID: <20170301184343.GB3578@free.fr> (raw)
In-Reply-To: <19fbcec2-68a4-a287-a20f-522c94ede5e7@mind.be>
Arnout, All,
On 2017-03-01 09:35 +0100, Arnout Vandecappelle spake thusly:
> On 01-03-17 09:17, Thomas Petazzoni wrote:
> > Hello,
> >
> > On Wed, 1 Mar 2017 08:58:31 +0100, Arnout Vandecappelle wrote:
> >
> >> Since you don't do any processing on the file, you could just use
> >>
> >> -DCMAKE_MODULE_PATH="$$(TOPDIR)/support/misc" \
> >
> > I think the idea is that since the Buildroot.cmake platform files gets
> > referenced by the toolchainfile.cmake, then Buildroot.cmake anyway
> > needs to be installed in $(HOST_DIR)/usr/share/buildroot, so we can
> > just as well point CMake to this place.
> >
> >> and avoid copying the file around. Of course, in that case, support/cmake is
> >> probably a better place to put the file :-)
> >
> > No: copying the file is needed, otherwise our toolchainfile.cmake file
> > no longer works for people using it outside of Buildroot.
>
> Good point. I still think it should be in staging rather than host, but for
> sure it's more important to keep them together.
Why would you want it in staging? When we build our own internal cmake,
the moduels it installs are so installed in host, not staging. They are
build-description files, not target files.
Ergo, they should be in host, not staging.
Regards,
Yann E. MORIN.
> Therefore:
>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> Regards,
> Arnout
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-03-01 18:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 18:07 [Buildroot] [PATCH 0/5] package/cmake: re-introduce cmake-3.7 Yann E. MORIN
2017-02-28 18:07 ` [Buildroot] [PATCH 1/5] core/pkg-cmake: provide our own platform description Yann E. MORIN
2017-02-28 18:26 ` Baruch Siach
2017-02-28 20:03 ` Yann E. MORIN
2017-02-28 20:41 ` Jörg Krause
2017-02-28 20:58 ` Yann E. MORIN
2017-02-28 22:15 ` Jörg Krause
2017-03-01 8:01 ` Arnout Vandecappelle
2017-03-01 7:58 ` Arnout Vandecappelle
2017-03-01 8:17 ` Thomas Petazzoni
2017-03-01 8:35 ` Arnout Vandecappelle
2017-03-01 18:43 ` Yann E. MORIN [this message]
2017-03-05 23:27 ` Arnout Vandecappelle
2017-03-06 17:00 ` Yann E. MORIN
2017-03-06 22:02 ` Arnout Vandecappelle
2017-03-02 12:29 ` Baruch Siach
2017-03-02 12:41 ` Thomas Petazzoni
2017-02-28 18:07 ` [Buildroot] [PATCH 2/5] cmake: bump version to 3.7.0 Yann E. MORIN
2017-02-28 18:07 ` [Buildroot] [PATCH 3/5] cmake: bump version to 3.7.1 Yann E. MORIN
2017-02-28 18:07 ` [Buildroot] [PATCH 4/5] cmake: adjust dependencies added for libuv Yann E. MORIN
2017-02-28 18:07 ` [Buildroot] [PATCH 5/5] cmake: bump version to 3.7.2 Yann E. MORIN
2017-03-01 7:49 ` [Buildroot] [PATCH 0/5] package/cmake: re-introduce cmake-3.7 Arnout Vandecappelle
2017-03-01 7:59 ` Thomas Petazzoni
2017-03-01 21:14 ` Thomas Petazzoni
2017-03-02 8:41 ` Thomas Petazzoni
2017-03-02 17:39 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301184343.GB3578@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox