[Buildroot] [PATCH 1/5] core/pkg-cmake: provide our own platform description

[Yann E. MORIN <yann.morin.1998@free.fr>]

Arnout, All,

On 2017-03-06 00:27 +0100, Arnout Vandecappelle spake thusly:
> On 01-03-17 19:43, Yann E. MORIN wrote:
> > Arnout, All,
> > 
> > On 2017-03-01 09:35 +0100, Arnout Vandecappelle spake thusly:
> >> On 01-03-17 09:17, Thomas Petazzoni wrote:
> >>> Hello,
> >>>
> >>> On Wed, 1 Mar 2017 08:58:31 +0100, Arnout Vandecappelle wrote:
> >>>
> >>>>  Since you don't do any processing on the file, you could just use
> >>>>
> >>>> 		-DCMAKE_MODULE_PATH="$$(TOPDIR)/support/misc" \
> >>>
> >>> I think the idea is that since the Buildroot.cmake platform files gets
> >>> referenced by the toolchainfile.cmake, then Buildroot.cmake anyway
> >>> needs to be installed in $(HOST_DIR)/usr/share/buildroot, so we can
> >>> just as well point CMake to this place.
> >>>
> >>>> and avoid copying the file around. Of course, in that case, support/cmake is
> >>>> probably a better place to put the file :-)
> >>>
> >>> No: copying the file is needed, otherwise our toolchainfile.cmake file
> >>> no longer works for people using it outside of Buildroot.
> >>
> >>  Good point. I still think it should be in staging rather than host, but for
> >> sure it's more important to keep them together.
> > 
> > Why would you want it in staging? When we build our own internal cmake,
> > the moduels it installs are so installed in host, not staging. They are
> > build-description files, not target files.
> > 
> > Ergo, they should be in host, not staging.
> 
>  I was looking at it like the .pc files, which are in staging because they talk
> about the target.

But it is not like a .pc file.  It does not describe libs to link with
(-l), or where to lok for headers and libs (-I and -L).

It is more like the toolchain file itself; but see below...

>  About the modules: in fact, packages that install .cmake files will do that in
> staging, not in host. So I do hope that cmake looks for them in staging as
> well... That's what CMAKE_FIND_ROOT_PATH is for, isn't it?
> 
>  In fact, the only .cmake files I see installed in the host dir are:
> 
> - the Modules from CMake itself, but these are more related to the CMake
> language, e.g. CheckIncludeFiles.cmake;

And what about all the modules describing platforms:

    host/usr/share/cmake-3.7/Modules/Platform/

and the file that actually sources the platform description:

    host/usr/share/cmake-3.7/Modules/CMakeSystemSpecificInformation.cmake

> - the CMake files added by *host* packages;
> 
> - the CMake files added by buildroot which talk about *target* packages.
> 
>  So I stand by my original statement: I think the cmake files should move from
> HOST/usr/share/buildroot to STAGING/usr/lib/cmake.

Still not convinced... ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'