[Buildroot] [PATCH 1/2] libnl: update homepage link

[Buildroot] [PATCH 1/2] libnl: update homepage link

[Baruch Siach]

The old link is broken. Use the github repo instead.

Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/libnl/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libnl/Config.in b/package/libnl/Config.in
index 46877c37a263..1e29f5740088 100644
--- a/package/libnl/Config.in
+++ b/package/libnl/Config.in
@@ -4,7 +4,7 @@ config BR2_PACKAGE_LIBNL
 	help
 	  A library for applications dealing with netlink socket.
 
-	  http://people.suug.ch/~tgr/libnl/
+	  https://github.com/thom311/libnl
 
 if BR2_PACKAGE_LIBNL
 
-- 
2.11.0

[Buildroot] [PATCH 2/2] libnl: bump to version 3.2.29

[Baruch Siach]

Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/libnl/libnl.hash | 4 ++--
 package/libnl/libnl.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/libnl/libnl.hash b/package/libnl/libnl.hash
index 2f1a3cb1b322..9761a9580cc9 100644
--- a/package/libnl/libnl.hash
+++ b/package/libnl/libnl.hash
@@ -1,2 +1,2 @@
-# From https://github.com/thom311/libnl/releases/download/libnl3_2_27/libnl-3.2.27.tar.gz.sha256sum
-sha256	4bbbf92b3c78a90f423cf96260bf419a28b75db8cced47051217a56795f58ec6	libnl-3.2.27.tar.gz
+# From https://github.com/thom311/libnl/releases/download/libnl3_2_29/libnl-3.2.29.tar.gz.sha256sum
+sha256	0beb593dc6abfffa18a5c787b27884979c1b7e7f1fd468c801e3cc938a685922	libnl-3.2.29.tar.gz
diff --git a/package/libnl/libnl.mk b/package/libnl/libnl.mk
index 85c0db86f6cd..d168885560d9 100644
--- a/package/libnl/libnl.mk
+++ b/package/libnl/libnl.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBNL_VERSION = 3.2.27
+LIBNL_VERSION = 3.2.29
 LIBNL_SITE = https://github.com/thom311/libnl/releases/download/libnl$(subst .,_,$(LIBNL_VERSION))
 LIBNL_LICENSE = LGPLv2.1+
 LIBNL_LICENSE_FILES = COPYING
-- 
2.11.0

[Buildroot] [PATCH 2/2] libnl: bump to version 3.2.29

[Gustavo Zacarias]

On 10/03/17 05:54, Baruch Siach wrote:

> -LIBNL_VERSION = 3.2.27
> +LIBNL_VERSION = 3.2.29

Hi Baruch.
Did you try with older headers?
Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x 
hence i refrained from bumping and carrying that dependency along a few 
packages.
Regards.

[Buildroot] [PATCH 2/2] libnl: bump to version 3.2.29

[Gustavo Zacarias]

On 10/03/17 06:56, Gustavo Zacarias wrote:

> On 10/03/17 05:54, Baruch Siach wrote:
>
>> -LIBNL_VERSION = 3.2.27
>> +LIBNL_VERSION = 3.2.29
>
> Hi Baruch.
> Did you try with older headers?
> Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x
> hence i refrained from bumping and carrying that dependency along a few
> packages.
> Regards.

That's kernel headers at least 3.2.x, coffee isn't it yet, sorry.
Regards.

[Buildroot] [PATCH 2/2] libnl: bump to version 3.2.29

[Baruch Siach]

Hi Gustavo,

On Fri, Mar 10, 2017 at 06:57:10AM -0300, Gustavo Zacarias wrote:
> On 10/03/17 06:56, Gustavo Zacarias wrote:
> > On 10/03/17 05:54, Baruch Siach wrote:
> > 
> > > -LIBNL_VERSION = 3.2.27
> > > +LIBNL_VERSION = 3.2.29
> > 
> > Did you try with older headers?
> > Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x
> > hence i refrained from bumping and carrying that dependency along a few
> > packages.
> 
> That's kernel headers at least 3.2.x, coffee isn't it yet, sorry.
> Regards.

Right. Build breaks with our 3.5 headers based CodeSourcery SH toolchain:

In file included from ../include/linux-private/linux/ipv6.h:5:0,
                 from ../include/netlink-private/netlink.h:55,
                 from addr.c:30:
.../output/host/usr/sh4a-buildroot-linux-gnu/sysroot/usr/include/linux/in6.h:30:8: error: redefinition of 'struct in6_addr'

[... many more errors of this type]

The x86_64 toolchain (also using 3.5 headers) is most likely also affected.

Have you investigated this issue any further? Do you know which libnl commit 
introduced it?

Adding kernel headers dependency to all reverse dependencies of libnl would 
not be nice. So unless we find an acceptable solution we'll have to revert 
this bump.

Thanks for your input.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH 2/2] libnl: bump to version 3.2.29

[Baruch Siach]

Hi Gustavo,

On Fri, Mar 10, 2017 at 12:34:07PM +0200, Baruch Siach wrote:
> On Fri, Mar 10, 2017 at 06:57:10AM -0300, Gustavo Zacarias wrote:
> > On 10/03/17 06:56, Gustavo Zacarias wrote:
> > > On 10/03/17 05:54, Baruch Siach wrote:
> > > 
> > > > -LIBNL_VERSION = 3.2.27
> > > > +LIBNL_VERSION = 3.2.29
> > > 
> > > Did you try with older headers?
> > > Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x
> > > hence i refrained from bumping and carrying that dependency along a few
> > > packages.
> > 
> > That's kernel headers at least 3.2.x, coffee isn't it yet, sorry.
> > Regards.
> 
> Right. Build breaks with our 3.5 headers based CodeSourcery SH toolchain:
> 
> In file included from ../include/linux-private/linux/ipv6.h:5:0,
>                  from ../include/netlink-private/netlink.h:55,
>                  from addr.c:30:
> .../output/host/usr/sh4a-buildroot-linux-gnu/sysroot/usr/include/linux/in6.h:30:8: error: redefinition of 'struct in6_addr'
> 
> [... many more errors of this type]
> 
> The x86_64 toolchain (also using 3.5 headers) is most likely also affected.

Adding in6.h and libc-compat.h from the libnl git repo to the tarball seems to 
fix this error. This has been fixed in upstream commit 6c7f4215003 ("build: 
distribute in.h in6.h libc-compat.h").

I don't have time for a proper patch at the moment, so either revert the bump 
and I'll send a revised version later, or create an equivalent patch to 
upstream fix.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH 2/2] libnl: bump to version 3.2.29

[Jeroen Roovers]

You can use this:

https://dev.gentoo.org/~jer/libnl-3.2.28-in6.patch.xz

On 10 March 2017 at 13:55, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Gustavo,
>
> On Fri, Mar 10, 2017 at 12:34:07PM +0200, Baruch Siach wrote:
>> On Fri, Mar 10, 2017 at 06:57:10AM -0300, Gustavo Zacarias wrote:
>> > On 10/03/17 06:56, Gustavo Zacarias wrote:
>> > > On 10/03/17 05:54, Baruch Siach wrote:
>> > >
>> > > > -LIBNL_VERSION = 3.2.27
>> > > > +LIBNL_VERSION = 3.2.29
>> > >
>> > > Did you try with older headers?
>> > > Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x
>> > > hence i refrained from bumping and carrying that dependency along a few
>> > > packages.
>> >
>> > That's kernel headers at least 3.2.x, coffee isn't it yet, sorry.
>> > Regards.
>>
>> Right. Build breaks with our 3.5 headers based CodeSourcery SH toolchain:
>>
>> In file included from ../include/linux-private/linux/ipv6.h:5:0,
>>                  from ../include/netlink-private/netlink.h:55,
>>                  from addr.c:30:
>> .../output/host/usr/sh4a-buildroot-linux-gnu/sysroot/usr/include/linux/in6.h:30:8: error: redefinition of 'struct in6_addr'
>>
>> [... many more errors of this type]
>>
>> The x86_64 toolchain (also using 3.5 headers) is most likely also affected.
>
> Adding in6.h and libc-compat.h from the libnl git repo to the tarball seems to
> fix this error. This has been fixed in upstream commit 6c7f4215003 ("build:
> distribute in.h in6.h libc-compat.h").
>
> I don't have time for a proper patch at the moment, so either revert the bump
> and I'll send a revised version later, or create an equivalent patch to
> upstream fix.
>
> baruch
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] libnl: bump to version 3.2.29

[Baruch Siach]

Hi Jeroen,

On Fri, Mar 10, 2017 at 02:05:52PM +0100, Jeroen Roovers wrote:
> You can use this:
> 
> https://dev.gentoo.org/~jer/libnl-3.2.28-in6.patch.xz

We'll probably need to add our local libc-compat.h workaround for musl like we 
have for iproute2 (commit bd9549610f3b), so this patch is most likely not 
enough as is.

Thanks,
baruch

> On 10 March 2017 at 13:55, Baruch Siach <baruch@tkos.co.il> wrote:
> > On Fri, Mar 10, 2017 at 12:34:07PM +0200, Baruch Siach wrote:
> >> On Fri, Mar 10, 2017 at 06:57:10AM -0300, Gustavo Zacarias wrote:
> >> > On 10/03/17 06:56, Gustavo Zacarias wrote:
> >> > > On 10/03/17 05:54, Baruch Siach wrote:
> >> > >
> >> > > > -LIBNL_VERSION = 3.2.27
> >> > > > +LIBNL_VERSION = 3.2.29
> >> > >
> >> > > Did you try with older headers?
> >> > > Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x
> >> > > hence i refrained from bumping and carrying that dependency along a few
> >> > > packages.
> >> >
> >> > That's kernel headers at least 3.2.x, coffee isn't it yet, sorry.
> >> > Regards.
> >>
> >> Right. Build breaks with our 3.5 headers based CodeSourcery SH toolchain:
> >>
> >> In file included from ../include/linux-private/linux/ipv6.h:5:0,
> >>                  from ../include/netlink-private/netlink.h:55,
> >>                  from addr.c:30:
> >> .../output/host/usr/sh4a-buildroot-linux-gnu/sysroot/usr/include/linux/in6.h:30:8: error: redefinition of 'struct in6_addr'
> >>
> >> [... many more errors of this type]
> >>
> >> The x86_64 toolchain (also using 3.5 headers) is most likely also affected.
> >
> > Adding in6.h and libc-compat.h from the libnl git repo to the tarball seems to
> > fix this error. This has been fixed in upstream commit 6c7f4215003 ("build:
> > distribute in.h in6.h libc-compat.h").
> >
> > I don't have time for a proper patch at the moment, so either revert the bump
> > and I'll send a revised version later, or create an equivalent patch to
> > upstream fix.

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH 2/2] libnl: bump to version 3.2.29

[Thomas Petazzoni]

Hello,

On Fri, 10 Mar 2017 06:56:00 -0300, Gustavo Zacarias wrote:

> Did you try with older headers?
> Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x 
> hence i refrained from bumping and carrying that dependency along a few 
> packages.

Thanks for this report. To avoid such bumps, it would be nice when you
realize a bump shouldn't be done for reason X, Y or Z, to send a patch
that adds a comment above the <pkg>_VERSION variable that indicates why
it shouldn't be bumped, or at least what the person doing the bump
should take care of :)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 2/2] libnl: bump to version 3.2.29

[Thomas Petazzoni]

Hello,

On Fri, 10 Mar 2017 10:54:44 +0200, Baruch Siach wrote:
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/libnl/libnl.hash | 4 ++--
>  package/libnl/libnl.mk   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

As discussed, I have reverted this commit, which causes too many
autobuilder issues.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] libnl: update homepage link

[Thomas Petazzoni]

Hello,

On Fri, 10 Mar 2017 10:54:43 +0200, Baruch Siach wrote:
> The old link is broken. Use the github repo instead.
> 
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/libnl/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Both applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com