[Buildroot] [PATCH 1/1] qt: add enable for truetype font installation

[Buildroot] [PATCH 1/1] qt: add enable for truetype font installation

[Danomi Manchego]

Currently, qt.mk installs DejaVu/Vera TrueType fonts if freetype
support is available, either from Qt or from the system freetype.
However, there are lots of fonts that can be used with Qt, both
within Qt (the prerendered fonts) and outside of Qt (in buildroot's
font area). So it seems appropriate to expose a switch to enable
the installation of the TrueType fonts, conditioned on freetype
availability. At least, it provides a similar level of selectability
as already exists with the prerendered fonts (micro, fixed, helvetica,
etc.), and in some cases may solve problems where setting fonts
by family and attribute is complicated by DejaVu competing with
fonts that were actually selected in the buildroot menu.

Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
 package/qt/Config.in | 8 ++++++++
 package/qt/qt.mk     | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/package/qt/Config.in b/package/qt/Config.in
index fa5235d..ac9cd18 100644
--- a/package/qt/Config.in
+++ b/package/qt/Config.in
@@ -185,6 +185,14 @@ endmenu
 
 menu "Fonts"
 
+config BR2_PACKAGE_QT_FONT_DEJAVU
+	bool "dejavu/vera"
+	depends on !BR2_PACKAGE_QT_NOFREETYPE
+	default y
+
+comment "dejavu/vera fonts need freetype support"
+	depends on BR2_PACKAGE_QT_NOFREETYPE
+
 config BR2_PACKAGE_QT_FONT_MICRO
 	bool "micro"
 	default y
diff --git a/package/qt/qt.mk b/package/qt/qt.mk
index 29dcc46..35f16b1 100644
--- a/package/qt/qt.mk
+++ b/package/qt/qt.mk
@@ -692,7 +692,7 @@ QT_LICENSE_FILES += src/3rdparty/fonts/COPYRIGHT.Unifont
 endif
 endif # QT_FONTS
 
-ifeq ($(BR2_PACKAGE_QT_QTFREETYPE)$(BR2_PACKAGE_QT_SYSTEMFREETYPE),y)
+ifeq ($(BR2_PACKAGE_QT_FONT_DEJAVU),y)
 define QT_INSTALL_TARGET_FONTS_TTF
 	mkdir -p $(TARGET_DIR)/usr/lib/fonts
 	cp -dpf $(STAGING_DIR)/usr/lib/fonts/*.ttf $(TARGET_DIR)/usr/lib/fonts
-- 
2.7.4

[Buildroot] [PATCH 1/1] qt: add enable for truetype font installation

[Peter Seiderer]

Hello Danomi,

On Wed,  8 Mar 2017 20:35:48 -0500, Danomi Manchego <danomimanchego123@gmail.com> wrote:

> Currently, qt.mk installs DejaVu/Vera TrueType fonts if freetype
> support is available, either from Qt or from the system freetype.
> However, there are lots of fonts that can be used with Qt, both
> within Qt (the prerendered fonts) and outside of Qt (in buildroot's
> font area). So it seems appropriate to expose a switch to enable
> the installation of the TrueType fonts, conditioned on freetype
> availability. At least, it provides a similar level of selectability
> as already exists with the prerendered fonts (micro, fixed, helvetica,
> etc.), and in some cases may solve problems where setting fonts
> by family and attribute is complicated by DejaVu competing with
> fonts that were actually selected in the buildroot menu.

Very detailed explanation for your reasoning, maybe stuff for a
cover-letter?

Maybe

Subject: qt: add truetype font installation option

Make truetype font installation optional.

is detailed enough?

> 
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> ---
>  package/qt/Config.in | 8 ++++++++
>  package/qt/qt.mk     | 2 +-
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index fa5235d..ac9cd18 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -185,6 +185,14 @@ endmenu
>  
>  menu "Fonts"
>  
> +config BR2_PACKAGE_QT_FONT_DEJAVU

BR2_PACKAGE_QT_FONT_DEJAVU is a little misnamer, better BR2_PACAKGE_QT_FONT_TRUETYPE ?
 
> +	bool "dejavu/vera"
> +	depends on !BR2_PACKAGE_QT_NOFREETYPE

I think this depends on does the right thing as the config
option is embedded into the BR2_PACKAGE_QT_EMBEDDED, but
I find

	depends on BR2_PACKAGE_QT_QTFREETYPE || BR2_PACKAGE_QT_SYSTEMFREETYPE

more readable...

Regards,
Peter

> +	default y
> +
> +comment "dejavu/vera fonts need freetype support"
> +	depends on BR2_PACKAGE_QT_NOFREETYPE
> +
>  config BR2_PACKAGE_QT_FONT_MICRO
>  	bool "micro"
>  	default y
> diff --git a/package/qt/qt.mk b/package/qt/qt.mk
> index 29dcc46..35f16b1 100644
> --- a/package/qt/qt.mk
> +++ b/package/qt/qt.mk
> @@ -692,7 +692,7 @@ QT_LICENSE_FILES += src/3rdparty/fonts/COPYRIGHT.Unifont
>  endif
>  endif # QT_FONTS
>  
> -ifeq ($(BR2_PACKAGE_QT_QTFREETYPE)$(BR2_PACKAGE_QT_SYSTEMFREETYPE),y)
> +ifeq ($(BR2_PACKAGE_QT_FONT_DEJAVU),y)
>  define QT_INSTALL_TARGET_FONTS_TTF
>  	mkdir -p $(TARGET_DIR)/usr/lib/fonts
>  	cp -dpf $(STAGING_DIR)/usr/lib/fonts/*.ttf $(TARGET_DIR)/usr/lib/fonts

[Buildroot] [PATCH 1/1] qt: add enable for truetype font installation

[Thomas Petazzoni]

Hello,

On Fri, 10 Mar 2017 19:43:27 +0100, Peter Seiderer wrote:

> On Wed,  8 Mar 2017 20:35:48 -0500, Danomi Manchego <danomimanchego123@gmail.com> wrote:
> 
> > Currently, qt.mk installs DejaVu/Vera TrueType fonts if freetype
> > support is available, either from Qt or from the system freetype.
> > However, there are lots of fonts that can be used with Qt, both
> > within Qt (the prerendered fonts) and outside of Qt (in buildroot's
> > font area). So it seems appropriate to expose a switch to enable
> > the installation of the TrueType fonts, conditioned on freetype
> > availability. At least, it provides a similar level of selectability
> > as already exists with the prerendered fonts (micro, fixed, helvetica,
> > etc.), and in some cases may solve problems where setting fonts
> > by family and attribute is complicated by DejaVu competing with
> > fonts that were actually selected in the buildroot menu.  
> 
> Very detailed explanation for your reasoning, maybe stuff for a
> cover-letter?

I really disagree with this. The contents of cover letters disappear
in the dark caves of the mailing list archives, while commit logs can
very easily be found when looking at the history of the changes on a
package. So I very, very much prefer to have detailed commit logs
rather than everything in the cover letter and very terse commit logs.

I've seen the v2 of Danomi, and now I'm like "why do we want this?".

> Subject: qt: add truetype font installation option
> 
> Make truetype font installation optional.
> 
> is detailed enough?

No, it's not :)

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] qt: add enable for truetype font installation

[Danomi Manchego]

On Tue, Mar 14, 2017 at 5:58 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri, 10 Mar 2017 19:43:27 +0100, Peter Seiderer wrote:
>
>> On Wed,  8 Mar 2017 20:35:48 -0500, Danomi Manchego <danomimanchego123@gmail.com> wrote:
>>
>> > Currently, qt.mk installs DejaVu/Vera TrueType fonts if freetype
>> > support is available, either from Qt or from the system freetype.
>> > However, there are lots of fonts that can be used with Qt, both
>> > within Qt (the prerendered fonts) and outside of Qt (in buildroot's
>> > font area). So it seems appropriate to expose a switch to enable
>> > the installation of the TrueType fonts, conditioned on freetype
>> > availability. At least, it provides a similar level of selectability
>> > as already exists with the prerendered fonts (micro, fixed, helvetica,
>> > etc.), and in some cases may solve problems where setting fonts
>> > by family and attribute is complicated by DejaVu competing with
>> > fonts that were actually selected in the buildroot menu.
>>
>> Very detailed explanation for your reasoning, maybe stuff for a
>> cover-letter?
>
> I really disagree with this. The contents of cover letters disappear
> in the dark caves of the mailing list archives, while commit logs can
> very easily be found when looking at the history of the changes on a
> package. So I very, very much prefer to have detailed commit logs
> rather than everything in the cover letter and very terse commit logs.

I'm inclined to agree, but I'm told that I'm long-winded sometimes, so
I deferred to Peter.  I'll spin a v3 with a tweaked comment.

Danomi -


> I've seen the v2 of Danomi, and now I'm like "why do we want this?".
>
>> Subject: qt: add truetype font installation option
>>
>> Make truetype font installation optional.
>>
>> is detailed enough?
>
> No, it's not :)
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com