* [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins
@ 2017-03-21 16:02 Andy Shevchenko
2017-03-21 16:02 ` [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality Andy Shevchenko
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Andy Shevchenko @ 2017-03-21 16:02 UTC (permalink / raw)
To: buildroot
Disregard to increase just minor version BlueZ 5.44 is drastically different in
a way what tools and plugins are enabled and installed by default.
Extend Buildroot package to cover these changes.
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
package/bluez5_utils/Config.in | 28 +++++++++++++++++++++++++++-
package/bluez5_utils/bluez5_utils.mk | 36 ++++++++++++++++++++++++++++++++++++
2 files changed, 63 insertions(+), 1 deletion(-)
diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
index a7c0ee4ba..e99f0f69f 100644
--- a/package/bluez5_utils/Config.in
+++ b/package/bluez5_utils/Config.in
@@ -48,6 +48,11 @@ config BR2_PACKAGE_BLUEZ5_UTILS_CLIENT
comment "bluez5-utils client needs a glibc or musl toolchain"
depends on BR2_TOOLCHAIN_USES_UCLIBC
+config BR2_PACKAGE_BLUEZ5_UTILS_DEPRECATED
+ bool "build deprecated tools"
+ help
+ Build BlueZ 5.x deprecated tools (hciattach, gatttool, ...).
+
config BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL
bool "install GATT tool"
depends on BR2_PACKAGE_BLUEZ5_UTILS_CLIENT
@@ -62,7 +67,28 @@ config BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL
config BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL
bool "build experimental plugins"
help
- Build BlueZ 5.x experimental plugins (SAP, NFC, ...).
+ Build BlueZ 5.x experimental plugins (PCSuite, ...).
+
+config BR2_PACKAGE_BLUEZ5_PLUGINS_HEALTH
+ bool "build health plugin"
+ help
+ Build BlueZ 5.x health plugin
+
+config BR2_PACKAGE_BLUEZ5_PLUGINS_MIDI
+ bool "build midi plugin"
+ select BR2_PACKAGE_ALSA_LIB
+ help
+ Build BlueZ 5.x midi plugin
+
+config BR2_PACKAGE_BLUEZ5_PLUGINS_NFC
+ bool "build nfc plugin"
+ help
+ Build BlueZ 5.x nfc plugin
+
+config BR2_PACKAGE_BLUEZ5_PLUGINS_SAP
+ bool "build sap plugin"
+ help
+ Build BlueZ 5.x sap plugin
config BR2_PACKAGE_BLUEZ5_PLUGINS_SIXAXIS
bool "build sixaxis plugin"
diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
index 4d31a187b..4eae3d01d 100644
--- a/package/bluez5_utils/bluez5_utils.mk
+++ b/package/bluez5_utils/bluez5_utils.mk
@@ -38,6 +38,35 @@ else
BLUEZ5_UTILS_CONF_OPTS += --disable-experimental
endif
+# enable health plugin
+ifeq ($(BR2_PACKAGE_BLUEZ5_PLUGINS_HEALTH),y)
+BLUEZ5_UTILS_CONF_OPTS += --enable-health
+else
+BLUEZ5_UTILS_CONF_OPTS += --disable-health
+endif
+
+# enable midi plugin
+ifeq ($(BR2_PACKAGE_BLUEZ5_PLUGINS_MIDI),y)
+BLUEZ5_UTILS_CONF_OPTS += --enable-midi
+BLUEZ5_UTILS_DEPENDENCIES += alsa-lib
+else
+BLUEZ5_UTILS_CONF_OPTS += --disable-midi
+endif
+
+# enable nfc plugin
+ifeq ($(BR2_PACKAGE_BLUEZ5_PLUGINS_NFC),y)
+BLUEZ5_UTILS_CONF_OPTS += --enable-nfc
+else
+BLUEZ5_UTILS_CONF_OPTS += --disable-nfc
+endif
+
+# enable sap plugin
+ifeq ($(BR2_PACKAGE_BLUEZ5_PLUGINS_SAP),y)
+BLUEZ5_UTILS_CONF_OPTS += --enable-sap
+else
+BLUEZ5_UTILS_CONF_OPTS += --disable-sap
+endif
+
# enable sixaxis plugin
ifeq ($(BR2_PACKAGE_BLUEZ5_PLUGINS_SIXAXIS),y)
BLUEZ5_UTILS_CONF_OPTS += --enable-sixaxis
@@ -45,6 +74,13 @@ else
BLUEZ5_UTILS_CONF_OPTS += --disable-sixaxis
endif
+# build deprecated tools
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_DEPRECATED),y)
+BLUEZ5_UTILS_CONF_OPTS += --enable-deprecated
+else
+BLUEZ5_UTILS_CONF_OPTS += --disable-deprecated
+endif
+
# install gatttool (For some reason upstream choose not to do it by default)
ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL),y)
define BLUEZ5_UTILS_INSTALL_GATTTOOL
--
2.11.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality
2017-03-21 16:02 [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins Andy Shevchenko
@ 2017-03-21 16:02 ` Andy Shevchenko
2017-03-21 16:06 ` Thomas Petazzoni
` (3 more replies)
2017-03-21 16:02 ` [Buildroot] [PATCH v2] Revert "bluez5_utils: not available with uClibc" Andy Shevchenko
2017-03-21 17:01 ` [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins Peter Korsgaard
2 siblings, 4 replies; 15+ messages in thread
From: Andy Shevchenko @ 2017-03-21 16:02 UTC (permalink / raw)
To: buildroot
The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc")
disables bluez5_utils (most of them) to be built with uClibc. Looking to
the development of BlueZ user space support that commit basically makes
the bluez5_utils package somewhat piece of junk. Since bluez5_utils 5.44
deprecates all previously used tools and focuses on btmgmt and
bluetoothctl we need to restore status quo.
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
package/uclibc/uClibc-ng.config | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/uclibc/uClibc-ng.config b/package/uclibc/uClibc-ng.config
index 528bce965..91082975e 100644
--- a/package/uclibc/uClibc-ng.config
+++ b/package/uclibc/uClibc-ng.config
@@ -32,6 +32,7 @@ UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y
UCLIBC_HAS_PRINTF_M_SPEC=y
# UCLIBC_HAS_REGEX_OLD is not set
# UCLIBC_HAS_FNMATCH_OLD is not set
+UCLIBC_HAS_WORDEXP=y
UCLIBC_HAS_NFTW=y
UCLIBC_HAS_FTW=y
UCLIBC_HAS_GNU_GLOB=y
--
2.11.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] Revert "bluez5_utils: not available with uClibc"
2017-03-21 16:02 [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins Andy Shevchenko
2017-03-21 16:02 ` [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality Andy Shevchenko
@ 2017-03-21 16:02 ` Andy Shevchenko
2017-03-21 17:01 ` [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins Peter Korsgaard
2 siblings, 0 replies; 15+ messages in thread
From: Andy Shevchenko @ 2017-03-21 16:02 UTC (permalink / raw)
To: buildroot
Since uClibc supports wordexp functionality we may revert
the commit d7c54cb0c0cf.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
package/bluez5_utils/Config.in | 5 -----
1 file changed, 5 deletions(-)
diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
index e99f0f69f..315747592 100644
--- a/package/bluez5_utils/Config.in
+++ b/package/bluez5_utils/Config.in
@@ -39,15 +39,10 @@ comment "OBEX support needs a toolchain w/ C++"
config BR2_PACKAGE_BLUEZ5_UTILS_CLIENT
bool "build CLI client"
- # wordexp support not in our uClibc configuration
- depends on !BR2_TOOLCHAIN_USES_UCLIBC
select BR2_PACKAGE_READLINE
help
Enable the Bluez 5.x command line client.
-comment "bluez5-utils client needs a glibc or musl toolchain"
- depends on BR2_TOOLCHAIN_USES_UCLIBC
-
config BR2_PACKAGE_BLUEZ5_UTILS_DEPRECATED
bool "build deprecated tools"
help
--
2.11.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality
2017-03-21 16:02 ` [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality Andy Shevchenko
@ 2017-03-21 16:06 ` Thomas Petazzoni
2017-03-21 16:11 ` Andy Shevchenko
2017-04-09 4:32 ` Waldemar Brodkorb
2017-03-21 19:53 ` Waldemar Brodkorb
` (2 subsequent siblings)
3 siblings, 2 replies; 15+ messages in thread
From: Thomas Petazzoni @ 2017-03-21 16:06 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 21 Mar 2017 18:02:36 +0200, Andy Shevchenko wrote:
> The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc")
> disables bluez5_utils (most of them) to be built with uClibc. Looking to
> the development of BlueZ user space support that commit basically makes
> the bluez5_utils package somewhat piece of junk.
Not sure I understand what you mean here.
> Since bluez5_utils 5.44
> deprecates all previously used tools and focuses on btmgmt and
> bluetoothctl we need to restore status quo.
Same here, I don't understand.
> diff --git a/package/uclibc/uClibc-ng.config b/package/uclibc/uClibc-ng.config
> index 528bce965..91082975e 100644
> --- a/package/uclibc/uClibc-ng.config
> +++ b/package/uclibc/uClibc-ng.config
> @@ -32,6 +32,7 @@ UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y
> UCLIBC_HAS_PRINTF_M_SPEC=y
> # UCLIBC_HAS_REGEX_OLD is not set
> # UCLIBC_HAS_FNMATCH_OLD is not set
> +UCLIBC_HAS_WORDEXP=y
> UCLIBC_HAS_NFTW=y
> UCLIBC_HAS_FTW=y
> UCLIBC_HAS_GNU_GLOB=y
Could you comment on the size impact of enabling this option? I.e the
size of uClibc without/with this option enabled, for example on ARM?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality
2017-03-21 16:06 ` Thomas Petazzoni
@ 2017-03-21 16:11 ` Andy Shevchenko
2017-03-21 16:17 ` Thomas Petazzoni
2017-03-21 16:28 ` Baruch Siach
2017-04-09 4:32 ` Waldemar Brodkorb
1 sibling, 2 replies; 15+ messages in thread
From: Andy Shevchenko @ 2017-03-21 16:11 UTC (permalink / raw)
To: buildroot
On Tue, 2017-03-21 at 17:06 +0100, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 21 Mar 2017 18:02:36 +0200, Andy Shevchenko wrote:
>
> > The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc")
> > disables bluez5_utils (most of them) to be built with uClibc.
> > Looking to
> > the development of BlueZ user space support that commit basically
> > makes
> > the bluez5_utils package somewhat piece of junk.
>
> Not sure I understand what you mean here.
Without new tools like bluetoothctl it's impossible to use Bluetooth
modules, such as BCM43341 based.
hcitool, hciattach, hciconfig, etc (see the list under DEPRECATED in
Makefile.tools in bluez5_utils sources) does *not* work with it.
> > Since bluez5_utils 5.44
> > deprecates all previously used tools and focuses on btmgmt and
> > bluetoothctl we need to restore status quo.
>
> Same here, I don't understand.
See above.
>
> > diff --git a/package/uclibc/uClibc-ng.config
> > b/package/uclibc/uClibc-ng.config
> > index 528bce965..91082975e 100644
> > --- a/package/uclibc/uClibc-ng.config
> > +++ b/package/uclibc/uClibc-ng.config
> > @@ -32,6 +32,7 @@ UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y
> > ?UCLIBC_HAS_PRINTF_M_SPEC=y
> > ?# UCLIBC_HAS_REGEX_OLD is not set
> > ?# UCLIBC_HAS_FNMATCH_OLD is not set
> > +UCLIBC_HAS_WORDEXP=y
> > ?UCLIBC_HAS_NFTW=y
> > ?UCLIBC_HAS_FTW=y
> > ?UCLIBC_HAS_GNU_GLOB=y
>
> Could you comment on the size impact of enabling this option?
I can do it (on x86).
> I.e the
> size of uClibc without/with this option enabled, for example on ARM?
No, I have no ARM board to test this. Or you mean to built entire stack
what I'm using for some arbitrary ARM board?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality
2017-03-21 16:11 ` Andy Shevchenko
@ 2017-03-21 16:17 ` Thomas Petazzoni
2017-03-21 16:23 ` Andy Shevchenko
2017-03-21 16:28 ` Baruch Siach
1 sibling, 1 reply; 15+ messages in thread
From: Thomas Petazzoni @ 2017-03-21 16:17 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 21 Mar 2017 18:11:48 +0200, Andy Shevchenko wrote:
> > I.e the
> > size of uClibc without/with this option enabled, for example on ARM?
>
> No, I have no ARM board to test this. Or you mean to built entire stack
> what I'm using for some arbitrary ARM board?
You don't need a ARM board. Just make a Buildroot build for ARM with
uClibc (wordexp disabled), look at the uClibc size, and then the same
build but this time with your patch applied (which enables wordexp).
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality
2017-03-21 16:17 ` Thomas Petazzoni
@ 2017-03-21 16:23 ` Andy Shevchenko
0 siblings, 0 replies; 15+ messages in thread
From: Andy Shevchenko @ 2017-03-21 16:23 UTC (permalink / raw)
To: buildroot
On Tue, 2017-03-21 at 17:17 +0100, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 21 Mar 2017 18:11:48 +0200, Andy Shevchenko wrote:
>
> > > ?I.e the
> > > size of uClibc without/with this option enabled, for example on
> > > ARM???
> >
> > No, I have no ARM board to test this. Or you mean to built entire
> > stack
> > what I'm using for some arbitrary ARM board?
>
> You don't need a ARM board. Just make a Buildroot build for ARM with
> uClibc (wordexp disabled), look at the uClibc size, and then the same
> build but this time with your patch applied (which enables wordexp).
Got it.
Will do when will have time later this week.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality
2017-03-21 16:11 ` Andy Shevchenko
2017-03-21 16:17 ` Thomas Petazzoni
@ 2017-03-21 16:28 ` Baruch Siach
1 sibling, 0 replies; 15+ messages in thread
From: Baruch Siach @ 2017-03-21 16:28 UTC (permalink / raw)
To: buildroot
Hi Andy,
On Tue, Mar 21, 2017 at 06:11:48PM +0200, Andy Shevchenko wrote:
> On Tue, 2017-03-21 at 17:06 +0100, Thomas Petazzoni wrote:
> > On Tue, 21 Mar 2017 18:02:36 +0200, Andy Shevchenko wrote:
> > > The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc")
> > > disables bluez5_utils (most of them) to be built with uClibc.
> > > Looking to
> > > the development of BlueZ user space support that commit basically
> > > makes
> > > the bluez5_utils package somewhat piece of junk.
> >
> > Not sure I understand what you mean here.
>
> Without new tools like bluetoothctl it's impossible to use Bluetooth
> modules, such as BCM43341 based.
This is a UART attached device, isn't it?
> hcitool, hciattach, hciconfig, etc (see the list under DEPRECATED in
> Makefile.tools in bluez5_utils sources) does *not* work with it.
How do you bind the driver to the UART device without hciattach?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins
2017-03-21 16:02 [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins Andy Shevchenko
2017-03-21 16:02 ` [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality Andy Shevchenko
2017-03-21 16:02 ` [Buildroot] [PATCH v2] Revert "bluez5_utils: not available with uClibc" Andy Shevchenko
@ 2017-03-21 17:01 ` Peter Korsgaard
2017-03-21 17:06 ` Andy Shevchenko
2 siblings, 1 reply; 15+ messages in thread
From: Peter Korsgaard @ 2017-03-21 17:01 UTC (permalink / raw)
To: buildroot
>>>>> "Andy" == Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> Disregard to increase just minor version BlueZ 5.44 is drastically different in
> a way what tools and plugins are enabled and installed by default.
> Extend Buildroot package to cover these changes.
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> package/bluez5_utils/Config.in | 28 +++++++++++++++++++++++++++-
> package/bluez5_utils/bluez5_utils.mk | 36 ++++++++++++++++++++++++++++++++++++
> 2 files changed, 63 insertions(+), 1 deletion(-)
> diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
> index a7c0ee4ba..e99f0f69f 100644
> --- a/package/bluez5_utils/Config.in
> +++ b/package/bluez5_utils/Config.in
> @@ -48,6 +48,11 @@ config BR2_PACKAGE_BLUEZ5_UTILS_CLIENT
> comment "bluez5-utils client needs a glibc or musl toolchain"
> depends on BR2_TOOLCHAIN_USES_UCLIBC
> +config BR2_PACKAGE_BLUEZ5_UTILS_DEPRECATED
> + bool "build deprecated tools"
> + help
> + Build BlueZ 5.x deprecated tools (hciattach, gatttool, ...).
> +
> config BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL
> bool "install GATT tool"
> depends on BR2_PACKAGE_BLUEZ5_UTILS_CLIENT
Then _UTILS_GATTTOOL should depend on _UTILS_DEPRECATED. Or perhaps it
doesn't make sense to have a dedicated option for this and it should
just be automatically installed when deprecated is enabled.
It would also be good to add the autobuilder failures:
http://autobuild.buildroot.net/?reason=bluez5_utils-5.44
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins
2017-03-21 17:01 ` [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins Peter Korsgaard
@ 2017-03-21 17:06 ` Andy Shevchenko
0 siblings, 0 replies; 15+ messages in thread
From: Andy Shevchenko @ 2017-03-21 17:06 UTC (permalink / raw)
To: buildroot
On Tue, 2017-03-21 at 18:01 +0100, Peter Korsgaard wrote:
> ?> +config BR2_PACKAGE_BLUEZ5_UTILS_DEPRECATED
> ?> + bool "build deprecated tools"
> ?> + help
> ?> + ??Build BlueZ 5.x deprecated tools (hciattach, gatttool,
> ...).
> ?> +
> ?>??config BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL
> ?>?? bool "install GATT tool"
> ?>?? depends on BR2_PACKAGE_BLUEZ5_UTILS_CLIENT
>
> Then _UTILS_GATTTOOL should depend on _UTILS_DEPRECATED.
There is a patch flying around (from Bernd) to fix build and add --
enable-deprecated to GATTTOOL in bluez5_utils.mk.
> Or perhaps it
> doesn't make sense to have a dedicated option for this and it should
> just be automatically installed when deprecated is enabled.
Note, gatttool is left in noinst list, meaning the option should be
still here.
> It would also be good to add the autobuilder failures:
>
> http://autobuild.buildroot.net/?reason=bluez5_utils-5.44
Makes sense.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality
2017-03-21 16:02 ` [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality Andy Shevchenko
2017-03-21 16:06 ` Thomas Petazzoni
@ 2017-03-21 19:53 ` Waldemar Brodkorb
2017-04-16 14:29 ` Waldemar Brodkorb
2017-04-29 12:26 ` Thomas Petazzoni
3 siblings, 0 replies; 15+ messages in thread
From: Waldemar Brodkorb @ 2017-03-21 19:53 UTC (permalink / raw)
To: buildroot
Hi,
Andy Shevchenko wrote,
> The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc")
> disables bluez5_utils (most of them) to be built with uClibc. Looking to
> the development of BlueZ user space support that commit basically makes
> the bluez5_utils package somewhat piece of junk. Since bluez5_utils 5.44
> deprecates all previously used tools and focuses on btmgmt and
> bluetoothctl we need to restore status quo.
You can add my Acked-By. It will allow to use more applications and
I think it is just a minor size increase.
Looking forward to your size comparison requested by Thomas,
Thanks
Waldemar
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality
2017-03-21 16:06 ` Thomas Petazzoni
2017-03-21 16:11 ` Andy Shevchenko
@ 2017-04-09 4:32 ` Waldemar Brodkorb
2017-04-09 7:42 ` Thomas Petazzoni
1 sibling, 1 reply; 15+ messages in thread
From: Waldemar Brodkorb @ 2017-04-09 4:32 UTC (permalink / raw)
To: buildroot
Hi,
Thomas Petazzoni wrote,
> Hello,
>
> On Tue, 21 Mar 2017 18:02:36 +0200, Andy Shevchenko wrote:
>
> > The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc")
> > disables bluez5_utils (most of them) to be built with uClibc. Looking to
> > the development of BlueZ user space support that commit basically makes
> > the bluez5_utils package somewhat piece of junk.
>
> Not sure I understand what you mean here.
>
> > Since bluez5_utils 5.44
> > deprecates all previously used tools and focuses on btmgmt and
> > bluetoothctl we need to restore status quo.
>
> Same here, I don't understand.
>
> > diff --git a/package/uclibc/uClibc-ng.config b/package/uclibc/uClibc-ng.config
> > index 528bce965..91082975e 100644
> > --- a/package/uclibc/uClibc-ng.config
> > +++ b/package/uclibc/uClibc-ng.config
> > @@ -32,6 +32,7 @@ UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y
> > UCLIBC_HAS_PRINTF_M_SPEC=y
> > # UCLIBC_HAS_REGEX_OLD is not set
> > # UCLIBC_HAS_FNMATCH_OLD is not set
> > +UCLIBC_HAS_WORDEXP=y
> > UCLIBC_HAS_NFTW=y
> > UCLIBC_HAS_FTW=y
> > UCLIBC_HAS_GNU_GLOB=y
>
> Could you comment on the size impact of enabling this option? I.e the
> size of uClibc without/with this option enabled, for example on ARM?
For mips64:
diff --git a/package/uclibc/uClibc-ng.config
b/package/uclibc/uClibc-ng.config
index 528bce9..9108297 100644
--- a/package/uclibc/uClibc-ng.config
+++ b/package/uclibc/uClibc-ng.config
@@ -32,6 +32,7 @@ UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y
UCLIBC_HAS_PRINTF_M_SPEC=y
# UCLIBC_HAS_REGEX_OLD is not set
# UCLIBC_HAS_FNMATCH_OLD is not set
+UCLIBC_HAS_WORDEXP=y
UCLIBC_HAS_NFTW=y
UCLIBC_HAS_FTW=y
UCLIBC_HAS_GNU_GLOB=y
wbx at helium:~/buildroot$ ls -la t1/lib/libu*
-rwxr-xr-x 1 wbx wbx 655320 Apr 8 22:00 t1/lib/libuClibc-1.0.23.so
wbx at helium:~/buildroot$ ls -la t2/lib/libu*
-rwxr-xr-x 1 wbx wbx 672280 Apr 8 23:08 t2/lib/libuClibc-1.0.23.so
wbx at helium:~/buildroot$ bc
bc 1.06.95
Copyright 1991-1994, 1997, 1998, 2000, 2004, 2006 Free Software
Foundation, Inc.
This is free software with ABSOLUTELY NO WARRANTY.
For details type `warranty'.
672280-655320
16960
16960 Bytes. Can we enable it by default?
best regards
Waldemar
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality
2017-04-09 4:32 ` Waldemar Brodkorb
@ 2017-04-09 7:42 ` Thomas Petazzoni
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Petazzoni @ 2017-04-09 7:42 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 9 Apr 2017 06:32:15 +0200, Waldemar Brodkorb wrote:
> 16960 Bytes. Can we enable it by default?
I'd say yes.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality
2017-03-21 16:02 ` [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality Andy Shevchenko
2017-03-21 16:06 ` Thomas Petazzoni
2017-03-21 19:53 ` Waldemar Brodkorb
@ 2017-04-16 14:29 ` Waldemar Brodkorb
2017-04-29 12:26 ` Thomas Petazzoni
3 siblings, 0 replies; 15+ messages in thread
From: Waldemar Brodkorb @ 2017-04-16 14:29 UTC (permalink / raw)
To: buildroot
Hi,
Andy Shevchenko wrote,
> The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc")
> disables bluez5_utils (most of them) to be built with uClibc. Looking to
> the development of BlueZ user space support that commit basically makes
> the bluez5_utils package somewhat piece of junk. Since bluez5_utils 5.44
> deprecates all previously used tools and focuses on btmgmt and
> bluetoothctl we need to restore status quo.
>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> package/uclibc/uClibc-ng.config | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/uclibc/uClibc-ng.config b/package/uclibc/uClibc-ng.config
> index 528bce965..91082975e 100644
> --- a/package/uclibc/uClibc-ng.config
> +++ b/package/uclibc/uClibc-ng.config
> @@ -32,6 +32,7 @@ UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y
> UCLIBC_HAS_PRINTF_M_SPEC=y
> # UCLIBC_HAS_REGEX_OLD is not set
> # UCLIBC_HAS_FNMATCH_OLD is not set
> +UCLIBC_HAS_WORDEXP=y
> UCLIBC_HAS_NFTW=y
> UCLIBC_HAS_FTW=y
> UCLIBC_HAS_GNU_GLOB=y
Acked-by: Waldemar Brodkorb <wbx@openadk.org>
I would like to see it included.
best regards
Waldemar
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality
2017-03-21 16:02 ` [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality Andy Shevchenko
` (2 preceding siblings ...)
2017-04-16 14:29 ` Waldemar Brodkorb
@ 2017-04-29 12:26 ` Thomas Petazzoni
3 siblings, 0 replies; 15+ messages in thread
From: Thomas Petazzoni @ 2017-04-29 12:26 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 21 Mar 2017 18:02:36 +0200, Andy Shevchenko wrote:
> The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc")
> disables bluez5_utils (most of them) to be built with uClibc. Looking to
> the development of BlueZ user space support that commit basically makes
> the bluez5_utils package somewhat piece of junk. Since bluez5_utils 5.44
> deprecates all previously used tools and focuses on btmgmt and
> bluetoothctl we need to restore status quo.
>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> package/uclibc/uClibc-ng.config | 1 +
> 1 file changed, 1 insertion(+)
I've applied, after rewriting the commit message. If there's some
bluez5_utils improvements that can be done now that wordexp is enabled,
please send patches. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2017-04-29 12:26 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-21 16:02 [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins Andy Shevchenko
2017-03-21 16:02 ` [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality Andy Shevchenko
2017-03-21 16:06 ` Thomas Petazzoni
2017-03-21 16:11 ` Andy Shevchenko
2017-03-21 16:17 ` Thomas Petazzoni
2017-03-21 16:23 ` Andy Shevchenko
2017-03-21 16:28 ` Baruch Siach
2017-04-09 4:32 ` Waldemar Brodkorb
2017-04-09 7:42 ` Thomas Petazzoni
2017-03-21 19:53 ` Waldemar Brodkorb
2017-04-16 14:29 ` Waldemar Brodkorb
2017-04-29 12:26 ` Thomas Petazzoni
2017-03-21 16:02 ` [Buildroot] [PATCH v2] Revert "bluez5_utils: not available with uClibc" Andy Shevchenko
2017-03-21 17:01 ` [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins Peter Korsgaard
2017-03-21 17:06 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox