* [Buildroot] [PATCH] package/libunwind: simplify architectutre dependencies
@ 2017-04-17 16:44 Yann E. MORIN
2017-04-17 16:50 ` Romain Naour
2017-05-04 21:22 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Yann E. MORIN @ 2017-04-17 16:44 UTC (permalink / raw)
To: buildroot
BR2_ARM_CPU_HAS_ARM already embeddeds the fact that this is an ARM chip,
so (BR2_arm || BR2_armeb) is forcibly true when BR2_ARM_CPU_HAS_ARM is.
In other words, BR2_ARM_CPU_HAS_ARM can't be true unless either BR2_arm
or BR2_armeb itslef is true.
Simplify the logic accordingly.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Romain Naour <romain.naour@openwide.fr>
---
package/libunwind/Config.in | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/package/libunwind/Config.in b/package/libunwind/Config.in
index 9007ce51c2..2003e96518 100644
--- a/package/libunwind/Config.in
+++ b/package/libunwind/Config.in
@@ -10,16 +10,13 @@
config BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS
bool
default y if BR2_TOOLCHAIN_USES_GLIBC && \
- (((BR2_arm || BR2_armeb) && BR2_ARM_CPU_HAS_ARM) || \
- BR2_mips || BR2_mipsel || BR2_mips64 || \
+ (BR2_ARM_CPU_HAS_ARM || BR2_mips || BR2_mipsel || BR2_mips64 || \
BR2_mips64el || BR2_powerpc || BR2_sh || BR2_i386 || BR2_x86_64)
default y if BR2_TOOLCHAIN_USES_UCLIBC && \
- (((BR2_arm || BR2_armeb) && BR2_ARM_CPU_HAS_ARM) || \
- BR2_mips || BR2_mipsel || \
+ (BR2_ARM_CPU_HAS_ARM || BR2_mips || BR2_mipsel || \
BR2_mips64 || BR2_mips64el || BR2_x86_64)
default y if BR2_TOOLCHAIN_USES_MUSL && \
- (((BR2_arm || BR2_armeb) && BR2_ARM_CPU_HAS_ARM) || \
- BR2_i386 || BR2_x86_64)
+ (BR2_ARM_CPU_HAS_ARM || BR2_i386 || BR2_x86_64)
config BR2_PACKAGE_LIBUNWIND
bool "libunwind"
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/libunwind: simplify architectutre dependencies
2017-04-17 16:44 [Buildroot] [PATCH] package/libunwind: simplify architectutre dependencies Yann E. MORIN
@ 2017-04-17 16:50 ` Romain Naour
2017-05-04 21:22 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Romain Naour @ 2017-04-17 16:50 UTC (permalink / raw)
To: buildroot
Hi Yann, All,
Le 17/04/2017 ? 18:44, Yann E. MORIN a ?crit :
> BR2_ARM_CPU_HAS_ARM already embeddeds the fact that this is an ARM chip,
> so (BR2_arm || BR2_armeb) is forcibly true when BR2_ARM_CPU_HAS_ARM is.
>
> In other words, BR2_ARM_CPU_HAS_ARM can't be true unless either BR2_arm
> or BR2_armeb itslef is true.
>
> Simplify the logic accordingly.
The same simplification can be done in package/boost/Config.in.
Acked-by: Romain Naour <romain.naour@gmail.com>
Best regards,
Romain
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Romain Naour <romain.naour@openwide.fr>
> ---
> package/libunwind/Config.in | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/package/libunwind/Config.in b/package/libunwind/Config.in
> index 9007ce51c2..2003e96518 100644
> --- a/package/libunwind/Config.in
> +++ b/package/libunwind/Config.in
> @@ -10,16 +10,13 @@
> config BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS
> bool
> default y if BR2_TOOLCHAIN_USES_GLIBC && \
> - (((BR2_arm || BR2_armeb) && BR2_ARM_CPU_HAS_ARM) || \
> - BR2_mips || BR2_mipsel || BR2_mips64 || \
> + (BR2_ARM_CPU_HAS_ARM || BR2_mips || BR2_mipsel || BR2_mips64 || \
> BR2_mips64el || BR2_powerpc || BR2_sh || BR2_i386 || BR2_x86_64)
> default y if BR2_TOOLCHAIN_USES_UCLIBC && \
> - (((BR2_arm || BR2_armeb) && BR2_ARM_CPU_HAS_ARM) || \
> - BR2_mips || BR2_mipsel || \
> + (BR2_ARM_CPU_HAS_ARM || BR2_mips || BR2_mipsel || \
> BR2_mips64 || BR2_mips64el || BR2_x86_64)
> default y if BR2_TOOLCHAIN_USES_MUSL && \
> - (((BR2_arm || BR2_armeb) && BR2_ARM_CPU_HAS_ARM) || \
> - BR2_i386 || BR2_x86_64)
> + (BR2_ARM_CPU_HAS_ARM || BR2_i386 || BR2_x86_64)
>
> config BR2_PACKAGE_LIBUNWIND
> bool "libunwind"
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/libunwind: simplify architectutre dependencies
2017-04-17 16:44 [Buildroot] [PATCH] package/libunwind: simplify architectutre dependencies Yann E. MORIN
2017-04-17 16:50 ` Romain Naour
@ 2017-05-04 21:22 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2017-05-04 21:22 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 17 Apr 2017 18:44:01 +0200, Yann E. MORIN wrote:
> BR2_ARM_CPU_HAS_ARM already embeddeds the fact that this is an ARM chip,
> so (BR2_arm || BR2_armeb) is forcibly true when BR2_ARM_CPU_HAS_ARM is.
>
> In other words, BR2_ARM_CPU_HAS_ARM can't be true unless either BR2_arm
> or BR2_armeb itslef is true.
>
> Simplify the logic accordingly.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Romain Naour <romain.naour@openwide.fr>
> ---
> package/libunwind/Config.in | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Applied to master, after fixing the typo in the commit title. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-04 21:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-17 16:44 [Buildroot] [PATCH] package/libunwind: simplify architectutre dependencies Yann E. MORIN
2017-04-17 16:50 ` Romain Naour
2017-05-04 21:22 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox