* [Buildroot] [PATCH] package/boost: disable boost-locale for static only build @ 2017-05-14 21:45 Romain Naour 2017-05-15 7:15 ` Thomas Petazzoni 0 siblings, 1 reply; 4+ messages in thread From: Romain Naour @ 2017-05-14 21:45 UTC (permalink / raw) To: buildroot boost-locale build system try to link dynamically with icu see <link>shared and <runtime-link>shared in locale/build/Jamfile.v2 Related to https://svn.boost.org/trac/boost/ticket/9685 Enabling boost-locale for static only build trigger an incompatible properties combination. error: Tried to build the target twice, with property sets having error: these incompatible properties: error: error: - <runtime-link>static <warnings>all error: - <runtime-link>shared <warnings>on Fixes: http://autobuild.buildroot.net/results/c8f/c8f7aa85f5791d8ae8cf4b9085788adc5152286f Signed-off-by: Romain Naour <romain.naour@gmail.com> Cc: Yegor Yefremov <yegorslists@googlemail.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- package/boost/Config.in | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/package/boost/Config.in b/package/boost/Config.in index 9825c09..6ffa8f0 100644 --- a/package/boost/Config.in +++ b/package/boost/Config.in @@ -98,8 +98,15 @@ config BR2_PACKAGE_BOOST_IOSTREAMS config BR2_PACKAGE_BOOST_LOCALE bool "boost-locale" + # boost-locale build system try to link dynamically with icu + # see <link>shared and <runtime-link>shared in locale/build/Jamfile.v2 + # Related to https://svn.boost.org/trac/boost/ticket/9685 + depends on !BR2_STATIC_LIBS select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE +comment "boost-locale needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS + config BR2_PACKAGE_BOOST_LOG bool "boost-log" depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL -- 2.9.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/boost: disable boost-locale for static only build 2017-05-14 21:45 [Buildroot] [PATCH] package/boost: disable boost-locale for static only build Romain Naour @ 2017-05-15 7:15 ` Thomas Petazzoni 2017-05-15 8:30 ` Yegor Yefremov 0 siblings, 1 reply; 4+ messages in thread From: Thomas Petazzoni @ 2017-05-15 7:15 UTC (permalink / raw) To: buildroot Hello, On Sun, 14 May 2017 23:45:56 +0200, Romain Naour wrote: > diff --git a/package/boost/Config.in b/package/boost/Config.in > index 9825c09..6ffa8f0 100644 > --- a/package/boost/Config.in > +++ b/package/boost/Config.in > @@ -98,8 +98,15 @@ config BR2_PACKAGE_BOOST_IOSTREAMS > > config BR2_PACKAGE_BOOST_LOCALE > bool "boost-locale" > + # boost-locale build system try to link dynamically with icu > + # see <link>shared and <runtime-link>shared in locale/build/Jamfile.v2 > + # Related to https://svn.boost.org/trac/boost/ticket/9685 > + depends on !BR2_STATIC_LIBS > select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE OK, but doesn't the problem occurs only when icu is enabled? Do we want to prevent from using boost-locale in static linking situations in all cases, or only when combined with icu? Perhaps we should keep it simple and do like you suggest, i.e make it unavailable for all static linking configurations, regardless of icu availability. I'm just trying to figure out the best/right approach between yours and the one proposed by Yegor. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/boost: disable boost-locale for static only build 2017-05-15 7:15 ` Thomas Petazzoni @ 2017-05-15 8:30 ` Yegor Yefremov 2017-05-15 19:56 ` Romain Naour 0 siblings, 1 reply; 4+ messages in thread From: Yegor Yefremov @ 2017-05-15 8:30 UTC (permalink / raw) To: buildroot Hi Romain, On Mon, May 15, 2017 at 9:15 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Sun, 14 May 2017 23:45:56 +0200, Romain Naour wrote: > >> diff --git a/package/boost/Config.in b/package/boost/Config.in >> index 9825c09..6ffa8f0 100644 >> --- a/package/boost/Config.in >> +++ b/package/boost/Config.in >> @@ -98,8 +98,15 @@ config BR2_PACKAGE_BOOST_IOSTREAMS >> >> config BR2_PACKAGE_BOOST_LOCALE >> bool "boost-locale" >> + # boost-locale build system try to link dynamically with icu >> + # see <link>shared and <runtime-link>shared in locale/build/Jamfile.v2 >> + # Related to https://svn.boost.org/trac/boost/ticket/9685 >> + depends on !BR2_STATIC_LIBS >> select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE > > OK, but doesn't the problem occurs only when icu is enabled? Do we want > to prevent from using boost-locale in static linking situations in all > cases, or only when combined with icu? > > Perhaps we should keep it simple and do like you suggest, i.e make it > unavailable for all static linking configurations, regardless of icu > availability. I'm just trying to figure out the best/right approach > between yours and the one proposed by Yegor. Have you also tested regex module? It seems to have the same structure/dependencies as locale module. Yegor ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/boost: disable boost-locale for static only build 2017-05-15 8:30 ` Yegor Yefremov @ 2017-05-15 19:56 ` Romain Naour 0 siblings, 0 replies; 4+ messages in thread From: Romain Naour @ 2017-05-15 19:56 UTC (permalink / raw) To: buildroot Hi Yegor, Le 15/05/2017 ? 10:30, Yegor Yefremov a ?crit : > Hi Romain, > > On Mon, May 15, 2017 at 9:15 AM, Thomas Petazzoni > <thomas.petazzoni@free-electrons.com> wrote: >> Hello, >> >> On Sun, 14 May 2017 23:45:56 +0200, Romain Naour wrote: >> >>> diff --git a/package/boost/Config.in b/package/boost/Config.in >>> index 9825c09..6ffa8f0 100644 >>> --- a/package/boost/Config.in >>> +++ b/package/boost/Config.in >>> @@ -98,8 +98,15 @@ config BR2_PACKAGE_BOOST_IOSTREAMS >>> >>> config BR2_PACKAGE_BOOST_LOCALE >>> bool "boost-locale" >>> + # boost-locale build system try to link dynamically with icu >>> + # see <link>shared and <runtime-link>shared in locale/build/Jamfile.v2 >>> + # Related to https://svn.boost.org/trac/boost/ticket/9685 >>> + depends on !BR2_STATIC_LIBS >>> select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE >> >> OK, but doesn't the problem occurs only when icu is enabled? Do we want >> to prevent from using boost-locale in static linking situations in all >> cases, or only when combined with icu? >> >> Perhaps we should keep it simple and do like you suggest, i.e make it >> unavailable for all static linking configurations, regardless of icu >> availability. I'm just trying to figure out the best/right approach >> between yours and the one proposed by Yegor. > > Have you also tested regex module? It seems to have the same > structure/dependencies as locale module. Yes, the boost-regex module was still selected when I disabled boost-locale and rebuilt boost package (after a boost-dirclean). Maybe I missed something, please share a defconfig if you're able to trigger the issue with boost-regex :) Best regards, Romain > > Yegor > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-15 19:56 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-05-14 21:45 [Buildroot] [PATCH] package/boost: disable boost-locale for static only build Romain Naour 2017-05-15 7:15 ` Thomas Petazzoni 2017-05-15 8:30 ` Yegor Yefremov 2017-05-15 19:56 ` Romain Naour
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox