Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 01/20] support/tests: allow properly indented config fragment
Date: Tue, 18 Jul 2017 22:45:00 +0200	[thread overview]
Message-ID: <20170718204500.GA6291@scaer> (raw)
In-Reply-To: <9ffa131e00b78d82799b6761884257afb6f74621.1500398733.git.yann.morin.1998@free.fr>

All,

This is version 2 of the patch. Version 1 has been just reviewed now by
Arnout, after which I sent v3:
    https://patchwork.ozlabs.org/patch/790525/

So, please disregard this one; use v3 instead (but still before the rest
of this series).

Thanks!

Regards,
Yann E. MORIN.

On 2017-07-18 19:25 +0200, Yann E. MORIN spake thusly:
> Currently, defining a config fragment in the runtime test infra requires
> that the fragment not to be indented. This is beark, and causes grievance
> when looking at the code (e.g. to fix it).
> 
> Just strip out all leading spaces/tabs when writing the configuration
> lines into the config file, allowing in-line indented config fragments,
> like so:
> 
>     class TestFoo(bla):
>         config = bla.config + \
>             """
>             FOO=y
>             # BAR is not set
>             """
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> ---
> Changes v1 -> v2:
>   - add example in commit log  (Thomas)
> 
> ---
> Note: this is only tangentially related to this series, because it is
> needed by the last patch in the series. It wasalready submitted before:
>     https://patchwork.ozlabs.org/patch/788985/
> ---
>  support/testing/infra/builder.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/support/testing/infra/builder.py b/support/testing/infra/builder.py
> index a475bb0a30..81735dec96 100644
> --- a/support/testing/infra/builder.py
> +++ b/support/testing/infra/builder.py
> @@ -16,7 +16,8 @@ class Builder(object):
>  
>          config_file = os.path.join(self.builddir, ".config")
>          with open(config_file, "w+") as cf:
> -            cf.write(self.config)
> +            for line in self.config.splitlines():
> +                cf.write("{}\n".format(line.lstrip()))
>  
>          cmd = ["make",
>                 "O={}".format(self.builddir),
> -- 
> 2.11.0
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-07-18 20:45 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 17:25 [Buildroot] [PATCH 00/20] system: properly handle systemd as init system Yann E. MORIN
2017-07-18 17:25 ` [Buildroot] [PATCH 01/20] support/tests: allow properly indented config fragment Yann E. MORIN
2017-07-18 20:45   ` Yann E. MORIN [this message]
2017-07-18 17:25 ` [Buildroot] [PATCH 02/20] core/pkg-generic: add variable to skip skeleton dependency Yann E. MORIN
2017-07-22 12:27   ` Arnout Vandecappelle
2017-07-23  9:12     ` Peter Korsgaard
2017-07-23  9:21       ` Yann E. MORIN
2017-07-23 13:01         ` Peter Korsgaard
2017-07-22 13:41   ` Thomas Petazzoni
2017-07-18 17:25 ` [Buildroot] [PATCH 03/20] package/skeleton: add macro to rsync skeleton directory Yann E. MORIN
2017-07-22 12:34   ` Arnout Vandecappelle
2017-07-22 13:02   ` Arnout Vandecappelle
2017-07-22 14:33     ` Yann E. MORIN
2017-07-22 13:42   ` Thomas Petazzoni
2017-07-18 17:25 ` [Buildroot] [PATCH 04/20] package/skeleton: make SKELETON_LIB_SYMLINK a macro Yann E. MORIN
2017-07-22 12:56   ` Arnout Vandecappelle
2017-07-22 19:47     ` Thomas Petazzoni
2017-07-22 21:02       ` [Buildroot] Is MIPS_NABI32 a 64-bit architecture? [was: [PATCH 04/20] package/skeleton: make SKELETON_LIB_SYMLINK a macro] Arnout Vandecappelle
2017-07-22 13:50   ` [Buildroot] [PATCH 04/20] package/skeleton: make SKELETON_LIB_SYMLINK a macro Thomas Petazzoni
2017-07-22 14:23     ` Yann E. MORIN
2017-07-22 19:45   ` Thomas Petazzoni
2017-07-18 17:25 ` [Buildroot] [PATCH 05/20] system: provide package-wide system variables and macros Yann E. MORIN
2017-07-22 13:00   ` Arnout Vandecappelle
2017-07-18 17:25 ` [Buildroot] [PATCH 06/20] system: move setting getty to the corresponding init systems Yann E. MORIN
2017-07-22 13:11   ` Arnout Vandecappelle
2017-07-22 19:57     ` Thomas Petazzoni
2017-07-22 21:13       ` Arnout Vandecappelle
2017-07-22 20:34   ` Thomas Petazzoni
2017-07-18 17:25 ` [Buildroot] [PATCH 07/20] system: move remounting / " Yann E. MORIN
2017-07-22 13:16   ` Arnout Vandecappelle
2017-07-22 20:36   ` Thomas Petazzoni
2017-07-18 17:25 ` [Buildroot] [PATCH 08/20] system: with no init system, only allow custom skeleton Yann E. MORIN
2017-07-22 13:28   ` Arnout Vandecappelle
2017-07-22 13:53     ` Yann E. MORIN
2017-07-22 21:18       ` Arnout Vandecappelle
2017-07-22 22:12         ` Yann E. MORIN
2017-07-18 17:25 ` [Buildroot] [PATCH 09/20] package/skeleton: drop dependency on host-mkpasswd Yann E. MORIN
2017-07-22 21:24   ` Arnout Vandecappelle
2017-07-22 22:32     ` Yann E. MORIN
2017-07-18 17:25 ` [Buildroot] [PATCH 10/20] package/skeleton: select it rather than default to y Yann E. MORIN
2017-07-22 21:47   ` Arnout Vandecappelle
2017-07-18 17:25 ` [Buildroot] [PATCH 11/20] package/skeleton: split out into skeleton-custom Yann E. MORIN
2017-07-22 22:31   ` Arnout Vandecappelle
2017-07-22 22:38     ` Arnout Vandecappelle
2017-07-23  9:45       ` Yann E. MORIN
2017-07-18 17:25 ` [Buildroot] [PATCH 12/20] package/skeleton: split out into skeleton-common Yann E. MORIN
2017-07-22 23:06   ` Arnout Vandecappelle
2017-07-23  9:48     ` Yann E. MORIN
2017-07-23 20:32       ` Arnout Vandecappelle
2017-07-24  7:19         ` Thomas Petazzoni
2017-07-24 15:19           ` Yann E. MORIN
2017-07-18 17:25 ` [Buildroot] [PATCH 13/20] package/skeleton: make it a virtual package Yann E. MORIN
2017-07-22 23:36   ` Arnout Vandecappelle
2017-07-23 10:13     ` Yann E. MORIN
2017-07-23 20:48       ` Arnout Vandecappelle
2017-07-18 17:25 ` [Buildroot] [PATCH 14/20] package/skeleton-common: simplify staging install Yann E. MORIN
2017-07-22 23:38   ` Arnout Vandecappelle
2017-07-18 17:25 ` [Buildroot] [PATCH 15/20] package/skeleton: introduce sysv- and systemd-specific skeletons Yann E. MORIN
2017-07-22 23:49   ` Arnout Vandecappelle
2017-07-23 10:15     ` Yann E. MORIN
2017-07-18 17:25 ` [Buildroot] [PATCH 16/20] system: separate sysv and systemd parts of the skeleton Yann E. MORIN
2017-07-23  0:08   ` Arnout Vandecappelle
2017-07-23  0:13     ` Arnout Vandecappelle
2017-07-23 10:31       ` Yann E. MORIN
2017-07-23 10:24     ` Yann E. MORIN
2017-07-23 13:32       ` Arnout Vandecappelle
2017-07-23 13:39         ` Arnout Vandecappelle
2017-07-23 13:41           ` Yann E. MORIN
2017-07-18 17:25 ` [Buildroot] [PATCH 17/20] sytem: no-init systems may use our default, common skeleton Yann E. MORIN
2017-07-23  0:18   ` Arnout Vandecappelle
2017-07-23 10:37     ` Yann E. MORIN
2017-07-18 17:25 ` [Buildroot] [PATCH 18/20] fs: add pre- and post-command hooks Yann E. MORIN
2017-07-23 13:42   ` Arnout Vandecappelle
2017-07-23 14:17     ` Yann E. MORIN
2017-07-23 21:51       ` Arnout Vandecappelle
2017-07-24 16:01         ` Yann E. MORIN
2017-07-24 22:23           ` Arnout Vandecappelle
2017-07-18 17:25 ` [Buildroot] [PATCH 19/20] system: make systemd work on a read-only rootfs Yann E. MORIN
2017-07-23 22:18   ` Arnout Vandecappelle
2017-07-24 15:45     ` Yann E. MORIN
2017-07-24 22:44       ` Arnout Vandecappelle
2017-07-25 16:07         ` Yann E. MORIN
2017-07-25 22:24           ` Arnout Vandecappelle
2017-07-18 17:25 ` [Buildroot] [PATCH 20/20] support/testing: add runtime testing for init systems Yann E. MORIN
2017-07-22 14:32   ` Arnout Vandecappelle
2017-07-22 14:45     ` Yann E. MORIN
2017-07-22 19:30       ` Thomas Petazzoni
2017-07-22 19:53       ` Arnout Vandecappelle
2017-07-22 20:10         ` Thomas Petazzoni
2017-07-22 22:50           ` Yann E. MORIN
2017-07-23  7:58             ` Thomas Petazzoni
2017-07-23  9:26               ` Yann E. MORIN
2017-07-23 18:13                 ` [Buildroot] TestIso9660GrubExternal and TestIso9660GrubInternal failing Ricardo Martincoski
2017-07-23 20:02                   ` Yann E. MORIN
2017-07-23 20:28                     ` Yann E. MORIN
2017-07-23 20:39                     ` Yann E. MORIN
2017-07-24  7:13                   ` Thomas Petazzoni
2017-07-24 11:07                     ` Ricardo Martincoski
2017-07-24 15:18                     ` Yann E. MORIN
2017-07-24 15:20   ` [Buildroot] [PATCH 20/20] support/testing: add runtime testing for init systems Andrey Smirnov
2017-07-24 15:50     ` Yann E. MORIN
2017-07-19 20:14 ` [Buildroot] [PATCH 00/20] system: properly handle systemd as init system Andrey Yurovsky
2017-07-19 20:53   ` Thomas Petazzoni
2017-07-19 22:17     ` Andrey Yurovsky
2017-07-20  7:32       ` Thomas Petazzoni
2017-07-21 22:15         ` Marcus Hoffmann
2017-07-28 20:41           ` Marcus Hoffmann
2017-07-28 20:54             ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718204500.GA6291@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox