From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v8 03/10] support/scripts: add fix-rpath script to sanitize the rpath
Date: Thu, 20 Jul 2017 23:11:29 +0200 [thread overview]
Message-ID: <20170720231129.35f31a46@windsurf> (raw)
In-Reply-To: <53db2a2d-2211-b173-8e37-19f55afe49de@mind.be>
Hello,
On Thu, 20 Jul 2017 23:05:59 +0200, Arnout Vandecappelle wrote:
> >> support/scripts/fix-rpath | 133 ++++++++++++++++++++++++++++++++++++++++++++++
> >> 1 file changed, 133 insertions(+)
> >> create mode 100755 support/scripts/fix-rpath
> >
> > I've applied to master, after removing trailing slashes.
>
> Which trailing slashes?
Gaah, I wanted to say "trailing spaces".
> > This is a little bit disturbing, so I believe it should be fixed in a
> > follow-up patch.
>
> Right! That's because the "if ${PATCHELF} ..." just fails and the error is
> redirected to /dev/null.
>
> Better check if ${PATCHELF} is executable somewhere in the beginning.
>
> However, there is never a guarantee. If e.g. it would be missing a shared
> library, it would still fail in the same way. To be really sure, you'd have do
> e.g. call patchelf on itself to verify it is actually working.
Perhaps patchelf --help is sufficient?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-20 21:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 14:35 [Buildroot] [PATCH v8 00/10] Make the SDK relocatable Wolfgang Grandegger
2017-07-20 14:35 ` [Buildroot] [PATCH v8 01/10] support/scripts: relocate-sdk.sh now uses a normal pipe to find strings Wolfgang Grandegger
2017-07-20 20:30 ` Thomas Petazzoni
2017-07-20 14:35 ` [Buildroot] [PATCH v8 02/10] package/patchelf: add patch for rpath sanitization under a root directory Wolfgang Grandegger
2017-07-20 20:30 ` Thomas Petazzoni
2017-07-20 14:35 ` [Buildroot] [PATCH v8 03/10] support/scripts: add fix-rpath script to sanitize the rpath Wolfgang Grandegger
2017-07-20 20:49 ` Thomas Petazzoni
2017-07-20 21:05 ` Arnout Vandecappelle
2017-07-20 21:11 ` Thomas Petazzoni [this message]
2017-07-21 7:35 ` Wolfgang Grandegger
2017-07-21 7:40 ` Thomas Petazzoni
2017-07-21 7:45 ` Wolfgang Grandegger
2017-07-20 21:03 ` Arnout Vandecappelle
2017-07-20 21:12 ` Thomas Petazzoni
2017-07-20 14:35 ` [Buildroot] [PATCH v8 04/10] patchelf: always build this package required for RPATH sanitization Wolfgang Grandegger
2017-07-20 20:49 ` Thomas Petazzoni
2017-07-20 14:35 ` [Buildroot] [PATCH v8 05/10] core: sanitize RPATH in target tree before copying the overlay Wolfgang Grandegger
2017-07-20 20:49 ` Thomas Petazzoni
2017-07-20 14:35 ` [Buildroot] [PATCH v8 06/10] core: introduce "sdk" target to make a relocatable SDK Wolfgang Grandegger
2017-07-20 21:11 ` Arnout Vandecappelle
2017-07-20 21:18 ` Thomas Petazzoni
2017-07-20 14:35 ` [Buildroot] [PATCH v8 07/10] core: sanitize RPATH in staging tree " Wolfgang Grandegger
2017-07-20 14:35 ` [Buildroot] [PATCH v8 08/10] external-toolchain: check if a buildroot SDK has already been relocated Wolfgang Grandegger
2017-07-20 21:21 ` Thomas Petazzoni
2017-07-20 22:30 ` Arnout Vandecappelle
2017-07-21 6:36 ` Thomas Petazzoni
2017-07-21 6:52 ` Wolfgang Grandegger
2017-07-21 7:24 ` Thomas Petazzoni
2017-07-21 7:44 ` Wolfgang Grandegger
2017-07-21 8:05 ` Thomas Petazzoni
2017-07-21 20:31 ` Arnout Vandecappelle
2017-07-21 20:40 ` Thomas Petazzoni
2017-07-22 10:49 ` Arnout Vandecappelle
2017-07-20 14:35 ` [Buildroot] [PATCH v8 09/10] core: install relocation script and location to make a relocatable SDK Wolfgang Grandegger
2017-07-20 14:35 ` [Buildroot] [PATCH v8 10/10] package/qt5base: provide "qt.conf" to make "qmake" relocatable Wolfgang Grandegger
2017-07-20 21:03 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720231129.35f31a46@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox