[Buildroot] [PATCH v8 08/10] external-toolchain: check if a buildroot SDK has already been relocated

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Fri, 21 Jul 2017 00:30:52 +0200, Arnout Vandecappelle wrote:

> > Now that I think of it, this is going to be a bit annoying. This means
> > that whenever you want to use a Buildroot-generated toolchain as an
> > external toolchain in another Buildroot configuration, you have to run
> > this relocate script.
> > 
> > This will break a lot of things, like the autobuilders, the runtime
> > test infrastructure, etc. that all rely on pre-built Buildroot
> > toolchains, but don't run the relocate-sdk script. In addition, we
> > simply can't do it, because it's directly Buildroot itself that
> > downloads the toolchain tarball and extracts it, so we don't even get
> > the opportunity to run the relocate-sdk script.  
> 
>  Well, we could run the script directly for downloaded toolchains, and do the
> check for pre-installed toolchains. Does that sound acceptable?
> 
>  I'm probably forgetting something though :-)

In fact, I wonder why this check is necessary at all, for the use case
of an external toolchain. Indeed, an external toolchain is really a
very minimal SDK, with just gcc/binutils/gdb/libc. And there is nothing
that relocate-sdk will relocate in such a simple SDK: SDKs that are
just toolchains are relocatable by design, with no fixup needed.

The relocate-sdk is useful when you start having more stuff in the SDK,
with libtool files and other weird things that hardcore paths. But
that's not the case for the SDK-is-just-a-toolchain case.

Therefore, I would suggest to simply drop this check.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com