[Buildroot] [PATCH v8 08/10] external-toolchain: check if a buildroot SDK has already been relocated

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Fri, 21 Jul 2017 08:52:56 +0200, Wolfgang Grandegger wrote:

> > Therefore, I would suggest to simply drop this check.  
> 
> If you make a toolchain with "make toolchain" the check will not harm. 
> If it's created with "make sdk" it will do the check because
> "share/buildroot/sdk-location" does exist. "make sdk" will never create 
> just the toolchain.

"make sdk" will definitely create just the toolchain if what you have
in your configuration is... just the toolchain, which is exactly how I
build Buildroot toolchains, such as the ones used by the autobuilders
or on toolchains.free-electrons.com.

Doing "make toolchain" doesn't work for this use case, because you
definitely want the RPATH sanitization of host binaries done in "make
sdk".

Again, I think this additional check in the external toolchain code is
useless. For a SDK to be usable as an external toolchain, it has to be
a SDK that contains *just* a toolchain and *nothing* else. If its
sysroot is polluted with additional libraries than the C library, it
cannot be used as an external toolchain. And therefore, the
relocate-sdk procedure is useless, because there's nothing to relocate
in an SDK that is just a toolchain.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com