[Buildroot] [PATCH] suport/download: force svn to be non-interactive

[Buildroot] [PATCH] suport/download: force svn to be non-interactive

[Yann E. MORIN]

Fixes:
    http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Andr? Hentschel <nerv@dawncrow.de>
---
 support/download/svn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/download/svn b/support/download/svn
index 77abf3d02d..9f27d71f86 100755
--- a/support/download/svn
+++ b/support/download/svn
@@ -33,6 +33,6 @@ _svn() {
     eval ${SVN} "${@}"
 }
 
-_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
 
 tar czf "${output}" "${basename}"
-- 
2.11.0

[Buildroot] [PATCH] suport/download: force svn to be non-interactive

[André Hentschel]

Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> Fixes:
>     http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Andr? Hentschel <nerv@dawncrow.de>
> ---
>  support/download/svn | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/download/svn b/support/download/svn
> index 77abf3d02d..9f27d71f86 100755
> --- a/support/download/svn
> +++ b/support/download/svn
> @@ -33,6 +33,6 @@ _svn() {
>      eval ${SVN} "${@}"
>  }
>  
> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>  
>  tar czf "${output}" "${basename}"
> 


Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>

[Buildroot] [PATCH] suport/download: force svn to be non-interactive

[Arnout Vandecappelle]

On 05-11-17 15:46, Andr? Hentschel wrote:
> Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
>> Fixes:
>>     http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
>>
>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Cc: Andr? Hentschel <nerv@dawncrow.de>
>> ---
>>  support/download/svn | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/support/download/svn b/support/download/svn
>> index 77abf3d02d..9f27d71f86 100755
>> --- a/support/download/svn
>> +++ b/support/download/svn
>> @@ -33,6 +33,6 @@ _svn() {
>>      eval ${SVN} "${@}"
>>  }
>>  
>> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>>  
>>  tar czf "${output}" "${basename}"
>>
> 
> 
> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>

 Signed-off-by is only relevant when you propagate a patch (create one or resend
someone else's). The Signed-off-by is a short way for you to assert that you are
entitled to contribute the patch under buildroot's GPL license.  See
http://elinux.org/Developer_Certificate_Of_Origin for more details.

 I guess you meant either Tested-by, Reviewed-by or Acked-by. Note that those
three get picked up by patchwork, will be part of the git log, and will be
reported in the release announcement.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] suport/download: force svn to be non-interactive

[Yann E. MORIN]

Andr?, All,

On 2017-11-05 15:46 +0100, Andr? Hentschel spake thusly:
> Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> > Fixes:
> >     http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Cc: Andr? Hentschel <nerv@dawncrow.de>
> > ---
> >  support/download/svn | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/support/download/svn b/support/download/svn
> > index 77abf3d02d..9f27d71f86 100755
> > --- a/support/download/svn
> > +++ b/support/download/svn
> > @@ -33,6 +33,6 @@ _svn() {
> >      eval ${SVN} "${@}"
> >  }
> >  
> > -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> > +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> >  
> >  tar czf "${output}" "${basename}"
> > 
> 
> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>

Did you mean "Tested-by" or "Reviewed-by" instead?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] suport/download: force svn to be non-interactive

[André Hentschel]

Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> Fixes:
>     http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Andr? Hentschel <nerv@dawncrow.de>
> ---
>  support/download/svn | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/download/svn b/support/download/svn
> index 77abf3d02d..9f27d71f86 100755
> --- a/support/download/svn
> +++ b/support/download/svn
> @@ -33,6 +33,6 @@ _svn() {
>      eval ${SVN} "${@}"
>  }
>  
> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>  
>  tar czf "${output}" "${basename}"
> 


Reviewed-by: Andr? Hentschel <nerv@dawncrow.de>

[Buildroot] [PATCH] suport/download: force svn to be non-interactive

[Thomas Petazzoni]

Hello,

On Sun, 5 Nov 2017 15:46:14 +0100, Andr? Hentschel wrote:
> Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> > Fixes:
> >     http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Cc: Andr? Hentschel <nerv@dawncrow.de>
> > ---
> >  support/download/svn | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/support/download/svn b/support/download/svn
> > index 77abf3d02d..9f27d71f86 100755
> > --- a/support/download/svn
> > +++ b/support/download/svn
> > @@ -33,6 +33,6 @@ _svn() {
> >      eval ${SVN} "${@}"
> >  }
> >  
> > -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> > +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> >  
> >  tar czf "${output}" "${basename}"
> >   
> 
> 
> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>

Such a Signed-off-by doesn't make sense, because you're not passing
the code to someone else. You probably wanted to give one (or several)
of the following:

 - Reviewed-by:
 - Tested-by:
 - Acked-by:

See the manual for the detailed definition of those tags.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH] suport/download: force svn to be non-interactive

[Arnout Vandecappelle]

On 05-11-17 16:14, Andr? Hentschel wrote:
> Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
>> Fixes:
>>     http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
>>
>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Cc: Andr? Hentschel <nerv@dawncrow.de>
>> ---
>>  support/download/svn | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/support/download/svn b/support/download/svn
>> index 77abf3d02d..9f27d71f86 100755
>> --- a/support/download/svn
>> +++ b/support/download/svn
>> @@ -33,6 +33,6 @@ _svn() {
>>      eval ${SVN} "${@}"
>>  }
>>  
>> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>>  
>>  tar czf "${output}" "${basename}"
>>
> 
> 
> Reviewed-by: Andr? Hentschel <nerv@dawncrow.de>

 Thanks! Sorry that Thomas, Yann and I gave you the same message three times.
Race conditions, difficult to avoid :-)

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] suport/download: force svn to be non-interactive

[Yann E. MORIN]

All,

On 2017-11-05 17:34 +0100, Arnout Vandecappelle spake thusly:
> On 05-11-17 16:14, Andr? Hentschel wrote:
> > Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> >> Fixes:
> >>     http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> >>
> >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> >> Cc: Andr? Hentschel <nerv@dawncrow.de>
> >> ---
> >>  support/download/svn | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/support/download/svn b/support/download/svn
> >> index 77abf3d02d..9f27d71f86 100755
> >> --- a/support/download/svn
> >> +++ b/support/download/svn
> >> @@ -33,6 +33,6 @@ _svn() {
> >>      eval ${SVN} "${@}"
> >>  }
> >>  
> >> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> >> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> >>  
> >>  tar czf "${output}" "${basename}"
> >>
> > 
> > 
> > Reviewed-by: Andr? Hentschel <nerv@dawncrow.de>
> 
>  Thanks! Sorry that Thomas, Yann and I gave you the same message three times.
> Race conditions, difficult to avoid :-)

lock(buildroot.mailing_list)

Yeah I found it pretty funny in retrospect. A bit like the other
discussion about BR2_REPRODUCIBLE where I basically repeated Thomas and
Peter's words, when I should have just read the entire thread before
replying.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] suport/download: force svn to be non-interactive

[Yann E. MORIN]

On 2017-11-05 17:40 +0100, Yann E. MORIN spake thusly:
> All,
> 
> On 2017-11-05 17:34 +0100, Arnout Vandecappelle spake thusly:
> > On 05-11-17 16:14, Andr? Hentschel wrote:
> > > Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> > >> Fixes:
> > >>     http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> > >>
> > >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > >> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > >> Cc: Andr? Hentschel <nerv@dawncrow.de>
> > >> ---
> > >>  support/download/svn | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/support/download/svn b/support/download/svn
> > >> index 77abf3d02d..9f27d71f86 100755
> > >> --- a/support/download/svn
> > >> +++ b/support/download/svn
> > >> @@ -33,6 +33,6 @@ _svn() {
> > >>      eval ${SVN} "${@}"
> > >>  }
> > >>  
> > >> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> > >> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> > >>  
> > >>  tar czf "${output}" "${basename}"
> > >>
> > > 
> > > 
> > > Reviewed-by: Andr? Hentschel <nerv@dawncrow.de>
> > 
> >  Thanks! Sorry that Thomas, Yann and I gave you the same message three times.
> > Race conditions, difficult to avoid :-)
> 
> lock(buildroot.mailing_list)
> 
> Yeah I found it pretty funny in retrospect. A bit like the other
> discussion about BR2_REPRODUCIBLE where I basically repeated Thomas and
> Peter's words, when I should have just read the entire thread before
> replying.

Aha! got y'all stuck!

unlock(buildroot.mailing_list)

There, fixed. ;]

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] suport/download: force svn to be non-interactive

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Fixes:
 >     http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > Cc: Andr? Hentschel <nerv@dawncrow.de>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] suport/download: force svn to be non-interactive

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Fixes:
 >     http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > Cc: Andr? Hentschel <nerv@dawncrow.de>

Committed to 2017.02.x and 2017.08.x, thanks.

-- 
Bye, Peter Korsgaard