* [Buildroot] [PATCH] suport/download: force svn to be non-interactive
@ 2017-11-03 21:22 Yann E. MORIN
2017-11-05 14:46 ` André Hentschel
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Yann E. MORIN @ 2017-11-03 21:22 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Andr? Hentschel <nerv@dawncrow.de>
---
support/download/svn | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/support/download/svn b/support/download/svn
index 77abf3d02d..9f27d71f86 100755
--- a/support/download/svn
+++ b/support/download/svn
@@ -33,6 +33,6 @@ _svn() {
eval ${SVN} "${@}"
}
-_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
tar czf "${output}" "${basename}"
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [Buildroot] [PATCH] suport/download: force svn to be non-interactive
2017-11-03 21:22 [Buildroot] [PATCH] suport/download: force svn to be non-interactive Yann E. MORIN
@ 2017-11-05 14:46 ` André Hentschel
2017-11-05 14:50 ` Arnout Vandecappelle
` (2 more replies)
2017-11-05 15:14 ` André Hentschel
` (2 subsequent siblings)
3 siblings, 3 replies; 11+ messages in thread
From: André Hentschel @ 2017-11-05 14:46 UTC (permalink / raw)
To: buildroot
Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> Fixes:
> http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Andr? Hentschel <nerv@dawncrow.de>
> ---
> support/download/svn | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/download/svn b/support/download/svn
> index 77abf3d02d..9f27d71f86 100755
> --- a/support/download/svn
> +++ b/support/download/svn
> @@ -33,6 +33,6 @@ _svn() {
> eval ${SVN} "${@}"
> }
>
> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>
> tar czf "${output}" "${basename}"
>
Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
^ permalink raw reply [flat|nested] 11+ messages in thread* [Buildroot] [PATCH] suport/download: force svn to be non-interactive
2017-11-05 14:46 ` André Hentschel
@ 2017-11-05 14:50 ` Arnout Vandecappelle
2017-11-05 14:54 ` Yann E. MORIN
2017-11-05 15:14 ` Thomas Petazzoni
2 siblings, 0 replies; 11+ messages in thread
From: Arnout Vandecappelle @ 2017-11-05 14:50 UTC (permalink / raw)
To: buildroot
On 05-11-17 15:46, Andr? Hentschel wrote:
> Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
>> Fixes:
>> http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
>>
>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Cc: Andr? Hentschel <nerv@dawncrow.de>
>> ---
>> support/download/svn | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/support/download/svn b/support/download/svn
>> index 77abf3d02d..9f27d71f86 100755
>> --- a/support/download/svn
>> +++ b/support/download/svn
>> @@ -33,6 +33,6 @@ _svn() {
>> eval ${SVN} "${@}"
>> }
>>
>> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>>
>> tar czf "${output}" "${basename}"
>>
>
>
> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
Signed-off-by is only relevant when you propagate a patch (create one or resend
someone else's). The Signed-off-by is a short way for you to assert that you are
entitled to contribute the patch under buildroot's GPL license. See
http://elinux.org/Developer_Certificate_Of_Origin for more details.
I guess you meant either Tested-by, Reviewed-by or Acked-by. Note that those
three get picked up by patchwork, will be part of the git log, and will be
reported in the release announcement.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 11+ messages in thread* [Buildroot] [PATCH] suport/download: force svn to be non-interactive
2017-11-05 14:46 ` André Hentschel
2017-11-05 14:50 ` Arnout Vandecappelle
@ 2017-11-05 14:54 ` Yann E. MORIN
2017-11-05 15:14 ` Thomas Petazzoni
2 siblings, 0 replies; 11+ messages in thread
From: Yann E. MORIN @ 2017-11-05 14:54 UTC (permalink / raw)
To: buildroot
Andr?, All,
On 2017-11-05 15:46 +0100, Andr? Hentschel spake thusly:
> Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> > Fixes:
> > http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Cc: Andr? Hentschel <nerv@dawncrow.de>
> > ---
> > support/download/svn | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/support/download/svn b/support/download/svn
> > index 77abf3d02d..9f27d71f86 100755
> > --- a/support/download/svn
> > +++ b/support/download/svn
> > @@ -33,6 +33,6 @@ _svn() {
> > eval ${SVN} "${@}"
> > }
> >
> > -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> > +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> >
> > tar czf "${output}" "${basename}"
> >
>
> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
Did you mean "Tested-by" or "Reviewed-by" instead?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 11+ messages in thread* [Buildroot] [PATCH] suport/download: force svn to be non-interactive
2017-11-05 14:46 ` André Hentschel
2017-11-05 14:50 ` Arnout Vandecappelle
2017-11-05 14:54 ` Yann E. MORIN
@ 2017-11-05 15:14 ` Thomas Petazzoni
2 siblings, 0 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2017-11-05 15:14 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 5 Nov 2017 15:46:14 +0100, Andr? Hentschel wrote:
> Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> > Fixes:
> > http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Cc: Andr? Hentschel <nerv@dawncrow.de>
> > ---
> > support/download/svn | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/support/download/svn b/support/download/svn
> > index 77abf3d02d..9f27d71f86 100755
> > --- a/support/download/svn
> > +++ b/support/download/svn
> > @@ -33,6 +33,6 @@ _svn() {
> > eval ${SVN} "${@}"
> > }
> >
> > -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> > +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> >
> > tar czf "${output}" "${basename}"
> >
>
>
> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
Such a Signed-off-by doesn't make sense, because you're not passing
the code to someone else. You probably wanted to give one (or several)
of the following:
- Reviewed-by:
- Tested-by:
- Acked-by:
See the manual for the detailed definition of those tags.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH] suport/download: force svn to be non-interactive
2017-11-03 21:22 [Buildroot] [PATCH] suport/download: force svn to be non-interactive Yann E. MORIN
2017-11-05 14:46 ` André Hentschel
@ 2017-11-05 15:14 ` André Hentschel
2017-11-05 16:34 ` Arnout Vandecappelle
2017-11-05 20:17 ` Peter Korsgaard
2017-11-26 21:01 ` Peter Korsgaard
3 siblings, 1 reply; 11+ messages in thread
From: André Hentschel @ 2017-11-05 15:14 UTC (permalink / raw)
To: buildroot
Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> Fixes:
> http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Andr? Hentschel <nerv@dawncrow.de>
> ---
> support/download/svn | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/download/svn b/support/download/svn
> index 77abf3d02d..9f27d71f86 100755
> --- a/support/download/svn
> +++ b/support/download/svn
> @@ -33,6 +33,6 @@ _svn() {
> eval ${SVN} "${@}"
> }
>
> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>
> tar czf "${output}" "${basename}"
>
Reviewed-by: Andr? Hentschel <nerv@dawncrow.de>
^ permalink raw reply [flat|nested] 11+ messages in thread* [Buildroot] [PATCH] suport/download: force svn to be non-interactive
2017-11-05 15:14 ` André Hentschel
@ 2017-11-05 16:34 ` Arnout Vandecappelle
2017-11-05 16:40 ` Yann E. MORIN
0 siblings, 1 reply; 11+ messages in thread
From: Arnout Vandecappelle @ 2017-11-05 16:34 UTC (permalink / raw)
To: buildroot
On 05-11-17 16:14, Andr? Hentschel wrote:
> Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
>> Fixes:
>> http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
>>
>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Cc: Andr? Hentschel <nerv@dawncrow.de>
>> ---
>> support/download/svn | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/support/download/svn b/support/download/svn
>> index 77abf3d02d..9f27d71f86 100755
>> --- a/support/download/svn
>> +++ b/support/download/svn
>> @@ -33,6 +33,6 @@ _svn() {
>> eval ${SVN} "${@}"
>> }
>>
>> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
>>
>> tar czf "${output}" "${basename}"
>>
>
>
> Reviewed-by: Andr? Hentschel <nerv@dawncrow.de>
Thanks! Sorry that Thomas, Yann and I gave you the same message three times.
Race conditions, difficult to avoid :-)
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 11+ messages in thread* [Buildroot] [PATCH] suport/download: force svn to be non-interactive
2017-11-05 16:34 ` Arnout Vandecappelle
@ 2017-11-05 16:40 ` Yann E. MORIN
2017-11-05 16:41 ` Yann E. MORIN
0 siblings, 1 reply; 11+ messages in thread
From: Yann E. MORIN @ 2017-11-05 16:40 UTC (permalink / raw)
To: buildroot
All,
On 2017-11-05 17:34 +0100, Arnout Vandecappelle spake thusly:
> On 05-11-17 16:14, Andr? Hentschel wrote:
> > Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> >> Fixes:
> >> http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> >>
> >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> >> Cc: Andr? Hentschel <nerv@dawncrow.de>
> >> ---
> >> support/download/svn | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/support/download/svn b/support/download/svn
> >> index 77abf3d02d..9f27d71f86 100755
> >> --- a/support/download/svn
> >> +++ b/support/download/svn
> >> @@ -33,6 +33,6 @@ _svn() {
> >> eval ${SVN} "${@}"
> >> }
> >>
> >> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> >> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> >>
> >> tar czf "${output}" "${basename}"
> >>
> >
> >
> > Reviewed-by: Andr? Hentschel <nerv@dawncrow.de>
>
> Thanks! Sorry that Thomas, Yann and I gave you the same message three times.
> Race conditions, difficult to avoid :-)
lock(buildroot.mailing_list)
Yeah I found it pretty funny in retrospect. A bit like the other
discussion about BR2_REPRODUCIBLE where I basically repeated Thomas and
Peter's words, when I should have just read the entire thread before
replying.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 11+ messages in thread* [Buildroot] [PATCH] suport/download: force svn to be non-interactive
2017-11-05 16:40 ` Yann E. MORIN
@ 2017-11-05 16:41 ` Yann E. MORIN
0 siblings, 0 replies; 11+ messages in thread
From: Yann E. MORIN @ 2017-11-05 16:41 UTC (permalink / raw)
To: buildroot
On 2017-11-05 17:40 +0100, Yann E. MORIN spake thusly:
> All,
>
> On 2017-11-05 17:34 +0100, Arnout Vandecappelle spake thusly:
> > On 05-11-17 16:14, Andr? Hentschel wrote:
> > > Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> > >> Fixes:
> > >> http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> > >>
> > >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > >> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > >> Cc: Andr? Hentschel <nerv@dawncrow.de>
> > >> ---
> > >> support/download/svn | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/support/download/svn b/support/download/svn
> > >> index 77abf3d02d..9f27d71f86 100755
> > >> --- a/support/download/svn
> > >> +++ b/support/download/svn
> > >> @@ -33,6 +33,6 @@ _svn() {
> > >> eval ${SVN} "${@}"
> > >> }
> > >>
> > >> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> > >> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> > >>
> > >> tar czf "${output}" "${basename}"
> > >>
> > >
> > >
> > > Reviewed-by: Andr? Hentschel <nerv@dawncrow.de>
> >
> > Thanks! Sorry that Thomas, Yann and I gave you the same message three times.
> > Race conditions, difficult to avoid :-)
>
> lock(buildroot.mailing_list)
>
> Yeah I found it pretty funny in retrospect. A bit like the other
> discussion about BR2_REPRODUCIBLE where I basically repeated Thomas and
> Peter's words, when I should have just read the entire thread before
> replying.
Aha! got y'all stuck!
unlock(buildroot.mailing_list)
There, fixed. ;]
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH] suport/download: force svn to be non-interactive
2017-11-03 21:22 [Buildroot] [PATCH] suport/download: force svn to be non-interactive Yann E. MORIN
2017-11-05 14:46 ` André Hentschel
2017-11-05 15:14 ` André Hentschel
@ 2017-11-05 20:17 ` Peter Korsgaard
2017-11-26 21:01 ` Peter Korsgaard
3 siblings, 0 replies; 11+ messages in thread
From: Peter Korsgaard @ 2017-11-05 20:17 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Fixes:
> http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Andr? Hentschel <nerv@dawncrow.de>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH] suport/download: force svn to be non-interactive
2017-11-03 21:22 [Buildroot] [PATCH] suport/download: force svn to be non-interactive Yann E. MORIN
` (2 preceding siblings ...)
2017-11-05 20:17 ` Peter Korsgaard
@ 2017-11-26 21:01 ` Peter Korsgaard
3 siblings, 0 replies; 11+ messages in thread
From: Peter Korsgaard @ 2017-11-26 21:01 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Fixes:
> http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Andr? Hentschel <nerv@dawncrow.de>
Committed to 2017.02.x and 2017.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-11-26 21:01 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-03 21:22 [Buildroot] [PATCH] suport/download: force svn to be non-interactive Yann E. MORIN
2017-11-05 14:46 ` André Hentschel
2017-11-05 14:50 ` Arnout Vandecappelle
2017-11-05 14:54 ` Yann E. MORIN
2017-11-05 15:14 ` Thomas Petazzoni
2017-11-05 15:14 ` André Hentschel
2017-11-05 16:34 ` Arnout Vandecappelle
2017-11-05 16:40 ` Yann E. MORIN
2017-11-05 16:41 ` Yann E. MORIN
2017-11-05 20:17 ` Peter Korsgaard
2017-11-26 21:01 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox