* [Buildroot] [PATCH 1/1] Added lldpad (LLDP Agent Daemon) package.
@ 2018-01-12 11:00 Laurent Charpentier
2018-01-12 11:00 ` [Buildroot] [PATCH 1/1] open-lldp: new package Laurent Charpentier
0 siblings, 1 reply; 15+ messages in thread
From: Laurent Charpentier @ 2018-01-12 11:00 UTC (permalink / raw)
To: buildroot
The lldpad package comes with utilities to manage an LLDP interface with
support for reading and configuring TLVs. TLVs and interfaces are individual
controlled allowing flexible configuration for TX only, RX only, or TX/RX
modes per TLV.
http://open-lldp.org/
Signed-off-by: Laurent Charpentier <laurent_pubs@yahoo.com>
---
package/Config.in | 1 +
.../open-lldp/0001-lldpad-vdptool-getline.patch | 10 +++++++++
package/open-lldp/Config.in | 11 +++++++++
package/open-lldp/open-lldp.hash | 2 ++
package/open-lldp/open-lldp.mk | 26 ++++++++++++++++++++++
5 files changed, 50 insertions(+)
create mode 100644 package/open-lldp/0001-lldpad-vdptool-getline.patch
create mode 100644 package/open-lldp/Config.in
create mode 100644 package/open-lldp/open-lldp.hash
create mode 100644 package/open-lldp/open-lldp.mk
diff --git a/package/Config.in b/package/Config.in
index 01f4095be5..37e1e753e3 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1760,6 +1760,7 @@ endif
source "package/odhcp6c/Config.in"
source "package/odhcploc/Config.in"
source "package/olsr/Config.in"
+ source "package/open-lldp/Config.in"
source "package/open-plc-utils/Config.in"
source "package/openntpd/Config.in"
source "package/openobex/Config.in"
diff --git a/package/open-lldp/0001-lldpad-vdptool-getline.patch b/package/open-lldp/0001-lldpad-vdptool-getline.patch
new file mode 100644
index 0000000000..ac2e62ff16
--- /dev/null
+++ b/package/open-lldp/0001-lldpad-vdptool-getline.patch
@@ -0,0 +1,10 @@
+--- open-lldp-036e314/vdptool.c 2015-08-24 19:31:59.000000000 +0200
++++ open-lldp-036e314_patched/vdptool.c 2018-01-10 10:16:24.096431555 +0100
+@@ -36,6 +36,7 @@
+ * set and query VSI profile settings.
+ */
+
++#define _GNU_SOURCE
+ #include <stdlib.h>
+ #include <stdio.h>
+ #include <unistd.h>
diff --git a/package/open-lldp/Config.in b/package/open-lldp/Config.in
new file mode 100644
index 0000000000..84b24702c7
--- /dev/null
+++ b/package/open-lldp/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_OPEN_LLDP
+ bool "open-lldp"
+ select BR2_PACKAGE_LIBCONFIG
+ select BR2_PACKAGE_LIBNL
+ select BR2_PACKAGE_LIBTOOL
+ select BR2_PACKAGE_READLINE
+ help
+ This package contains the Linux user space daemon and configuration
+ tool for Intel LLDP Agent with Enhanced Ethernet support for the
+ Data Center.
+
diff --git a/package/open-lldp/open-lldp.hash b/package/open-lldp/open-lldp.hash
new file mode 100644
index 0000000000..6fef5b2999
--- /dev/null
+++ b/package/open-lldp/open-lldp.hash
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 217124f24ac57d3191ab33c53fccf5d7319e83f9029610be3c3cb71392480a2a open-lldp-036e314.tar.gz
diff --git a/package/open-lldp/open-lldp.mk b/package/open-lldp/open-lldp.mk
new file mode 100644
index 0000000000..5a69595b4f
--- /dev/null
+++ b/package/open-lldp/open-lldp.mk
@@ -0,0 +1,26 @@
+################################################################################
+#
+# open-lldp
+#
+################################################################################
+
+OPEN_LLDP_VERSION = 036e314
+OPEN_LLDP_SITE = git://open-lldp.org/open-lldp.git
+OPEN_LLDP_SITE_METHOD = git
+OPEN_LLDP_DEPENDENCIES = libconfig host-pkgconf libtool
+OPEN_LLDP_LICENSE = GPL-2.0
+OPEN_LLDP_LICENSE_FILES = README
+
+OPEN_LLDP_AUTORECONF = YES
+OPEN_LLDP_INSTALL_STAGING = YES
+
+OPEN_LLDP_CONF_OPTS = \
+ --disable-static
+
+define OPEN_LLDP_BOOTSTRAP
+ (cd $(@D) && ./bootstrap.sh)
+endef
+
+OPEN_LLDP_PRE_CONFIGURE_HOOKS += OPEN_LLDP_BOOTSTRAP
+
+$(eval $(autotools-package))
--
2.14.3
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-12 11:00 [Buildroot] [PATCH 1/1] Added lldpad (LLDP Agent Daemon) package Laurent Charpentier
@ 2018-01-12 11:00 ` Laurent Charpentier
2018-01-12 11:05 ` Thomas Petazzoni
0 siblings, 1 reply; 15+ messages in thread
From: Laurent Charpentier @ 2018-01-12 11:00 UTC (permalink / raw)
To: buildroot
The lldpad package comes with utilities to manage an LLDP interface with
support for reading and configuring TLVs. TLVs and interfaces are individual
controlled allowing flexible configuration for TX only, RX only, or TX/RX
modes per TLV.
http://open-lldp.org/
Signed-off-by: Laurent Charpentier <laurent_pubs@yahoo.com>
---
package/Config.in | 1 +
.../open-lldp/0001-lldpad-vdptool-getline.patch | 10 +++++++++
package/open-lldp/Config.in | 11 +++++++++
package/open-lldp/open-lldp.hash | 2 ++
package/open-lldp/open-lldp.mk | 26 ++++++++++++++++++++++
5 files changed, 50 insertions(+)
create mode 100644 package/open-lldp/0001-lldpad-vdptool-getline.patch
create mode 100644 package/open-lldp/Config.in
create mode 100644 package/open-lldp/open-lldp.hash
create mode 100644 package/open-lldp/open-lldp.mk
diff --git a/package/Config.in b/package/Config.in
index 01f4095be5..37e1e753e3 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1760,6 +1760,7 @@ endif
source "package/odhcp6c/Config.in"
source "package/odhcploc/Config.in"
source "package/olsr/Config.in"
+ source "package/open-lldp/Config.in"
source "package/open-plc-utils/Config.in"
source "package/openntpd/Config.in"
source "package/openobex/Config.in"
diff --git a/package/open-lldp/0001-lldpad-vdptool-getline.patch b/package/open-lldp/0001-lldpad-vdptool-getline.patch
new file mode 100644
index 0000000000..ac2e62ff16
--- /dev/null
+++ b/package/open-lldp/0001-lldpad-vdptool-getline.patch
@@ -0,0 +1,10 @@
+--- open-lldp-036e314/vdptool.c 2015-08-24 19:31:59.000000000 +0200
++++ open-lldp-036e314_patched/vdptool.c 2018-01-10 10:16:24.096431555 +0100
+@@ -36,6 +36,7 @@
+ * set and query VSI profile settings.
+ */
+
++#define _GNU_SOURCE
+ #include <stdlib.h>
+ #include <stdio.h>
+ #include <unistd.h>
diff --git a/package/open-lldp/Config.in b/package/open-lldp/Config.in
new file mode 100644
index 0000000000..84b24702c7
--- /dev/null
+++ b/package/open-lldp/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_OPEN_LLDP
+ bool "open-lldp"
+ select BR2_PACKAGE_LIBCONFIG
+ select BR2_PACKAGE_LIBNL
+ select BR2_PACKAGE_LIBTOOL
+ select BR2_PACKAGE_READLINE
+ help
+ This package contains the Linux user space daemon and configuration
+ tool for Intel LLDP Agent with Enhanced Ethernet support for the
+ Data Center.
+
diff --git a/package/open-lldp/open-lldp.hash b/package/open-lldp/open-lldp.hash
new file mode 100644
index 0000000000..6fef5b2999
--- /dev/null
+++ b/package/open-lldp/open-lldp.hash
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 217124f24ac57d3191ab33c53fccf5d7319e83f9029610be3c3cb71392480a2a open-lldp-036e314.tar.gz
diff --git a/package/open-lldp/open-lldp.mk b/package/open-lldp/open-lldp.mk
new file mode 100644
index 0000000000..5a69595b4f
--- /dev/null
+++ b/package/open-lldp/open-lldp.mk
@@ -0,0 +1,26 @@
+################################################################################
+#
+# open-lldp
+#
+################################################################################
+
+OPEN_LLDP_VERSION = 036e314
+OPEN_LLDP_SITE = git://open-lldp.org/open-lldp.git
+OPEN_LLDP_SITE_METHOD = git
+OPEN_LLDP_DEPENDENCIES = libconfig host-pkgconf libtool
+OPEN_LLDP_LICENSE = GPL-2.0
+OPEN_LLDP_LICENSE_FILES = README
+
+OPEN_LLDP_AUTORECONF = YES
+OPEN_LLDP_INSTALL_STAGING = YES
+
+OPEN_LLDP_CONF_OPTS = \
+ --disable-static
+
+define OPEN_LLDP_BOOTSTRAP
+ (cd $(@D) && ./bootstrap.sh)
+endef
+
+OPEN_LLDP_PRE_CONFIGURE_HOOKS += OPEN_LLDP_BOOTSTRAP
+
+$(eval $(autotools-package))
--
2.14.3
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-12 11:00 ` [Buildroot] [PATCH 1/1] open-lldp: new package Laurent Charpentier
@ 2018-01-12 11:05 ` Thomas Petazzoni
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Petazzoni @ 2018-01-12 11:05 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 12 Jan 2018 12:00:15 +0100, Laurent Charpentier wrote:
> The lldpad package comes with utilities to manage an LLDP interface with
> support for reading and configuring TLVs. TLVs and interfaces are individual
> controlled allowing flexible configuration for TX only, RX only, or TX/RX
> modes per TLV.
>
> http://open-lldp.org/
>
> Signed-off-by: Laurent Charpentier <laurent_pubs@yahoo.com>
Thanks for this new version, but you only fixed the commit title, and
none of the other review comments that I made. Did you miss them
perhaps?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
@ 2018-01-12 14:01 Laurent Charpentier
2018-01-12 14:46 ` Yegor Yefremov
0 siblings, 1 reply; 15+ messages in thread
From: Laurent Charpentier @ 2018-01-12 14:01 UTC (permalink / raw)
To: buildroot
The lldpad package comes with utilities to manage an LLDP interface with
support for reading and configuring TLVs. TLVs and interfaces are individual
controlled allowing flexible configuration for TX only, RX only, or TX/RX
modes per TLV.
http://open-lldp.org/
Signed-off-by: Laurent Charpentier <laurent_pubs@yahoo.com>
---
DEVELOPERS | 3 +++
package/Config.in | 1 +
.../open-lldp/0001-lldpad-vdptool-getline.patch | 10 +++++++++
package/open-lldp/Config.in | 12 +++++++++++
package/open-lldp/open-lldp.hash | 2 ++
package/open-lldp/open-lldp.mk | 25 ++++++++++++++++++++++
6 files changed, 53 insertions(+)
create mode 100644 package/open-lldp/0001-lldpad-vdptool-getline.patch
create mode 100644 package/open-lldp/Config.in
create mode 100644 package/open-lldp/open-lldp.hash
create mode 100644 package/open-lldp/open-lldp.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 2f7d051e8a..012af32925 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -929,6 +929,9 @@ F: package/qt5/
N: Julien Floret <julien.floret@6wind.com>
F: package/lldpd/
+N: Laurent Charpentier <laurent_pubs@yahoo.com>
+F: package/open-lldp/
+
N: Julien Viard de Galbert <julien@vdg.name>
F: package/dieharder/
F: package/easy-rsa/
diff --git a/package/Config.in b/package/Config.in
index 01f4095be5..37e1e753e3 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1760,6 +1760,7 @@ endif
source "package/odhcp6c/Config.in"
source "package/odhcploc/Config.in"
source "package/olsr/Config.in"
+ source "package/open-lldp/Config.in"
source "package/open-plc-utils/Config.in"
source "package/openntpd/Config.in"
source "package/openobex/Config.in"
diff --git a/package/open-lldp/0001-lldpad-vdptool-getline.patch b/package/open-lldp/0001-lldpad-vdptool-getline.patch
new file mode 100644
index 0000000000..ac2e62ff16
--- /dev/null
+++ b/package/open-lldp/0001-lldpad-vdptool-getline.patch
@@ -0,0 +1,10 @@
+--- open-lldp-036e314/vdptool.c 2015-08-24 19:31:59.000000000 +0200
++++ open-lldp-036e314_patched/vdptool.c 2018-01-10 10:16:24.096431555 +0100
+@@ -36,6 +36,7 @@
+ * set and query VSI profile settings.
+ */
+
++#define _GNU_SOURCE
+ #include <stdlib.h>
+ #include <stdio.h>
+ #include <unistd.h>
diff --git a/package/open-lldp/Config.in b/package/open-lldp/Config.in
new file mode 100644
index 0000000000..79eefee71b
--- /dev/null
+++ b/package/open-lldp/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_OPEN_LLDP
+ bool "open-lldp"
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
+ select BR2_PACKAGE_LIBCONFIG
+ select BR2_PACKAGE_LIBNL
+ select BR2_PACKAGE_READLINE
+ help
+ This package contains the Linux user space daemon and
+ configuration tool for Intel LLDP Agent with Enhanced Ethernet
+ support for the Data Center.
+
+ http://open-lldp.org/
diff --git a/package/open-lldp/open-lldp.hash b/package/open-lldp/open-lldp.hash
new file mode 100644
index 0000000000..6fef5b2999
--- /dev/null
+++ b/package/open-lldp/open-lldp.hash
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 217124f24ac57d3191ab33c53fccf5d7319e83f9029610be3c3cb71392480a2a open-lldp-036e314.tar.gz
diff --git a/package/open-lldp/open-lldp.mk b/package/open-lldp/open-lldp.mk
new file mode 100644
index 0000000000..d062b6795b
--- /dev/null
+++ b/package/open-lldp/open-lldp.mk
@@ -0,0 +1,25 @@
+################################################################################
+#
+# open-lldp
+#
+################################################################################
+
+OPEN_LLDP_VERSION = 036e314bd93602f7388262cc37faf8b626980af1
+OPEN_LLDP_SITE = git://open-lldp.org/open-lldp.git
+OPEN_LLDP_SITE_METHOD = git
+OPEN_LLDP_DEPENDENCIES = readline libnl libconfig
+OPEN_LLDP_LICENSE = GPL-2.0
+OPEN_LLDP_LICENSE_FILES = COPYING
+
+# Fetching from git, need to generate configure/Makefile.in
+OPEN_LLDP_AUTORECONF = YES
+
+# Run the bootstrap.sh command.
+# (from the 'lldpad Application Install' section of the README file)
+define OPEN_LLDP_BOOTSTRAP
+ (cd $(@D) && ./bootstrap.sh)
+endef
+
+OPEN_LLDP_PRE_CONFIGURE_HOOKS += OPEN_LLDP_BOOTSTRAP
+
+$(eval $(autotools-package))
--
2.14.3
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-12 14:01 Laurent Charpentier
@ 2018-01-12 14:46 ` Yegor Yefremov
2018-01-12 21:04 ` Thomas Petazzoni
0 siblings, 1 reply; 15+ messages in thread
From: Yegor Yefremov @ 2018-01-12 14:46 UTC (permalink / raw)
To: buildroot
Hi Laurent,
please provide change history when sending another patch version
(you'll find examples in Buildroot's manual
http://nightly.buildroot.org/manual.html#submitting-patches).
On Fri, Jan 12, 2018 at 3:01 PM, Laurent Charpentier
<laurent_pubs@yahoo.com> wrote:
> The lldpad package comes with utilities to manage an LLDP interface with
> support for reading and configuring TLVs. TLVs and interfaces are individual
> controlled allowing flexible configuration for TX only, RX only, or TX/RX
> modes per TLV.
>
> http://open-lldp.org/
>
> Signed-off-by: Laurent Charpentier <laurent_pubs@yahoo.com>
> ---
> DEVELOPERS | 3 +++
> package/Config.in | 1 +
> .../open-lldp/0001-lldpad-vdptool-getline.patch | 10 +++++++++
> package/open-lldp/Config.in | 12 +++++++++++
> package/open-lldp/open-lldp.hash | 2 ++
> package/open-lldp/open-lldp.mk | 25 ++++++++++++++++++++++
> 6 files changed, 53 insertions(+)
> create mode 100644 package/open-lldp/0001-lldpad-vdptool-getline.patch
> create mode 100644 package/open-lldp/Config.in
> create mode 100644 package/open-lldp/open-lldp.hash
> create mode 100644 package/open-lldp/open-lldp.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 2f7d051e8a..012af32925 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -929,6 +929,9 @@ F: package/qt5/
> N: Julien Floret <julien.floret@6wind.com>
> F: package/lldpd/
>
> +N: Laurent Charpentier <laurent_pubs@yahoo.com>
> +F: package/open-lldp/
> +
> N: Julien Viard de Galbert <julien@vdg.name>
> F: package/dieharder/
> F: package/easy-rsa/
> diff --git a/package/Config.in b/package/Config.in
> index 01f4095be5..37e1e753e3 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1760,6 +1760,7 @@ endif
> source "package/odhcp6c/Config.in"
> source "package/odhcploc/Config.in"
> source "package/olsr/Config.in"
> + source "package/open-lldp/Config.in"
> source "package/open-plc-utils/Config.in"
> source "package/openntpd/Config.in"
> source "package/openobex/Config.in"
> diff --git a/package/open-lldp/0001-lldpad-vdptool-getline.patch b/package/open-lldp/0001-lldpad-vdptool-getline.patch
> new file mode 100644
> index 0000000000..ac2e62ff16
> --- /dev/null
> +++ b/package/open-lldp/0001-lldpad-vdptool-getline.patch
> @@ -0,0 +1,10 @@
> +--- open-lldp-036e314/vdptool.c 2015-08-24 19:31:59.000000000 +0200
> ++++ open-lldp-036e314_patched/vdptool.c 2018-01-10 10:16:24.096431555 +0100
> +@@ -36,6 +36,7 @@
> + * set and query VSI profile settings.
> + */
> +
> ++#define _GNU_SOURCE
> + #include <stdlib.h>
> + #include <stdio.h>
> + #include <unistd.h>
the patch still has now commit log etc.
> diff --git a/package/open-lldp/Config.in b/package/open-lldp/Config.in
> new file mode 100644
> index 0000000000..79eefee71b
> --- /dev/null
> +++ b/package/open-lldp/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_OPEN_LLDP
> + bool "open-lldp"
> + depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
> + select BR2_PACKAGE_LIBCONFIG
> + select BR2_PACKAGE_LIBNL
> + select BR2_PACKAGE_READLINE
> + help
> + This package contains the Linux user space daemon and
> + configuration tool for Intel LLDP Agent with Enhanced Ethernet
> + support for the Data Center.
> +
> + http://open-lldp.org/
> diff --git a/package/open-lldp/open-lldp.hash b/package/open-lldp/open-lldp.hash
> new file mode 100644
> index 0000000000..6fef5b2999
> --- /dev/null
> +++ b/package/open-lldp/open-lldp.hash
> @@ -0,0 +1,2 @@
> +# Locally computed
> +sha256 217124f24ac57d3191ab33c53fccf5d7319e83f9029610be3c3cb71392480a2a open-lldp-036e314.tar.gz
checksum for COPYING is missing
> diff --git a/package/open-lldp/open-lldp.mk b/package/open-lldp/open-lldp.mk
> new file mode 100644
> index 0000000000..d062b6795b
> --- /dev/null
> +++ b/package/open-lldp/open-lldp.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# open-lldp
> +#
> +################################################################################
> +
> +OPEN_LLDP_VERSION = 036e314bd93602f7388262cc37faf8b626980af1
> +OPEN_LLDP_SITE = git://open-lldp.org/open-lldp.git
> +OPEN_LLDP_SITE_METHOD = git
if you provide a git URL you don't need to specify the method.
> +OPEN_LLDP_DEPENDENCIES = readline libnl libconfig
> +OPEN_LLDP_LICENSE = GPL-2.0
> +OPEN_LLDP_LICENSE_FILES = COPYING
> +
> +# Fetching from git, need to generate configure/Makefile.in
> +OPEN_LLDP_AUTORECONF = YES
> +
> +# Run the bootstrap.sh command.
> +# (from the 'lldpad Application Install' section of the README file)
> +define OPEN_LLDP_BOOTSTRAP
> + (cd $(@D) && ./bootstrap.sh)
> +endef
m4 folder is missing. It is worth sending a patch upstream (open-lldp)
to fix this. As long as you have this hook, you don't need
OPEN_LLDP_AUTORECONF = YES, because boostrap.sh already invokes
"autoreconf -i". At least thy this.
> +
> +OPEN_LLDP_PRE_CONFIGURE_HOOKS += OPEN_LLDP_BOOTSTRAP
> +
> +$(eval $(autotools-package))
The package doesn't build:
In file included from lldpad.c:58:0:
./include/lldp_8021qaz.h:237:12: error: inline function
?ieee8021qaz_clif_cmd? declared but never defined [-Werror]
inline int ieee8021qaz_clif_cmd(void *data, struct sockaddr_un *from,
^~~~~~~~~~~~~~~~~~~~
./include/lldp_8021qaz.h:222:13: error: inline function ?set_prio_map?
declared but never defined [-Werror]
inline void set_prio_map(u32 *prio_map, u8 prio, int tc);
^~~~~~~~~~~~
./include/lldp_8021qaz.h:221:12: error: inline function ?get_prio_map?
declared but never defined [-Werror]
inline int get_prio_map(u32 prio_map, int tc);
^~~~~~~~~~~~
Yegor
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-12 14:46 ` Yegor Yefremov
@ 2018-01-12 21:04 ` Thomas Petazzoni
2018-01-12 21:29 ` Yegor Yefremov
0 siblings, 1 reply; 15+ messages in thread
From: Thomas Petazzoni @ 2018-01-12 21:04 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 12 Jan 2018 15:46:14 +0100, Yegor Yefremov wrote:
> > +# Run the bootstrap.sh command.
> > +# (from the 'lldpad Application Install' section of the README file)
> > +define OPEN_LLDP_BOOTSTRAP
> > + (cd $(@D) && ./bootstrap.sh)
> > +endef
>
> m4 folder is missing. It is worth sending a patch upstream (open-lldp)
> to fix this. As long as you have this hook, you don't need
> OPEN_LLDP_AUTORECONF = YES, because boostrap.sh already invokes
> "autoreconf -i". At least thy this.
No, I disagree here. If you drop <pkg>_AUTORECONF = YES, then you loose
the dependency on host-autoconf, host-automake and host-libtool.
So instead, please keep <pkg>_AUTORECONF = YES, and if the missing m4
folder is the only problem (but I doubt it because the bootstrap.sh
script doesn't create it), then add a post-extract hook that creates
the m4 file.
> The package doesn't build:
>
> In file included from lldpad.c:58:0:
> ./include/lldp_8021qaz.h:237:12: error: inline function
> ?ieee8021qaz_clif_cmd? declared but never defined [-Werror]
> inline int ieee8021qaz_clif_cmd(void *data, struct sockaddr_un *from,
> ^~~~~~~~~~~~~~~~~~~~
> ./include/lldp_8021qaz.h:222:13: error: inline function ?set_prio_map?
> declared but never defined [-Werror]
> inline void set_prio_map(u32 *prio_map, u8 prio, int tc);
> ^~~~~~~~~~~~
> ./include/lldp_8021qaz.h:221:12: error: inline function ?get_prio_map?
> declared but never defined [-Werror]
> inline int get_prio_map(u32 prio_map, int tc);
> ^~~~~~~~~~~~
Perhaps you could tell Laurent which configuration you've used to
produce this build failure, so that he can reproduce it.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-12 21:04 ` Thomas Petazzoni
@ 2018-01-12 21:29 ` Yegor Yefremov
2018-01-12 22:38 ` Thomas Petazzoni
0 siblings, 1 reply; 15+ messages in thread
From: Yegor Yefremov @ 2018-01-12 21:29 UTC (permalink / raw)
To: buildroot
On Fri, Jan 12, 2018 at 10:04 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri, 12 Jan 2018 15:46:14 +0100, Yegor Yefremov wrote:
>
>> > +# Run the bootstrap.sh command.
>> > +# (from the 'lldpad Application Install' section of the README file)
>> > +define OPEN_LLDP_BOOTSTRAP
>> > + (cd $(@D) && ./bootstrap.sh)
>> > +endef
>>
>> m4 folder is missing. It is worth sending a patch upstream (open-lldp)
>> to fix this. As long as you have this hook, you don't need
>> OPEN_LLDP_AUTORECONF = YES, because boostrap.sh already invokes
>> "autoreconf -i". At least thy this.
>
> No, I disagree here. If you drop <pkg>_AUTORECONF = YES, then you loose
> the dependency on host-autoconf, host-automake and host-libtool.
You're right.
> So instead, please keep <pkg>_AUTORECONF = YES, and if the missing m4
> folder is the only problem (but I doubt it because the bootstrap.sh
> script doesn't create it), then add a post-extract hook that creates
> the m4 file.
bootstrap.sh doesn't create m4 folder, but if you just clone the
open-lldp repo and invoke "autoreconf -i", it would just complain
about missing m4 folder, but create it. In BR environment we get an
error. We had similar situation earlier with some other package
(libsoc) and I coudn't find the case of the problem, so I just added
m4 upstream and now it is working.
>> The package doesn't build:
>>
>> In file included from lldpad.c:58:0:
>> ./include/lldp_8021qaz.h:237:12: error: inline function
>> ?ieee8021qaz_clif_cmd? declared but never defined [-Werror]
>> inline int ieee8021qaz_clif_cmd(void *data, struct sockaddr_un *from,
>> ^~~~~~~~~~~~~~~~~~~~
>> ./include/lldp_8021qaz.h:222:13: error: inline function ?set_prio_map?
>> declared but never defined [-Werror]
>> inline void set_prio_map(u32 *prio_map, u8 prio, int tc);
>> ^~~~~~~~~~~~
>> ./include/lldp_8021qaz.h:221:12: error: inline function ?get_prio_map?
>> declared but never defined [-Werror]
>> inline int get_prio_map(u32 prio_map, int tc);
>> ^~~~~~~~~~~~
>
> Perhaps you could tell Laurent which configuration you've used to
> produce this build failure, so that he can reproduce it.
I get this error even on my Debian 9 host. In BR I've been playing
with powerpc defconf, that has boost issues in autobuilders.
Yegor
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-12 21:29 ` Yegor Yefremov
@ 2018-01-12 22:38 ` Thomas Petazzoni
2018-01-15 12:50 ` Laurent Charpentier
2018-01-16 8:22 ` Yegor Yefremov
0 siblings, 2 replies; 15+ messages in thread
From: Thomas Petazzoni @ 2018-01-12 22:38 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 12 Jan 2018 22:29:44 +0100, Yegor Yefremov wrote:
> > So instead, please keep <pkg>_AUTORECONF = YES, and if the missing m4
> > folder is the only problem (but I doubt it because the bootstrap.sh
> > script doesn't create it), then add a post-extract hook that creates
> > the m4 file.
>
> bootstrap.sh doesn't create m4 folder, but if you just clone the
> open-lldp repo and invoke "autoreconf -i", it would just complain
> about missing m4 folder, but create it. In BR environment we get an
> error. We had similar situation earlier with some other package
> (libsoc) and I coudn't find the case of the problem, so I just added
> m4 upstream and now it is working.
Interesting, I never realized that. After a bit of experiment, it seems
like passing a -I option makes a difference:
thomas at windsurf:~/projets/open-lldp (master)$ autoreconf -f -i -I "/home/thomas/projets/buildroot/output/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/share/aclocal" -I "/home/thomas/projets/buildroot/output/host/share/aclocal"
aclocal: error: couldn't open directory 'm4': No such file or directory
autoreconf: aclocal failed with exit status: 1
thomas at windsurf:~/projets/open-lldp (master)$ autoreconf -f -i -I "/home/thomas/projets/buildroot/output/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/share/aclocal"
aclocal: error: couldn't open directory 'm4': No such file or directory
autoreconf: aclocal failed with exit status: 1
thomas at windsurf:~/projets/open-lldp (master)$ autoreconf -f -i -I "/home/thomas/projets/buildroot/output/host/share/aclocal"
aclocal: error: couldn't open directory 'm4': No such file or directory
autoreconf: aclocal failed with exit status: 1
thomas at windsurf:~/projets/open-lldp (master)$ autoreconf -f -i
aclocal: warning: couldn't open directory 'm4': No such file or directory
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:5: installing './ar-lib'
configure.ac:5: installing './compile'
configure.ac:19: installing './config.guess'
configure.ac:19: installing './config.sub'
configure.ac:2: installing './install-sh'
configure.ac:2: installing './missing'
Makefile.am: installing './depcomp'
Even more funny:
thomas at windsurf:~/projets/open-lldp (master)$ mkdir /tmp/foo
thomas at windsurf:~/projets/open-lldp (master)$ autoreconf -f -i -I /tmp/foo/
aclocal: error: couldn't open directory 'm4': No such file or directory
autoreconf: aclocal failed with exit status: 1
Not sure what's going on here :)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-12 22:38 ` Thomas Petazzoni
@ 2018-01-15 12:50 ` Laurent Charpentier
2018-01-15 13:47 ` Thomas Petazzoni
2018-01-15 14:52 ` Yegor Yefremov
2018-01-16 8:22 ` Yegor Yefremov
1 sibling, 2 replies; 15+ messages in thread
From: Laurent Charpentier @ 2018-01-15 12:50 UTC (permalink / raw)
To: buildroot
Hi Thomas and Yegor,
On Fri, 12 Jan 2018 22:29:44 +0100, Yegor Yefremov wrote:
> > So instead, please keep <pkg>_AUTORECONF = YES, and if the missing m4
> > folder is the only problem (but I doubt it because the bootstrap.sh
> > script doesn't create it), then add a post-extract hook that creates
> > the m4 file.??
>?
> bootstrap.sh doesn't create m4 folder, but if you just clone the
> open-lldp repo and invoke "autoreconf -i", it would just complain
> about missing m4 folder, but create it. In BR environment we get an
> error. We had similar situation earlier with some other package
> (libsoc) and I coudn't find the case of the problem, so I just added
> m4 upstream and now it is working.
Here are some experiments on my side.(1) AUTORECONF=yes (no use of ./bootstrap.sh)-> ./configure fails
(2) (cd $(@D) && PATH=$(BR_PATH) ./bootstrap.sh) (no use of AUTORECONF)-> run OK (configure passed, build passed)
(3) AUTORECONF=yes and (cd $(@D) &&?./bootstrap.sh)-> run OK (configure passed, build passed)
I would like to use choice (2). This choice is similar to the RPM packaging (http://pkgs.fedoraproject.org/cgit/rpms/lldpad.git/tree/lldpad.spec) and follows the guidelines in the README file.
Let me know if you think of something different.Best Regards,Laurent
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180115/6e435a42/attachment.html>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-15 12:50 ` Laurent Charpentier
@ 2018-01-15 13:47 ` Thomas Petazzoni
2018-01-15 14:52 ` Yegor Yefremov
1 sibling, 0 replies; 15+ messages in thread
From: Thomas Petazzoni @ 2018-01-15 13:47 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 15 Jan 2018 12:50:36 +0000 (UTC), Laurent Charpentier wrote:
> Here are some experiments on my side.(1) AUTORECONF=yes (no use of ./bootstrap.sh)-> ./configure fails
> (2) (cd $(@D) && PATH=$(BR_PATH) ./bootstrap.sh) (no use of AUTORECONF)-> run OK (configure passed, build passed)
> (3) AUTORECONF=yes and (cd $(@D) &&?./bootstrap.sh)-> run OK (configure passed, build passed)
> I would like to use choice (2). This choice is similar to the RPM packaging (http://pkgs.fedoraproject.org/cgit/rpms/lldpad.git/tree/lldpad.spec) and follows the guidelines in the README file.
Choice (2) alone is wrong, because you won't have the dependency on
host-autoconf, host-automake and host-libtool.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-15 12:50 ` Laurent Charpentier
2018-01-15 13:47 ` Thomas Petazzoni
@ 2018-01-15 14:52 ` Yegor Yefremov
2018-01-15 15:15 ` Laurent Charpentier
1 sibling, 1 reply; 15+ messages in thread
From: Yegor Yefremov @ 2018-01-15 14:52 UTC (permalink / raw)
To: buildroot
On Mon, Jan 15, 2018 at 1:50 PM, Laurent Charpentier
<laurent_pubs@yahoo.com> wrote:
> Hi Thomas and Yegor,
>
> On Fri, 12 Jan 2018 22:29:44 +0100, Yegor Yefremov wrote:
>
>> > So instead, please keep <pkg>_AUTORECONF = YES, and if the missing m4
>> > folder is the only problem (but I doubt it because the bootstrap.sh
>> > script doesn't create it), then add a post-extract hook that creates
>> > the m4 file.
>>
>> bootstrap.sh doesn't create m4 folder, but if you just clone the
>> open-lldp repo and invoke "autoreconf -i", it would just complain
>> about missing m4 folder, but create it. In BR environment we get an
>> error. We had similar situation earlier with some other package
>> (libsoc) and I coudn't find the case of the problem, so I just added
>> m4 upstream and now it is working.
>
> Here are some experiments on my side.
> (1) AUTORECONF=yes (no use of ./bootstrap.sh)
> -> ./configure fails
use this variant and create a LIBFOO_PRE_CONFIGURE_HOOKS in order to
create m4 folder via "mkdir -p". That's all. This way you'll preserve
depedency on host-autoconf, host-automake and host-libtool.
Yegor
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-15 14:52 ` Yegor Yefremov
@ 2018-01-15 15:15 ` Laurent Charpentier
2018-01-15 15:21 ` Yegor Yefremov
0 siblings, 1 reply; 15+ messages in thread
From: Laurent Charpentier @ 2018-01-15 15:15 UTC (permalink / raw)
To: buildroot
Hi Yegor,
>> Here are some experiments on my side.
>> (1) AUTORECONF=yes (no use of ./bootstrap.sh)
>> -> ./configure fails
>
> use this variant and create a LIBFOO_PRE_CONFIGURE_HOOKS in order to
> create m4 folder via "mkdir -p". That's all. This way you'll preserve
> depedency on host-autoconf, host-automake and host-libtool.
I'm not sure to understand everything.
Do you want this?define OPEN_LLDP_PRE_CONFIGURE_HOOKS? ? ? ? (cd $(@D) && mkdir -p m4)endef
Do you also want this? :OPEN_LLDP_DEPENDENCIES +=?host-autoconf host-automake host-libtool
Thank youLaurent
From: Yegor Yefremov <yegorslists@googlemail.com>
To: Laurent Charpentier <laurent_pubs@yahoo.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>; buildroot <buildroot@buildroot.org>
Sent: Monday, January 15, 2018 3:53 PM
Subject: Re: [Buildroot] [PATCH 1/1] open-lldp: new package
On Mon, Jan 15, 2018 at 1:50 PM, Laurent Charpentier
<laurent_pubs@yahoo.com> wrote:
> Hi Thomas and Yegor,
>
> On Fri, 12 Jan 2018 22:29:44 +0100, Yegor Yefremov wrote:
>
>> > So instead, please keep <pkg>_AUTORECONF = YES, and if the missing m4
>> > folder is the only problem (but I doubt it because the bootstrap.sh
>> > script doesn't create it), then add a post-extract hook that creates
>> > the m4 file.
>>
>> bootstrap.sh doesn't create m4 folder, but if you just clone the
>> open-lldp repo and invoke "autoreconf -i", it would just complain
>> about missing m4 folder, but create it. In BR environment we get an
>> error. We had similar situation earlier with some other package
>> (libsoc) and I coudn't find the case of the problem, so I just added
>> m4 upstream and now it is working.
>
> Here are some experiments on my side.
> (1) AUTORECONF=yes (no use of ./bootstrap.sh)
> -> ./configure fails
use this variant and create a LIBFOO_PRE_CONFIGURE_HOOKS in order to
create m4 folder via "mkdir -p". That's all. This way you'll preserve
depedency on host-autoconf, host-automake and host-libtool.
Yegor
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180115/aaf7dfa7/attachment.html>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-15 15:15 ` Laurent Charpentier
@ 2018-01-15 15:21 ` Yegor Yefremov
2018-01-15 15:40 ` Thomas Petazzoni
0 siblings, 1 reply; 15+ messages in thread
From: Yegor Yefremov @ 2018-01-15 15:21 UTC (permalink / raw)
To: buildroot
On Mon, Jan 15, 2018 at 4:15 PM, Laurent Charpentier
<laurent_pubs@yahoo.com> wrote:
> Hi Yegor,
>
>>> Here are some experiments on my side.
>>> (1) AUTORECONF=yes (no use of ./bootstrap.sh)
>>> -> ./configure fails
>>
>> use this variant and create a LIBFOO_PRE_CONFIGURE_HOOKS in order to
>> create m4 folder via "mkdir -p". That's all. This way you'll preserve
>> depedency on host-autoconf, host-automake and host-libtool.
>
> I'm not sure to understand everything.
>
> Do you want this?
> define OPEN_LLDP_PRE_CONFIGURE_HOOKS
> (cd $(@D) && mkdir -p m4)
> endef
Yes.
> Do you also want this? :
> OPEN_LLDP_DEPENDENCIES += host-autoconf host-automake host-libtool
No. AUTORECONF=yes automagically takes care of these dependencies.
Yegor
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-15 15:21 ` Yegor Yefremov
@ 2018-01-15 15:40 ` Thomas Petazzoni
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Petazzoni @ 2018-01-15 15:40 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 15 Jan 2018 16:21:13 +0100, Yegor Yefremov wrote:
> > define OPEN_LLDP_PRE_CONFIGURE_HOOKS
> > (cd $(@D) && mkdir -p m4)
> > endef
>
> Yes.
Minor nit:
mkdir -p $(@D)/m4
is sufficient. No need to "cd" into that folder.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/1] open-lldp: new package
2018-01-12 22:38 ` Thomas Petazzoni
2018-01-15 12:50 ` Laurent Charpentier
@ 2018-01-16 8:22 ` Yegor Yefremov
1 sibling, 0 replies; 15+ messages in thread
From: Yegor Yefremov @ 2018-01-16 8:22 UTC (permalink / raw)
To: buildroot
On Fri, Jan 12, 2018 at 11:38 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri, 12 Jan 2018 22:29:44 +0100, Yegor Yefremov wrote:
>
>> > So instead, please keep <pkg>_AUTORECONF = YES, and if the missing m4
>> > folder is the only problem (but I doubt it because the bootstrap.sh
>> > script doesn't create it), then add a post-extract hook that creates
>> > the m4 file.
>>
>> bootstrap.sh doesn't create m4 folder, but if you just clone the
>> open-lldp repo and invoke "autoreconf -i", it would just complain
>> about missing m4 folder, but create it. In BR environment we get an
>> error. We had similar situation earlier with some other package
>> (libsoc) and I coudn't find the case of the problem, so I just added
>> m4 upstream and now it is working.
>
> Interesting, I never realized that. After a bit of experiment, it seems
> like passing a -I option makes a difference:
>
> thomas at windsurf:~/projets/open-lldp (master)$ autoreconf -f -i -I "/home/thomas/projets/buildroot/output/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/share/aclocal" -I "/home/thomas/projets/buildroot/output/host/share/aclocal"
> aclocal: error: couldn't open directory 'm4': No such file or directory
> autoreconf: aclocal failed with exit status: 1
> thomas at windsurf:~/projets/open-lldp (master)$ autoreconf -f -i -I "/home/thomas/projets/buildroot/output/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/share/aclocal"
> aclocal: error: couldn't open directory 'm4': No such file or directory
> autoreconf: aclocal failed with exit status: 1
> thomas at windsurf:~/projets/open-lldp (master)$ autoreconf -f -i -I "/home/thomas/projets/buildroot/output/host/share/aclocal"
> aclocal: error: couldn't open directory 'm4': No such file or directory
> autoreconf: aclocal failed with exit status: 1
> thomas at windsurf:~/projets/open-lldp (master)$ autoreconf -f -i
> aclocal: warning: couldn't open directory 'm4': No such file or directory
> libtoolize: putting auxiliary files in '.'.
> libtoolize: copying file './ltmain.sh'
> libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
> libtoolize: copying file 'm4/libtool.m4'
> libtoolize: copying file 'm4/ltoptions.m4'
> libtoolize: copying file 'm4/ltsugar.m4'
> libtoolize: copying file 'm4/ltversion.m4'
> libtoolize: copying file 'm4/lt~obsolete.m4'
> configure.ac:5: installing './ar-lib'
> configure.ac:5: installing './compile'
> configure.ac:19: installing './config.guess'
> configure.ac:19: installing './config.sub'
> configure.ac:2: installing './install-sh'
> configure.ac:2: installing './missing'
> Makefile.am: installing './depcomp'
>
> Even more funny:
>
> thomas at windsurf:~/projets/open-lldp (master)$ mkdir /tmp/foo
> thomas at windsurf:~/projets/open-lldp (master)$ autoreconf -f -i -I /tmp/foo/
> aclocal: error: couldn't open directory 'm4': No such file or directory
> autoreconf: aclocal failed with exit status: 1
>
> Not sure what's going on here :)
Have found this discussion: https://bugzilla.redhat.com/show_bug.cgi?id=901333
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2018-01-16 8:22 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-12 11:00 [Buildroot] [PATCH 1/1] Added lldpad (LLDP Agent Daemon) package Laurent Charpentier
2018-01-12 11:00 ` [Buildroot] [PATCH 1/1] open-lldp: new package Laurent Charpentier
2018-01-12 11:05 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2018-01-12 14:01 Laurent Charpentier
2018-01-12 14:46 ` Yegor Yefremov
2018-01-12 21:04 ` Thomas Petazzoni
2018-01-12 21:29 ` Yegor Yefremov
2018-01-12 22:38 ` Thomas Petazzoni
2018-01-15 12:50 ` Laurent Charpentier
2018-01-15 13:47 ` Thomas Petazzoni
2018-01-15 14:52 ` Yegor Yefremov
2018-01-15 15:15 ` Laurent Charpentier
2018-01-15 15:21 ` Yegor Yefremov
2018-01-15 15:40 ` Thomas Petazzoni
2018-01-16 8:22 ` Yegor Yefremov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox