* [Buildroot] [PATCH] package/openssh: also install ssh-copy-id script @ 2018-02-07 18:35 julien.boibessot at free.fr 2018-02-07 18:54 ` Yann E. MORIN 2018-02-08 22:11 ` Thomas Petazzoni 0 siblings, 2 replies; 5+ messages in thread From: julien.boibessot at free.fr @ 2018-02-07 18:35 UTC (permalink / raw) To: buildroot From: Julien BOIBESSOT <julien.boibessot@armadeus.com> This script is useful to copy SSH keys between client and server [1] and installed on most distributions (for example on debian: [2]). [1] https://www.ssh.com/ssh/copy-id [2] https://packages.debian.org/fr/jessie/armhf/openssh-client/filelist Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com> diff --git a/package/openssh/openssh.mk b/package/openssh/openssh.mk index 6b7ac22..b0075e9 100644 --- a/package/openssh/openssh.mk +++ b/package/openssh/openssh.mk @@ -73,4 +73,10 @@ define OPENSSH_INSTALL_INIT_SYSV $(TARGET_DIR)/etc/init.d/S50sshd endef +define OPENSSH_INSTALL_SSH_COPY_ID + $(INSTALL) -D -m 755 $(@D)/contrib/ssh-copy-id $(TARGET_DIR)/usr/bin +endef + +OPENSSH_POST_INSTALL_TARGET_HOOKS += OPENSSH_INSTALL_SSH_COPY_ID + $(eval $(autotools-package)) -- 2.1.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/openssh: also install ssh-copy-id script 2018-02-07 18:35 [Buildroot] [PATCH] package/openssh: also install ssh-copy-id script julien.boibessot at free.fr @ 2018-02-07 18:54 ` Yann E. MORIN 2018-02-08 10:28 ` Julien Boibessot 2018-02-08 22:11 ` Thomas Petazzoni 1 sibling, 1 reply; 5+ messages in thread From: Yann E. MORIN @ 2018-02-07 18:54 UTC (permalink / raw) To: buildroot Julien, All, On 2018-02-07 19:35 +0100, julien.boibessot at free.fr spake thusly: > From: Julien BOIBESSOT <julien.boibessot@armadeus.com> > > This script is useful to copy SSH keys between client and server [1] and > installed on most distributions (for example on debian: [2]). > > [1] https://www.ssh.com/ssh/copy-id > [2] https://packages.debian.org/fr/jessie/armhf/openssh-client/filelist > > Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com> > > diff --git a/package/openssh/openssh.mk b/package/openssh/openssh.mk > index 6b7ac22..b0075e9 100644 > --- a/package/openssh/openssh.mk > +++ b/package/openssh/openssh.mk > @@ -73,4 +73,10 @@ define OPENSSH_INSTALL_INIT_SYSV > $(TARGET_DIR)/etc/init.d/S50sshd > endef > > +define OPENSSH_INSTALL_SSH_COPY_ID > + $(INSTALL) -D -m 755 $(@D)/contrib/ssh-copy-id $(TARGET_DIR)/usr/bin Usually, we write the full mode, i.e. 0755 (but the tree is mixed: 371 iterations of '0755', but only 116 for '0755'). Regards, Yann E. MORIN. > +endef > + > +OPENSSH_POST_INSTALL_TARGET_HOOKS += OPENSSH_INSTALL_SSH_COPY_ID > + > $(eval $(autotools-package)) > -- > 2.1.4 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/openssh: also install ssh-copy-id script 2018-02-07 18:54 ` Yann E. MORIN @ 2018-02-08 10:28 ` Julien Boibessot 2018-02-08 16:21 ` Yann E. MORIN 0 siblings, 1 reply; 5+ messages in thread From: Julien Boibessot @ 2018-02-08 10:28 UTC (permalink / raw) To: buildroot Hello Yann, thanks for reviewing, On 07/02/2018 19:54, Yann E. MORIN wrote: > Julien, All, > > On 2018-02-07 19:35 +0100, julien.boibessot at free.fr spake thusly: >> From: Julien BOIBESSOT <julien.boibessot@armadeus.com> >> >> This script is useful to copy SSH keys between client and server [1] and >> installed on most distributions (for example on debian: [2]). >> >> [1] https://www.ssh.com/ssh/copy-id >> [2] https://packages.debian.org/fr/jessie/armhf/openssh-client/filelist >> >> Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com> >> >> diff --git a/package/openssh/openssh.mk b/package/openssh/openssh.mk >> index 6b7ac22..b0075e9 100644 >> --- a/package/openssh/openssh.mk >> +++ b/package/openssh/openssh.mk >> @@ -73,4 +73,10 @@ define OPENSSH_INSTALL_INIT_SYSV >> $(TARGET_DIR)/etc/init.d/S50sshd >> endef >> >> +define OPENSSH_INSTALL_SSH_COPY_ID >> + $(INSTALL) -D -m 755 $(@D)/contrib/ssh-copy-id $(TARGET_DIR)/usr/bin > Usually, we write the full mode, i.e. 0755 (but the tree is mixed: 371 > iterations of '0755', but only 116 for '0755'). Well, in fact, I just copy-pasted what was done line 44 of the same makefile. O:-) Regards, Julien ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/openssh: also install ssh-copy-id script 2018-02-08 10:28 ` Julien Boibessot @ 2018-02-08 16:21 ` Yann E. MORIN 0 siblings, 0 replies; 5+ messages in thread From: Yann E. MORIN @ 2018-02-08 16:21 UTC (permalink / raw) To: buildroot Julien, All, On 2018-02-08 11:28 +0100, Julien Boibessot spake thusly: > > On 07/02/2018 19:54, Yann E. MORIN wrote: > > Julien, All, > > > > On 2018-02-07 19:35 +0100, julien.boibessot at free.fr spake thusly: > >> From: Julien BOIBESSOT <julien.boibessot@armadeus.com> > >> > >> This script is useful to copy SSH keys between client and server [1] and > >> installed on most distributions (for example on debian: [2]). > >> > >> [1] https://www.ssh.com/ssh/copy-id > >> [2] https://packages.debian.org/fr/jessie/armhf/openssh-client/filelist > >> > >> Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com> > >> > >> diff --git a/package/openssh/openssh.mk b/package/openssh/openssh.mk > >> index 6b7ac22..b0075e9 100644 > >> --- a/package/openssh/openssh.mk > >> +++ b/package/openssh/openssh.mk > >> @@ -73,4 +73,10 @@ define OPENSSH_INSTALL_INIT_SYSV > >> $(TARGET_DIR)/etc/init.d/S50sshd > >> endef > >> > >> +define OPENSSH_INSTALL_SSH_COPY_ID > >> + $(INSTALL) -D -m 755 $(@D)/contrib/ssh-copy-id $(TARGET_DIR)/usr/bin > > Usually, we write the full mode, i.e. 0755 (but the tree is mixed: 371 > > iterations of '0755', but only 116 for '0755'). > > Well, in fact, I just copy-pasted what was done line 44 of the same > makefile. Then, intra-file consistency wins. ;-) Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/openssh: also install ssh-copy-id script 2018-02-07 18:35 [Buildroot] [PATCH] package/openssh: also install ssh-copy-id script julien.boibessot at free.fr 2018-02-07 18:54 ` Yann E. MORIN @ 2018-02-08 22:11 ` Thomas Petazzoni 1 sibling, 0 replies; 5+ messages in thread From: Thomas Petazzoni @ 2018-02-08 22:11 UTC (permalink / raw) To: buildroot Hello, On Wed, 7 Feb 2018 19:35:59 +0100, julien.boibessot at free.fr wrote: > +define OPENSSH_INSTALL_SSH_COPY_ID > + $(INSTALL) -D -m 755 $(@D)/contrib/ssh-copy-id $(TARGET_DIR)/usr/bin $(INSTALL) -D requires a full destination path, i.e $(TARGET_DIR)/usr/bin/ssh-copy-id, to be guaranteed to work correctly when $(TARGET_DIR)/usr/bin doesn't exist. So I've fixed that and applied to next. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-08 22:11 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-02-07 18:35 [Buildroot] [PATCH] package/openssh: also install ssh-copy-id script julien.boibessot at free.fr 2018-02-07 18:54 ` Yann E. MORIN 2018-02-08 10:28 ` Julien Boibessot 2018-02-08 16:21 ` Yann E. MORIN 2018-02-08 22:11 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox