[Buildroot] [PATCH] ltp-testsuite: add numactl as optional dependency

[Buildroot] [PATCH] ltp-testsuite: add numactl as optional dependency

[Baruch Siach]

Make the detection of libnuma in the configure script consistent when
the numactl package is enabled.

ltp-testsuite does not currently take explicit enable/disable for
libnuma, so none are used. The next ltp-testsuite version will add these
options.

Cc: Petr Vorel <petr.vorel@gmail.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/ltp-testsuite/ltp-testsuite.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk
index 5e0b35d12a22..c47f587836b3 100644
--- a/package/ltp-testsuite/ltp-testsuite.mk
+++ b/package/ltp-testsuite/ltp-testsuite.mk
@@ -40,6 +40,13 @@ else
 LTP_TESTSUITE_CONF_ENV += ac_cv_lib_cap_cap_compare=no
 endif
 
+# No explicit enable/disable options
+ifeq ($(BR2_PACKAGE_NUMACTL),y)
+LTP_TESTSUITE_DEPENDENCIES += numactl
+else
+LTP_TESTSUITE_CONF_ENV += have_numa_headers=no
+endif
+
 # ltp-testsuite uses <fts.h>, which isn't compatible with largefile
 # support.
 LTP_TESTSUITE_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
-- 
2.15.1

[Buildroot] [PATCH] ltp-testsuite: add numactl as optional dependency

[Petr Vorel]

Hi Baruch,
> Make the detection of libnuma in the configure script consistent when
> the numactl package is enabled.

> ltp-testsuite does not currently take explicit enable/disable for
> libnuma, so none are used. The next ltp-testsuite version will add these
> options.

> Cc: Petr Vorel <petr.vorel@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/ltp-testsuite/ltp-testsuite.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

> diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk
> index 5e0b35d12a22..c47f587836b3 100644
> --- a/package/ltp-testsuite/ltp-testsuite.mk
> +++ b/package/ltp-testsuite/ltp-testsuite.mk
> @@ -40,6 +40,13 @@ else
>  LTP_TESTSUITE_CONF_ENV += ac_cv_lib_cap_cap_compare=no
>  endif

> +# No explicit enable/disable options
> +ifeq ($(BR2_PACKAGE_NUMACTL),y)
> +LTP_TESTSUITE_DEPENDENCIES += numactl
> +else
> +LTP_TESTSUITE_CONF_ENV += have_numa_headers=no
> +endif
> +
>  # ltp-testsuite uses <fts.h>, which isn't compatible with largefile
>  # support.
>  LTP_TESTSUITE_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
Thanks for implementing it, LGTM.
I just think whether it wouldn't be better to create config option
BR2_PACKAGE_LTP_TESTSUITE_LIBNUMA which would select numactl (this would also inform user
about this dependency).


Kind regards,
Petr

[Buildroot] [PATCH] ltp-testsuite: add numactl as optional dependency

[Arnout Vandecappelle]

On 07-02-18 20:49, Petr Vorel wrote:
> Hi Baruch,
>> Make the detection of libnuma in the configure script consistent when
>> the numactl package is enabled.
> 
>> ltp-testsuite does not currently take explicit enable/disable for
>> libnuma, so none are used. The next ltp-testsuite version will add these
>> options.
> 
>> Cc: Petr Vorel <petr.vorel@gmail.com>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>>  package/ltp-testsuite/ltp-testsuite.mk | 7 +++++++
>>  1 file changed, 7 insertions(+)
> 
>> diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk
>> index 5e0b35d12a22..c47f587836b3 100644
>> --- a/package/ltp-testsuite/ltp-testsuite.mk
>> +++ b/package/ltp-testsuite/ltp-testsuite.mk
>> @@ -40,6 +40,13 @@ else
>>  LTP_TESTSUITE_CONF_ENV += ac_cv_lib_cap_cap_compare=no
>>  endif
> 
>> +# No explicit enable/disable options
>> +ifeq ($(BR2_PACKAGE_NUMACTL),y)
>> +LTP_TESTSUITE_DEPENDENCIES += numactl
>> +else
>> +LTP_TESTSUITE_CONF_ENV += have_numa_headers=no
>> +endif
>> +
>>  # ltp-testsuite uses <fts.h>, which isn't compatible with largefile
>>  # support.
>>  LTP_TESTSUITE_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
> Thanks for implementing it, LGTM.
> I just think whether it wouldn't be better to create config option
> BR2_PACKAGE_LTP_TESTSUITE_LIBNUMA which would select numactl (this would also inform user
> about this dependency).

 We generally don't do that unless there is a very good reason, to avoid
proliferation of Config.in options. In this case, I don't see a very good reason.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] ltp-testsuite: add numactl as optional dependency

[Petr Vorel]

Hi Arnout,

<snip>
> >> +# No explicit enable/disable options
> >> +ifeq ($(BR2_PACKAGE_NUMACTL),y)
> >> +LTP_TESTSUITE_DEPENDENCIES += numactl
> >> +else
> >> +LTP_TESTSUITE_CONF_ENV += have_numa_headers=no
> >> +endif
> >> +
> >>  # ltp-testsuite uses <fts.h>, which isn't compatible with largefile
> >>  # support.
> >>  LTP_TESTSUITE_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
> > Thanks for implementing it, LGTM.
> > I just think whether it wouldn't be better to create config option
> > BR2_PACKAGE_LTP_TESTSUITE_LIBNUMA which would select numactl (this would also inform user
> > about this dependency).

>  We generally don't do that unless there is a very good reason, to avoid
> proliferation of Config.in options. In this case, I don't see a very good reason.
OK, thanks for info.
Yesterday we added --without-numa config option to properly disable and there will probably be some more as people demand it. So I thought it would be good for people to be able to choose.


Kind regards,
Petr

[Buildroot] [PATCH] ltp-testsuite: add numactl as optional dependency

[Thomas Petazzoni]

Hello,

On Wed,  7 Feb 2018 21:04:48 +0200, Baruch Siach wrote:
> Make the detection of libnuma in the configure script consistent when
> the numactl package is enabled.
> 
> ltp-testsuite does not currently take explicit enable/disable for
> libnuma, so none are used. The next ltp-testsuite version will add these
> options.
> 
> Cc: Petr Vorel <petr.vorel@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/ltp-testsuite/ltp-testsuite.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com