Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] support/dependencies/dependencies.sh: check for Python argparse module
Date: Sat, 3 Mar 2018 17:07:11 +0100	[thread overview]
Message-ID: <20180303160711.GB20055@scaer> (raw)
In-Reply-To: <20180303143620.16859-2-thomas.petazzoni@bootlin.com>

Thomas, All,

On 2018-03-03 15:36 +0100, Thomas Petazzoni spake thusly:
> The script support/scripts/check-uniq-files uses the argparse Python
> module. In most recent Python versions (starting with 2.7), the
> argparse module is part of the standard library, and we already check
> for the availability of Python in
> support/dependencies/dependencies.sh.
> 
> However, when running on an ancient distribution with Python 2.6, the
> argparse module is not part of the Python standard library, but
> available as an external module. Without this module, the build fails,
> because check-uniq-files, which is used in target-finalize, fails to
> run.
> 
> To avoid this failure, this commit adds a check in
> support/dependencies/dependencies.sh to verify that the argparse
> module is available.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  support/dependencies/dependencies.sh | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
> index 1804e85508..423fed8110 100755
> --- a/support/dependencies/dependencies.sh
> +++ b/support/dependencies/dependencies.sh
> @@ -288,3 +288,8 @@ if [ -n "$missing_perl_modules" ] ; then
>  	echo
>  	exit 1
>  fi
> +
> +if ! python -c "import argparse" > /dev/null 2>&1 ; then
> +	echo "Your Python installation is not complete enough: argparse module is missing"
> +	exit 1
> +fi
> -- 
> 2.14.3
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2018-03-03 16:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-03 14:36 [Buildroot] [PATCH 1/2] support/scripts/check-uniq-files: add indices in format string Thomas Petazzoni
2018-03-03 14:36 ` [Buildroot] [PATCH 2/2] support/dependencies/dependencies.sh: check for Python argparse module Thomas Petazzoni
2018-03-03 16:07   ` Yann E. MORIN [this message]
2018-03-03 16:19   ` Peter Korsgaard
2018-03-03 16:01 ` [Buildroot] [PATCH 1/2] support/scripts/check-uniq-files: add indices in format string Yann E. MORIN
2018-03-03 16:18 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180303160711.GB20055@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox