Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] support/dependencies/dependencies.sh: check for Python argparse module
Date: Sat, 03 Mar 2018 17:19:05 +0100	[thread overview]
Message-ID: <87muzpb092.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180303143620.16859-2-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Sat, 3 Mar 2018 15:36:20 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > The script support/scripts/check-uniq-files uses the argparse Python
 > module. In most recent Python versions (starting with 2.7), the
 > argparse module is part of the standard library, and we already check
 > for the availability of Python in
 > support/dependencies/dependencies.sh.

 > However, when running on an ancient distribution with Python 2.6, the
 > argparse module is not part of the Python standard library, but
 > available as an external module. Without this module, the build fails,
 > because check-uniq-files, which is used in target-finalize, fails to
 > run.

 > To avoid this failure, this commit adds a check in
 > support/dependencies/dependencies.sh to verify that the argparse
 > module is available.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2018-03-03 16:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-03 14:36 [Buildroot] [PATCH 1/2] support/scripts/check-uniq-files: add indices in format string Thomas Petazzoni
2018-03-03 14:36 ` [Buildroot] [PATCH 2/2] support/dependencies/dependencies.sh: check for Python argparse module Thomas Petazzoni
2018-03-03 16:07   ` Yann E. MORIN
2018-03-03 16:19   ` Peter Korsgaard [this message]
2018-03-03 16:01 ` [Buildroot] [PATCH 1/2] support/scripts/check-uniq-files: add indices in format string Yann E. MORIN
2018-03-03 16:18 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87muzpb092.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox