From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] support/scripts/check-uniq-files: add indices in format string
Date: Sat, 3 Mar 2018 17:01:35 +0100 [thread overview]
Message-ID: <20180303160135.GA20055@scaer> (raw)
In-Reply-To: <20180303143620.16859-1-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2018-03-03 15:36 +0100, Thomas Petazzoni spake thusly:
> Using {} in format strings is only supported in sufficiently recent
> Python versions. Python 2.6 doesn't support this, and only format
> strings with numbered arguments: {0}, {1}, etc.
>
> Python 2.7:
>
> $ python -c 'print("foo {}".format(12))'
> foo 12
> $ python -c 'print("foo {0}".format(12))'
> foo 12
>
> Python 2.6:
>
> $ python -c 'print("foo {}".format(12))'
> Traceback (most recent call last):
> File "<string>", line 1, in <module>
> ValueError: zero length field name in format
> $ python -c 'print("foo {0}".format(12))'
> foo 12
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
https://docs.python.org/release/2.6/library/string.html#formatstrings
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> support/scripts/check-uniq-files | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/scripts/check-uniq-files b/support/scripts/check-uniq-files
> index a3d176710e..be808cce03 100755
> --- a/support/scripts/check-uniq-files
> +++ b/support/scripts/check-uniq-files
> @@ -5,7 +5,7 @@ import csv
> import argparse
> from collections import defaultdict
>
> -warn = 'Warning: {} file "{}" is touched by more than one package: {}\n'
> +warn = 'Warning: {0} file "{1}" is touched by more than one package: {2}\n'
>
>
> def main():
> --
> 2.14.3
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-03-03 16:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 14:36 [Buildroot] [PATCH 1/2] support/scripts/check-uniq-files: add indices in format string Thomas Petazzoni
2018-03-03 14:36 ` [Buildroot] [PATCH 2/2] support/dependencies/dependencies.sh: check for Python argparse module Thomas Petazzoni
2018-03-03 16:07 ` Yann E. MORIN
2018-03-03 16:19 ` Peter Korsgaard
2018-03-03 16:01 ` Yann E. MORIN [this message]
2018-03-03 16:18 ` [Buildroot] [PATCH 1/2] support/scripts/check-uniq-files: add indices in format string Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180303160135.GA20055@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox