* [Buildroot] [PATCH 1/4] package/transmission: bump version to 2.9.4
@ 2018-05-02 6:05 Bernd Kuhls
2018-05-02 6:05 ` [Buildroot] [PATCH 2/4] package/transmission: fix systemd support Bernd Kuhls
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Bernd Kuhls @ 2018-05-02 6:05 UTC (permalink / raw)
To: buildroot
Removed patch 0003, a different fix was committed upstream:
https://github.com/transmission/transmission/commit/b21a6140e963491f146293c9b0a2863a9ae99ad3
Renumbered remaining patches.
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
...tp-include.patch => 0003-fix-utp-include.patch} | 0
package/transmission/0003-miniupnpc-cross.patch | 31 ----------------------
...nce-1.0.18-has-sys-quota.h-synced-with-G.patch} | 0
...0006-libsystemd.patch => 0005-libsystemd.patch} | 0
package/transmission/transmission.hash | 2 +-
package/transmission/transmission.mk | 2 +-
6 files changed, 2 insertions(+), 33 deletions(-)
rename package/transmission/{0004-fix-utp-include.patch => 0003-fix-utp-include.patch} (100%)
delete mode 100644 package/transmission/0003-miniupnpc-cross.patch
rename package/transmission/{0005-uClibc-ng-since-1.0.18-has-sys-quota.h-synced-with-G.patch => 0004-uClibc-ng-since-1.0.18-has-sys-quota.h-synced-with-G.patch} (100%)
rename package/transmission/{0006-libsystemd.patch => 0005-libsystemd.patch} (100%)
diff --git a/package/transmission/0004-fix-utp-include.patch b/package/transmission/0003-fix-utp-include.patch
similarity index 100%
rename from package/transmission/0004-fix-utp-include.patch
rename to package/transmission/0003-fix-utp-include.patch
diff --git a/package/transmission/0003-miniupnpc-cross.patch b/package/transmission/0003-miniupnpc-cross.patch
deleted file mode 100644
index 5037c2e67a..0000000000
--- a/package/transmission/0003-miniupnpc-cross.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-Fix libminiupnpc version detection
-
-Problem is known upstream: https://trac.transmissionbt.com/ticket/6140
-
-For buildroot we know the libminiupnpc version so we hard-code 2.0.
-
-Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
-
-diff -uNr transmission-2.92.org/configure.ac transmission-2.92/configure.ac
---- transmission-2.92.org/configure.ac 2016-03-06 21:23:45.336198393 +0100
-+++ transmission-2.92/configure.ac 2016-07-02 21:48:13.452385686 +0200
-@@ -386,18 +386,7 @@
- dnl MINIUPNPC_API_VERSION and we won't have to figure
- dnl it out on our own
- if test "x$upnp_version" = "xunknown" ; then
-- AC_RUN_IFELSE(
-- [AC_LANG_PROGRAM(
-- [#include <stdlib.h>
-- #include <miniupnpc/miniupnpc.h>],
-- [#ifdef MINIUPNPC_API_VERSION
-- return EXIT_SUCCESS;
-- #else
-- return EXIT_FAILURE;
-- #endif]
-- )],
-- [upnp_version=">= 1.7"]
-- )
-+ upnp_version="2.0"
- fi
-
- dnl Or maybe it's miniupnp 1.6
diff --git a/package/transmission/0005-uClibc-ng-since-1.0.18-has-sys-quota.h-synced-with-G.patch b/package/transmission/0004-uClibc-ng-since-1.0.18-has-sys-quota.h-synced-with-G.patch
similarity index 100%
rename from package/transmission/0005-uClibc-ng-since-1.0.18-has-sys-quota.h-synced-with-G.patch
rename to package/transmission/0004-uClibc-ng-since-1.0.18-has-sys-quota.h-synced-with-G.patch
diff --git a/package/transmission/0006-libsystemd.patch b/package/transmission/0005-libsystemd.patch
similarity index 100%
rename from package/transmission/0006-libsystemd.patch
rename to package/transmission/0005-libsystemd.patch
diff --git a/package/transmission/transmission.hash b/package/transmission/transmission.hash
index 4c1c3f9a3a..0d2af32f4f 100644
--- a/package/transmission/transmission.hash
+++ b/package/transmission/transmission.hash
@@ -1,3 +1,3 @@
# Locally calculated
-sha256 8815920e0a4499bcdadbbe89a4115092dab42ce5199f71ff9a926cfd12b9b90b transmission-2.93.tar.xz
+sha256 35442cc849f91f8df982c3d0d479d650c6ca19310a994eccdaa79a4af3916b7d transmission-2.94.tar.xz
sha256 20801783bf59e27d03ed6aab625b32a34e221ae95bf801db87827c8023398495 COPYING
diff --git a/package/transmission/transmission.mk b/package/transmission/transmission.mk
index 4e78604fdb..640c78c650 100644
--- a/package/transmission/transmission.mk
+++ b/package/transmission/transmission.mk
@@ -4,7 +4,7 @@
#
################################################################################
-TRANSMISSION_VERSION = 2.93
+TRANSMISSION_VERSION = 2.94
TRANSMISSION_SITE = https://github.com/transmission/transmission-releases/raw/master
TRANSMISSION_SOURCE = transmission-$(TRANSMISSION_VERSION).tar.xz
TRANSMISSION_DEPENDENCIES = \
--
2.14.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH 2/4] package/transmission: fix systemd support
2018-05-02 6:05 [Buildroot] [PATCH 1/4] package/transmission: bump version to 2.9.4 Bernd Kuhls
@ 2018-05-02 6:05 ` Bernd Kuhls
2018-05-20 13:31 ` Thomas Petazzoni
2018-05-02 6:05 ` [Buildroot] [PATCH 3/4] package/transmission: fix inotify configure option Bernd Kuhls
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Bernd Kuhls @ 2018-05-02 6:05 UTC (permalink / raw)
To: buildroot
Patch 0005-libsystemd.patch backports an upstream commit which renames
the systemd configure option.
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/transmission/transmission.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/transmission/transmission.mk b/package/transmission/transmission.mk
index 640c78c650..f15d037266 100644
--- a/package/transmission/transmission.mk
+++ b/package/transmission/transmission.mk
@@ -49,9 +49,9 @@ TRANSMISSION_CONF_OPTS += --enable-daemon
ifeq ($(BR2_PACKAGE_SYSTEMD),y)
TRANSMISSION_DEPENDENCIES += systemd
-TRANSMISSION_CONF_OPTS += --with-systemd-daemon
+TRANSMISSION_CONF_OPTS += --with-systemd
else
-TRANSMISSION_CONF_OPTS += --without-systemd-daemon
+TRANSMISSION_CONF_OPTS += --without-systemd
endif
define TRANSMISSION_USERS
--
2.14.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH 2/4] package/transmission: fix systemd support
2018-05-02 6:05 ` [Buildroot] [PATCH 2/4] package/transmission: fix systemd support Bernd Kuhls
@ 2018-05-20 13:31 ` Thomas Petazzoni
2018-06-11 21:15 ` Peter Korsgaard
0 siblings, 1 reply; 10+ messages in thread
From: Thomas Petazzoni @ 2018-05-20 13:31 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 2 May 2018 08:05:38 +0200, Bernd Kuhls wrote:
> Patch 0005-libsystemd.patch backports an upstream commit which renames
> the systemd configure option.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/transmission/transmission.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
The order of the patches in your patch series is not very good. Indeed,
patches 2/4, 3/4 and 4/4 are fixing problems that exist *today* in
Buildroot, with the current version of transmission being packaged.
Therefore, they should appear first in the series, before the bump.
This is even more relevant right now, as patches 2/4, 3/4 and 4/4
should be applied to master, while patch 1/4 is only for next.
So, I've applied this patch to master, after fixing the commit log to
mention 0006-libsystemd.patch, since the patch is named this way in
master.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/4] package/transmission: fix systemd support
2018-05-20 13:31 ` Thomas Petazzoni
@ 2018-06-11 21:15 ` Peter Korsgaard
0 siblings, 0 replies; 10+ messages in thread
From: Peter Korsgaard @ 2018-06-11 21:15 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Hello,
> On Wed, 2 May 2018 08:05:38 +0200, Bernd Kuhls wrote:
>> Patch 0005-libsystemd.patch backports an upstream commit which renames
>> the systemd configure option.
>>
>> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
>> ---
>> package/transmission/transmission.mk | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
> The order of the patches in your patch series is not very good. Indeed,
> patches 2/4, 3/4 and 4/4 are fixing problems that exist *today* in
> Buildroot, with the current version of transmission being packaged.
> Therefore, they should appear first in the series, before the bump.
> This is even more relevant right now, as patches 2/4, 3/4 and 4/4
> should be applied to master, while patch 1/4 is only for next.
> So, I've applied this patch to master, after fixing the commit log to
> mention 0006-libsystemd.patch, since the patch is named this way in
> master.
Committed to 2018.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 3/4] package/transmission: fix inotify configure option
2018-05-02 6:05 [Buildroot] [PATCH 1/4] package/transmission: bump version to 2.9.4 Bernd Kuhls
2018-05-02 6:05 ` [Buildroot] [PATCH 2/4] package/transmission: fix systemd support Bernd Kuhls
@ 2018-05-02 6:05 ` Bernd Kuhls
2018-05-20 13:37 ` Thomas Petazzoni
2018-05-02 6:05 ` [Buildroot] [PATCH 4/4] package/transmission: remove BR2_PACKAGE_TRANSMISSION_REMOTE Bernd Kuhls
2018-05-20 13:49 ` [Buildroot] [PATCH 1/4] package/transmission: bump version to 2.9.4 Thomas Petazzoni
3 siblings, 1 reply; 10+ messages in thread
From: Bernd Kuhls @ 2018-05-02 6:05 UTC (permalink / raw)
To: buildroot
The configure option is really called --with-inotify:
https://github.com/transmission/transmission/blob/2.9x/configure.ac#L211
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/transmission/transmission.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/transmission/transmission.mk b/package/transmission/transmission.mk
index f15d037266..cb1b8f6cdd 100644
--- a/package/transmission/transmission.mk
+++ b/package/transmission/transmission.mk
@@ -16,7 +16,7 @@ TRANSMISSION_DEPENDENCIES = \
zlib
TRANSMISSION_AUTORECONF = YES
TRANSMISSION_CONF_OPTS = \
- --disable-libnotify \
+ --without-inotify \
--enable-lightweight
TRANSMISSION_LICENSE = GPL-2.0 or GPL-3.0 with OpenSSL exception
TRANSMISSION_LICENSE_FILES = COPYING
--
2.14.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 4/4] package/transmission: remove BR2_PACKAGE_TRANSMISSION_REMOTE
2018-05-02 6:05 [Buildroot] [PATCH 1/4] package/transmission: bump version to 2.9.4 Bernd Kuhls
2018-05-02 6:05 ` [Buildroot] [PATCH 2/4] package/transmission: fix systemd support Bernd Kuhls
2018-05-02 6:05 ` [Buildroot] [PATCH 3/4] package/transmission: fix inotify configure option Bernd Kuhls
@ 2018-05-02 6:05 ` Bernd Kuhls
2018-05-20 13:48 ` Thomas Petazzoni
2018-05-20 13:49 ` [Buildroot] [PATCH 1/4] package/transmission: bump version to 2.9.4 Thomas Petazzoni
3 siblings, 1 reply; 10+ messages in thread
From: Bernd Kuhls @ 2018-05-02 6:05 UTC (permalink / raw)
To: buildroot
Upstream does not provide a configure option --enable-remote.
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
Config.in.legacy | 7 +++++++
package/transmission/Config.in | 5 -----
package/transmission/transmission.mk | 6 ------
3 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/Config.in.legacy b/Config.in.legacy
index 3d8b28c5fe..418bac3898 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -145,6 +145,13 @@ endif
###############################################################################
comment "Legacy options removed in 2018.05"
+config BR2_PACKAGE_TRANSMISSION_REMOTE
+ bool "transmission remote tool option removed"
+ select BR2_LEGACY
+ help
+ Upstream does not provide a configure option for the tool
+ transmission-remote
+
config BR2_PACKAGE_IQVLINUX
bool "iqvlinux package removed"
select BR2_LEGACY
diff --git a/package/transmission/Config.in b/package/transmission/Config.in
index 2110e52ac6..dac4d1b330 100644
--- a/package/transmission/Config.in
+++ b/package/transmission/Config.in
@@ -32,11 +32,6 @@ config BR2_PACKAGE_TRANSMISSION_DAEMON
help
Install transmission daemon.
-config BR2_PACKAGE_TRANSMISSION_REMOTE
- bool "transmission-remote"
- help
- Install transmission remote management tool.
-
config BR2_PACKAGE_TRANSMISSION_GTK
bool "transmission-gtk"
depends on BR2_PACKAGE_LIBGTK3 && BR2_SYSTEM_ENABLE_NLS
diff --git a/package/transmission/transmission.mk b/package/transmission/transmission.mk
index cb1b8f6cdd..00652e7f4c 100644
--- a/package/transmission/transmission.mk
+++ b/package/transmission/transmission.mk
@@ -75,12 +75,6 @@ else
TRANSMISSION_CONF_OPTS += --disable-daemon
endif
-ifeq ($(BR2_PACKAGE_TRANSMISSION_REMOTE),y)
-TRANSMISSION_CONF_OPTS += --enable-remote
-else
-TRANSMISSION_CONF_OPTS += --disable-remote
-endif
-
ifeq ($(BR2_PACKAGE_TRANSMISSION_GTK),y)
TRANSMISSION_CONF_OPTS += --with-gtk
TRANSMISSION_DEPENDENCIES += libgtk3
--
2.14.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/4] package/transmission: bump version to 2.9.4
2018-05-02 6:05 [Buildroot] [PATCH 1/4] package/transmission: bump version to 2.9.4 Bernd Kuhls
` (2 preceding siblings ...)
2018-05-02 6:05 ` [Buildroot] [PATCH 4/4] package/transmission: remove BR2_PACKAGE_TRANSMISSION_REMOTE Bernd Kuhls
@ 2018-05-20 13:49 ` Thomas Petazzoni
3 siblings, 0 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2018-05-20 13:49 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 2 May 2018 08:05:37 +0200, Bernd Kuhls wrote:
> Removed patch 0003, a different fix was committed upstream:
> https://github.com/transmission/transmission/commit/b21a6140e963491f146293c9b0a2863a9ae99ad3
>
> Renumbered remaining patches.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> ...tp-include.patch => 0003-fix-utp-include.patch} | 0
> package/transmission/0003-miniupnpc-cross.patch | 31 ----------------------
> ...nce-1.0.18-has-sys-quota.h-synced-with-G.patch} | 0
> ...0006-libsystemd.patch => 0005-libsystemd.patch} | 0
> package/transmission/transmission.hash | 2 +-
> package/transmission/transmission.mk | 2 +-
> 6 files changed, 2 insertions(+), 33 deletions(-)
> rename package/transmission/{0004-fix-utp-include.patch => 0003-fix-utp-include.patch} (100%)
> delete mode 100644 package/transmission/0003-miniupnpc-cross.patch
> rename package/transmission/{0005-uClibc-ng-since-1.0.18-has-sys-quota.h-synced-with-G.patch => 0004-uClibc-ng-since-1.0.18-has-sys-quota.h-synced-with-G.patch} (100%)
> rename package/transmission/{0006-libsystemd.patch => 0005-libsystemd.patch} (100%)
Applied to next, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-06-11 21:15 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-02 6:05 [Buildroot] [PATCH 1/4] package/transmission: bump version to 2.9.4 Bernd Kuhls
2018-05-02 6:05 ` [Buildroot] [PATCH 2/4] package/transmission: fix systemd support Bernd Kuhls
2018-05-20 13:31 ` Thomas Petazzoni
2018-06-11 21:15 ` Peter Korsgaard
2018-05-02 6:05 ` [Buildroot] [PATCH 3/4] package/transmission: fix inotify configure option Bernd Kuhls
2018-05-20 13:37 ` Thomas Petazzoni
2018-06-11 21:15 ` Peter Korsgaard
2018-05-02 6:05 ` [Buildroot] [PATCH 4/4] package/transmission: remove BR2_PACKAGE_TRANSMISSION_REMOTE Bernd Kuhls
2018-05-20 13:48 ` Thomas Petazzoni
2018-05-20 13:49 ` [Buildroot] [PATCH 1/4] package/transmission: bump version to 2.9.4 Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox