* [Buildroot] [PATCH] network-manager: sync kernel headers comment with actual dependency
@ 2018-06-30 22:19 Thomas Petazzoni
2018-07-01 8:54 ` Yann E. MORIN
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-06-30 22:19 UTC (permalink / raw)
To: buildroot
In commit 52282828f06dc8aa3f721727f68a5096b9ed8b49
("package/network-manager: add patches to build with kernel headers
3.2"), network-manager was changed to build with kernel headers as old
as 3.2, instead of 3.7 before. The dependency was changed accordingly,
but the Config.in comment was not.
This commit fixes this inconsistency.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/network-manager/Config.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/network-manager/Config.in b/package/network-manager/Config.in
index 9602cc4a1a..ca508185f0 100644
--- a/package/network-manager/Config.in
+++ b/package/network-manager/Config.in
@@ -64,8 +64,8 @@ config BR2_PACKAGE_NETWORK_MANAGER_OVS
endif
-comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.7, dynamic library"
+comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.2, dynamic library"
depends on BR2_USE_MMU
depends on !BR2_PACKAGE_HAS_UDEV || \
- !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 || \
+ !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 || \
!BR2_TOOLCHAIN_USES_GLIBC || BR2_STATIC_LIBS
--
2.14.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] network-manager: sync kernel headers comment with actual dependency
2018-06-30 22:19 [Buildroot] [PATCH] network-manager: sync kernel headers comment with actual dependency Thomas Petazzoni
@ 2018-07-01 8:54 ` Yann E. MORIN
2018-07-01 9:03 ` Thomas Petazzoni
2018-07-19 10:09 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2018-07-01 8:54 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2018-07-01 00:19 +0200, Thomas Petazzoni spake thusly:
> In commit 52282828f06dc8aa3f721727f68a5096b9ed8b49
> ("package/network-manager: add patches to build with kernel headers
> 3.2"), network-manager was changed to build with kernel headers as old
> as 3.2, instead of 3.7 before. The dependency was changed accordingly,
> but the Config.in comment was not.
>
> This commit fixes this inconsistency.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/network-manager/Config.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/network-manager/Config.in b/package/network-manager/Config.in
> index 9602cc4a1a..ca508185f0 100644
> --- a/package/network-manager/Config.in
> +++ b/package/network-manager/Config.in
> @@ -64,8 +64,8 @@ config BR2_PACKAGE_NETWORK_MANAGER_OVS
>
> endif
>
> -comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.7, dynamic library"
> +comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.2, dynamic library"
> depends on BR2_USE_MMU
> depends on !BR2_PACKAGE_HAS_UDEV || \
> - !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 || \
> + !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 || \
> !BR2_TOOLCHAIN_USES_GLIBC || BR2_STATIC_LIBS
> --
> 2.14.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] network-manager: sync kernel headers comment with actual dependency
2018-06-30 22:19 [Buildroot] [PATCH] network-manager: sync kernel headers comment with actual dependency Thomas Petazzoni
2018-07-01 8:54 ` Yann E. MORIN
@ 2018-07-01 9:03 ` Thomas Petazzoni
2018-07-01 20:01 ` Petr Vorel
2018-07-19 10:09 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2018-07-01 9:03 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 1 Jul 2018 00:19:15 +0200, Thomas Petazzoni wrote:
> In commit 52282828f06dc8aa3f721727f68a5096b9ed8b49
> ("package/network-manager: add patches to build with kernel headers
> 3.2"), network-manager was changed to build with kernel headers as old
> as 3.2, instead of 3.7 before. The dependency was changed accordingly,
> but the Config.in comment was not.
>
> This commit fixes this inconsistency.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/network-manager/Config.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] network-manager: sync kernel headers comment with actual dependency
2018-07-01 9:03 ` Thomas Petazzoni
@ 2018-07-01 20:01 ` Petr Vorel
0 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2018-07-01 20:01 UTC (permalink / raw)
To: buildroot
Hi Thomas,
> Hello,
> On Sun, 1 Jul 2018 00:19:15 +0200, Thomas Petazzoni wrote:
> > In commit 52282828f06dc8aa3f721727f68a5096b9ed8b49
> > ("package/network-manager: add patches to build with kernel headers
> > 3.2"), network-manager was changed to build with kernel headers as old
> > as 3.2, instead of 3.7 before. The dependency was changed accordingly,
> > but the Config.in comment was not.
> > This commit fixes this inconsistency.
thanks for my old error.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] network-manager: sync kernel headers comment with actual dependency
2018-06-30 22:19 [Buildroot] [PATCH] network-manager: sync kernel headers comment with actual dependency Thomas Petazzoni
2018-07-01 8:54 ` Yann E. MORIN
2018-07-01 9:03 ` Thomas Petazzoni
@ 2018-07-19 10:09 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2018-07-19 10:09 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> In commit 52282828f06dc8aa3f721727f68a5096b9ed8b49
> ("package/network-manager: add patches to build with kernel headers
> 3.2"), network-manager was changed to build with kernel headers as old
> as 3.2, instead of 3.7 before. The dependency was changed accordingly,
> but the Config.in comment was not.
> This commit fixes this inconsistency.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2018.02.x and 2018.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-19 10:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-30 22:19 [Buildroot] [PATCH] network-manager: sync kernel headers comment with actual dependency Thomas Petazzoni
2018-07-01 8:54 ` Yann E. MORIN
2018-07-01 9:03 ` Thomas Petazzoni
2018-07-01 20:01 ` Petr Vorel
2018-07-19 10:09 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox