From: Adrian Perez de Castro <aperez@igalia.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/5] webkitgtk: enable package for aarch64
Date: Sun, 23 Sep 2018 02:53:31 +0300 [thread overview]
Message-ID: <20180922235333.85642-4-aperez@igalia.com> (raw)
In-Reply-To: <20180922235333.85642-1-aperez@igalia.com>
64-bit ARM is well supported, particularly in little-endian
configurations, where JIT can be enabled as well.
Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
package/webkitgtk/Config.in | 1 +
package/webkitgtk/webkitgtk.mk | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
index 96a7ab0c94..ac6f57e2ad 100644
--- a/package/webkitgtk/Config.in
+++ b/package/webkitgtk/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
bool
# ARM needs BLX, so v5t+, BE completely untested so disabled
default y if BR2_arm && !BR2_ARM_CPU_ARMV4
+ default y if BR2_aarch64 || BR2_aarch64_be
default y if BR2_i386 || BR2_x86_64
# Disabled on MIPS big endian due to sigbus
default y if BR2_mipsel || BR2_mips64el
diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index f28417ac73..f0293fc225 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -27,9 +27,10 @@ WEBKITGTK_CONF_OPTS = \
-DUSE_LIBNOTIFY=OFF \
-DUSE_LIBHYPHEN=OFF
-# ARM needs NEON for JIT
+# 32-bit ARM needs NEON for JIT, AArch64 is supported but not well tested
+# on big endian hence the missing $(BR2_aarch64_be).
# i386 & x86_64 don't seem to have any special requirements
-ifeq ($(BR2_ARM_CPU_HAS_NEON)$(BR2_i386)$(BR2_x86_64),y)
+ifeq ($(BR2_ARM_CPU_HAS_NEON)$(BR2_i386)$(BR2_x86_64)$(BR2_aarch64),y)
WEBKITGTK_CONF_OPTS += -DENABLE_JIT=ON
else
WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF
--
2.19.0
next prev parent reply other threads:[~2018-09-22 23:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-22 23:53 [Buildroot] [PATCH 0/5] webkitgtk: update to the latest stable and add a number of fixes Adrian Perez de Castro
2018-09-22 23:53 ` [Buildroot] [PATCH 1/5] webkitgtk: bump to version 2.22.2 Adrian Perez de Castro
2018-09-25 20:47 ` Thomas Petazzoni
2018-10-05 17:34 ` Peter Korsgaard
2018-09-22 23:53 ` [Buildroot] [PATCH 2/5] webkitgtk: add dependency on the woff2 package Adrian Perez de Castro
2018-09-25 20:52 ` Thomas Petazzoni
2018-09-27 9:41 ` Adrian Perez de Castro
2018-09-27 11:37 ` Peter Korsgaard
2018-09-27 12:44 ` Adrian Perez de Castro
2018-10-09 22:17 ` Adrian Perez de Castro
2018-10-11 18:19 ` Peter Korsgaard
2018-10-19 18:29 ` Adrian Perez de Castro
2018-10-05 17:34 ` Peter Korsgaard
2018-09-22 23:53 ` Adrian Perez de Castro [this message]
2018-09-25 20:56 ` [Buildroot] [PATCH 3/5] webkitgtk: enable package for aarch64 Thomas Petazzoni
2018-09-27 9:44 ` Adrian Perez de Castro
2018-09-22 23:53 ` [Buildroot] [PATCH 4/5] webkitgtk: enable JIT support on 32-bit MIPS Adrian Perez de Castro
2018-09-22 23:53 ` [Buildroot] [PATCH 5/5] webkitgtk: explicitly set USE_GSTREAMER_GL build option Adrian Perez de Castro
2018-09-25 20:57 ` Thomas Petazzoni
2018-09-27 12:40 ` Adrian Perez de Castro
2018-10-02 21:28 ` Arnout Vandecappelle
2018-10-09 21:12 ` Adrian Perez de Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180922235333.85642-4-aperez@igalia.com \
--to=aperez@igalia.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox