Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/5] webkitgtk: add dependency on the woff2 package
Date: Tue, 25 Sep 2018 22:52:55 +0200	[thread overview]
Message-ID: <20180925225255.3fe01107@windsurf> (raw)
In-Reply-To: <20180922235333.85642-3-aperez@igalia.com>

Hello,

On Sun, 23 Sep 2018 02:53:30 +0300, Adrian Perez de Castro wrote:
> The woff2 dependency is used to support Web fonts in WOFF2 format.
> This is a Web-facing feature that Web sites expect WebKit to support,
> and it is recommended to be unconditionally enabled. While it is
> possible to disable the feature at build time, upstream only recommends
> doing so if the target system cannot provide a woff2 package.
> 
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
>  package/webkitgtk/Config.in    | 1 +
>  package/webkitgtk/webkitgtk.mk | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)

In general, we are not really happy with optional dependencies turned
into mandatory dependencies. For example, the EFL package makes a lot
of dependencies optional, even if upstream strongly recommends to have
such dependencies enabled (to the point where efl.mk needs to pass
--enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-abb).

However, since woff2 has very few dependencies, and
woff2+brotli+host-pkgconf build in 19 seconds, it's nothing compared to
webkitgtk, so I applied your patch.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-09-25 20:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-22 23:53 [Buildroot] [PATCH 0/5] webkitgtk: update to the latest stable and add a number of fixes Adrian Perez de Castro
2018-09-22 23:53 ` [Buildroot] [PATCH 1/5] webkitgtk: bump to version 2.22.2 Adrian Perez de Castro
2018-09-25 20:47   ` Thomas Petazzoni
2018-10-05 17:34   ` Peter Korsgaard
2018-09-22 23:53 ` [Buildroot] [PATCH 2/5] webkitgtk: add dependency on the woff2 package Adrian Perez de Castro
2018-09-25 20:52   ` Thomas Petazzoni [this message]
2018-09-27  9:41     ` Adrian Perez de Castro
2018-09-27 11:37       ` Peter Korsgaard
2018-09-27 12:44         ` Adrian Perez de Castro
2018-10-09 22:17         ` Adrian Perez de Castro
2018-10-11 18:19           ` Peter Korsgaard
2018-10-19 18:29             ` Adrian Perez de Castro
2018-10-05 17:34   ` Peter Korsgaard
2018-09-22 23:53 ` [Buildroot] [PATCH 3/5] webkitgtk: enable package for aarch64 Adrian Perez de Castro
2018-09-25 20:56   ` Thomas Petazzoni
2018-09-27  9:44     ` Adrian Perez de Castro
2018-09-22 23:53 ` [Buildroot] [PATCH 4/5] webkitgtk: enable JIT support on 32-bit MIPS Adrian Perez de Castro
2018-09-22 23:53 ` [Buildroot] [PATCH 5/5] webkitgtk: explicitly set USE_GSTREAMER_GL build option Adrian Perez de Castro
2018-09-25 20:57   ` Thomas Petazzoni
2018-09-27 12:40     ` Adrian Perez de Castro
2018-10-02 21:28       ` Arnout Vandecappelle
2018-10-09 21:12         ` Adrian Perez de Castro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180925225255.3fe01107@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox