Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Perez de Castro <aperez@igalia.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] webkitgtk: enable JIT support on 32-bit MIPS
Date: Sun, 23 Sep 2018 02:53:32 +0300	[thread overview]
Message-ID: <20180922235333.85642-5-aperez@igalia.com> (raw)
In-Reply-To: <20180922235333.85642-1-aperez@igalia.com>

WebKitGTK+ is known to work on all 32-bit MIPS R2 or newer,
in little-endian mode.

Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
 package/webkitgtk/Config.in    | 9 +++++++++
 package/webkitgtk/webkitgtk.mk | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
index ac6f57e2ad..3a12b7c0ec 100644
--- a/package/webkitgtk/Config.in
+++ b/package/webkitgtk/Config.in
@@ -12,6 +12,15 @@ config BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt
 
+config BR2_PACKAGE_WEBKITGTK_MIPS_JIT_SUPPORTED
+	bool
+	# JIT is known to not work on MIPS64.
+	# Plain MIPS32 (pre R2) is not well tested and likely broken.
+	default y if BR2_MIPS_CPU_MIPS32R2
+	default y if BR2_MIPS_CPU_MIPS32R5
+	default y if BR2_MIPS_CPU_MIPS32R6
+	depends on BR2_mipsel
+
 comment "webkitgtk needs libgtk3 and a glibc toolchain w/ C++, gcc >= 6, host gcc >= 4.8"
 	depends on BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
 	depends on !BR2_PACKAGE_LIBGTK3 || !BR2_INSTALL_LIBSTDCPP || \
diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index f0293fc225..028208cb62 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -30,7 +30,7 @@ WEBKITGTK_CONF_OPTS = \
 # 32-bit ARM needs NEON for JIT, AArch64 is supported but not well tested
 # on big endian hence the missing $(BR2_aarch64_be).
 # i386 & x86_64 don't seem to have any special requirements
-ifeq ($(BR2_ARM_CPU_HAS_NEON)$(BR2_i386)$(BR2_x86_64)$(BR2_aarch64),y)
+ifeq ($(BR2_ARM_CPU_HAS_NEON)$(BR2_i386)$(BR2_x86_64)$(BR2_aarch64)$(BR2_PACKAGE_WEBKITGTK_MIPS_JIT_SUPPORTED),y)
 WEBKITGTK_CONF_OPTS += -DENABLE_JIT=ON
 else
 WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF
-- 
2.19.0

  parent reply	other threads:[~2018-09-22 23:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-22 23:53 [Buildroot] [PATCH 0/5] webkitgtk: update to the latest stable and add a number of fixes Adrian Perez de Castro
2018-09-22 23:53 ` [Buildroot] [PATCH 1/5] webkitgtk: bump to version 2.22.2 Adrian Perez de Castro
2018-09-25 20:47   ` Thomas Petazzoni
2018-10-05 17:34   ` Peter Korsgaard
2018-09-22 23:53 ` [Buildroot] [PATCH 2/5] webkitgtk: add dependency on the woff2 package Adrian Perez de Castro
2018-09-25 20:52   ` Thomas Petazzoni
2018-09-27  9:41     ` Adrian Perez de Castro
2018-09-27 11:37       ` Peter Korsgaard
2018-09-27 12:44         ` Adrian Perez de Castro
2018-10-09 22:17         ` Adrian Perez de Castro
2018-10-11 18:19           ` Peter Korsgaard
2018-10-19 18:29             ` Adrian Perez de Castro
2018-10-05 17:34   ` Peter Korsgaard
2018-09-22 23:53 ` [Buildroot] [PATCH 3/5] webkitgtk: enable package for aarch64 Adrian Perez de Castro
2018-09-25 20:56   ` Thomas Petazzoni
2018-09-27  9:44     ` Adrian Perez de Castro
2018-09-22 23:53 ` Adrian Perez de Castro [this message]
2018-09-22 23:53 ` [Buildroot] [PATCH 5/5] webkitgtk: explicitly set USE_GSTREAMER_GL build option Adrian Perez de Castro
2018-09-25 20:57   ` Thomas Petazzoni
2018-09-27 12:40     ` Adrian Perez de Castro
2018-10-02 21:28       ` Arnout Vandecappelle
2018-10-09 21:12         ` Adrian Perez de Castro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180922235333.85642-5-aperez@igalia.com \
    --to=aperez@igalia.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox